Add missing M2E lifecycle mappings metadata

* Ignore for the duplicate-finder-maven-plugin

Not sure why I have to repeat here what I had done back in January in
https://github.com/vorburger/opendaylight-eclipse-setup/commit/abf867c9a1e58686b79214c9381adcb0e224b3b6
but I can only strongly encourage all ODL developers using Eclipse to
use the opendaylight-eclipse-setup model.

also make bundles-test-lib enable the dupe CP finder (and PMD CPD),
because that actually made the problem appear under Eclipse within
odlparent - after manually locally removing the equivalent in
lifecycle-mapping-metadata.xml by opendaylight-eclipse-setup.

see also I3498cc5f3af7481cd83b4f7f69045d19668fd1da

Change-Id: I2bfbfc05600814df1fa5c866e1db3cbe2576959c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

diff --git a/bundles-test-lib/pom.xml b/bundles-test-lib/pom.xml
index dfd077c137b16415406dceb9fac832501b91df25..5772eb16abf0c70a22b6bf31cdd5d0788892a4af 100644 (file)
--- a/bundles-test-lib/pom.xml
+++ b/bundles-test-lib/pom.xml
@@ -21,6 +21,12 @@
   <artifactId>bundles-test-lib</artifactId>
   <name>ODL :: odlparent :: ${project.artifactId}</name>
 
+  <properties>
+    <!-- Opt-in to our optional code quality checks -->
+    <pmd.cpd.fail>true</pmd.cpd.fail>                    <!-- Copy/paste detection -->
+    <duplicate-finder.skip>false</duplicate-finder.skip> <!-- Classpath duplicates -->
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.osgi</groupId>

diff --git a/odlparent/pom.xml b/odlparent/pom.xml
index 1c0a3f88c1d5bcd676406b2598c96d7c3d7acecb..5bc1cf7664b75fd8382ff8c268fd0b142c0a02c2 100644 (file)
--- a/odlparent/pom.xml
+++ b/odlparent/pom.xml
@@ -1626,6 +1626,21 @@
                   </action>
                 </pluginExecution>
 
+                <pluginExecution>
+                  <pluginExecutionFilter>
+                    <groupId>org.basepom.maven</groupId>
+                    <artifactId>
+                      duplicate-finder-maven-plugin
+                    </artifactId>
+                    <versionRange>[1.2.1,)</versionRange>
+                    <goals>
+                      <goal>check</goal>
+                    </goals>
+                  </pluginExecutionFilter>
+                  <action>
+                    <ignore></ignore>
+                  </action>
+                </pluginExecution>
               </pluginExecutions>
             </lifecycleMappingMetadata>
           </configuration>