Make methods static 06/90106/2
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 29 May 2020 17:57:38 +0000 (19:57 +0200)
committerRobert Varga <nite@hq.sk>
Fri, 29 May 2020 19:46:48 +0000 (19:46 +0000)
Eclipse warning is correct, let's make sure we heed it.

Change-Id: I9e050f1e7f65ff417409a42aaa39434122497555
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
trace/mdsal-trace-impl/src/test/java/org/opendaylight/mdsal/trace/impl/CloseTrackedRegistryTest.java

index e78bcecda615ef9a0d6e8b7f7e3c6dba2d84daaf..13542ab202650c34f3bfc53ca3edf54e0f702ad5 100644 (file)
@@ -17,7 +17,7 @@ import org.junit.Test;
 public class CloseTrackedRegistryTest {
 
     private static class SomethingClosable extends AbstractCloseTracked<SomethingClosable> implements AutoCloseable {
-        SomethingClosable(CloseTrackedRegistry<SomethingClosable> transactionChainRegistry) {
+        SomethingClosable(final CloseTrackedRegistry<SomethingClosable> transactionChainRegistry) {
             super(transactionChainRegistry);
         }
 
@@ -58,7 +58,7 @@ public class CloseTrackedRegistryTest {
     }
 
     // Something like this really should be in Google Truth...
-    private <T> void assertThatIterableContains(Iterable<T> iterable, Predicate<T> predicate) {
+    private static <T> void assertThatIterableContains(final Iterable<T> iterable, final Predicate<T> predicate) {
         for (T element : iterable) {
             if (predicate.test(element)) {
                 return;
@@ -68,7 +68,7 @@ public class CloseTrackedRegistryTest {
     }
 
     @SuppressWarnings({ "resource", "unused" })
-    private void someOtherMethodWhichDoesNotClose(CloseTrackedRegistry<SomethingClosable> registry) {
+    private static void someOtherMethodWhichDoesNotClose(final CloseTrackedRegistry<SomethingClosable> registry) {
         new SomethingClosable(registry);
     }