Remove unneeded setIsSupportedToBuildEffective() 08/94808/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 26 Jan 2021 10:46:07 +0000 (11:46 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 26 Jan 2021 10:46:46 +0000 (11:46 +0100)
This flag is inherited from source, hence the set operation ends up
being a 'false -> false' transition. Just remove it and mark a FIXME
for future improvement.

Change-Id: I353e7787d9ca08eaeeed27f1100bc74757d8b5bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
yang/yang-parser-reactor/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ReplicaStatementContext.java

index b182863839c5ba33c53286be53e795c2f68f310d..eaa39de25ea6a6a47e276f9a1e3c2aeaf0d816ce 100644 (file)
@@ -41,9 +41,8 @@ final class ReplicaStatementContext<A, D extends DeclaredStatement<A>, E extends
         this.source = requireNonNull(source);
         if (source.isSupportedToBuildEffective()) {
             source.incRef();
+            // FIXME: is this call really needed? it is inherited from source
             setFullyDefined();
-        } else {
-            setIsSupportedToBuildEffective(false);
         }
     }