fix some sonar issues

Change-Id: I5fc4f68a23955b0dfac2e25dc70adbd8dc19b15f
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>

diff --git a/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraints.java b/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraints.java
index 242737c4187a44f6d551a4eae443a0f0e69c883d..5e878e02f8e1e4b6035d2c6958870ff82c6d456a 100644 (file)
--- a/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraints.java
+++ b/pce/src/main/java/org/opendaylight/transportpce/pce/PceConstraints.java
@@ -26,9 +26,8 @@ public class PceConstraints {
     private List<String> srlgToExclude = new ArrayList<String>();
     private List<String> nodesToInclude = new ArrayList<String>();
     private List<PceNode> pceNodesToInclude = new ArrayList<PceNode>();
-    public static Long constOSNR = 1L;
-    private double maxOSNR = (constOSNR / (Math.pow(10, (24 / 10.0))));
-//  List<String> srlgToInclude = new ArrayList<String>();
+    public static final Long CONST_OSNR = 1L;
+    private double maxOSNR = (CONST_OSNR / (Math.pow(10, (24 / 10.0))));
 
 
     public RoutingConstraintsSp.PceMetric getPceMetrics() {

diff --git a/pce/src/main/java/org/opendaylight/transportpce/pce/PceLink.java b/pce/src/main/java/org/opendaylight/transportpce/pce/PceLink.java
index 1108780f0fa2448219c8f0276614ba7e5f55b14d..29455273b8454c92d8939add4b02689f980cbc58 100644 (file)
--- a/pce/src/main/java/org/opendaylight/transportpce/pce/PceLink.java
+++ b/pce/src/main/java/org/opendaylight/transportpce/pce/PceLink.java
@@ -192,7 +192,7 @@ public class PceLink {
             spanOsnrDb = lowerBoundOSNR;
         }
         spanOsnrLu = Math.pow(10, (spanOsnrDb / 10.0));
-        sum = PceConstraints.constOSNR / spanOsnrLu;
+        sum = PceConstraints.CONST_OSNR / spanOsnrLu;
         linkOsnrLu = sum;
         //link_OSNR_dB = 10 * Math.log10(1 / sum);
         LOG.debug("In retrieveOSNR: link OSNR is {} dB", linkOsnrLu);