Fix OLM timer for Roadm crossconnect power setup 09/96509/6
authorVachhani, Shweta (sv111y) <sv111y@att.com>
Thu, 10 Jun 2021 21:46:22 +0000 (17:46 -0400)
committerGuillaume Lambert <guillaume.lambert@orange.com>
Tue, 10 Aug 2021 22:18:30 +0000 (22:18 +0000)
Current timer is 2 mins of warm up time.
The value recommended by OpenROADM device white paper is 20 seconds.

JIRA: TRNSPRTPCE-480
Signed-off-by: Vachhani, Shweta (sv111y) <sv111y@att.com>
Change-Id: I5e8ac03892e9d1c36214733967dc721f504d6542

olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java

index d569e6dedf5745d7412ecaa523df629c2eb8149f..31a56d8ac51622a8705fa3c216a5024de22a284e 100644 (file)
@@ -332,12 +332,13 @@ public class PowerMgmtImpl implements PowerMgmt {
                             LOG.info("Success Value is {}", setXconnPowerSuccessVal);
                             if (setXconnPowerSuccessVal) {
                                 LOG.info("Roadm-connection: {} updated ", connectionNumber);
-                                //The value recommended by the white paper is 20 seconds and not 60.
-                                //TODO - commented code because one vendor is not supporting
-                                //GainLoss with target-output-power
-                                Thread.sleep(OlmUtils.OLM_TIMER_1);
+                                Thread.sleep(OlmUtils.OLM_TIMER_2);
                                 crossConnect.setPowerLevel(nodeId, OpticalControlMode.GainLoss.getName(), powerValue,
                                         connectionNumber);
+                                //TODO make this timer value configurable via OSGi blueprint
+                                // although the value recommended by the white paper is 20 seconds.
+                                // At least one vendor product needs 60 seconds
+                                // because it is not supporting GainLoss with target-output-power.
                             } else {
                                 LOG.info("Set Power failed for Roadm-connection: {} on Node: {}", connectionNumber,
                                         nodeId);