Migrate to JUnit5 assertions 13/115113/3
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 6 Feb 2025 07:19:45 +0000 (08:19 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 6 Feb 2025 09:55:28 +0000 (10:55 +0100)
We have a few straggling places where we are still using JUnit4
assertions. Migrate all those places.

Change-Id: I3586f5d9b8b5dc5a5f294ab448bb1375be8cc550
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
13 files changed:
binding/binding-data-codec-dynamic/src/test/java/org/opendaylight/yangtools/binding/data/codec/impl/AbstractBindingCodecTest.java
binding/binding-data-codec-dynamic/src/test/java/org/opendaylight/yangtools/binding/data/codec/impl/Bug5845booleanKeyTest.java
binding/binding-data-codec-dynamic/src/test/java/org/opendaylight/yangtools/binding/data/codec/impl/LazyBindingListTest.java
binding/binding-data-codec-dynamic/src/test/java/org/opendaylight/yangtools/binding/data/codec/impl/Mdsal805Test.java
codec/yang-data-codec-binfmt/src/test/java/org/opendaylight/yangtools/yang/data/codec/binfmt/AbstractSerializationTest.java
codec/yang-data-codec-binfmt/src/test/java/org/opendaylight/yangtools/yang/data/codec/binfmt/NormalizedNodeStreamReaderWriterTest.java
codec/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/AnydataSerializeTest.java
common/yang-common/src/test/java/org/opendaylight/yangtools/yang/common/RevisionTest.java
common/yang-common/src/test/java/org/opendaylight/yangtools/yang/common/Uint16Test.java
common/yang-common/src/test/java/org/opendaylight/yangtools/yang/common/YangVersionTest.java
parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/parser/rfc7950/antlr/IOSupportTest.java
parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/stmt/Bug7146Test.java
parser/yang-parser-rfc7950/src/test/java/org/opendaylight/yangtools/yang/stmt/GroupingTest.java

index 01688483e7258688a1614d7277c5bc1155daf02d..eca3ef938d3a00ab9fc72571509c0474b90b6c5a 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.yangtools.binding.data.codec.impl;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.opendaylight.yangtools.binding.DataObject;
index 6592d34e55ef61604cbbf14317f44eb9f1817251..a61f9469b5eb66b26b8691f0ffb85c268c2470fc 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.yangtools.binding.data.codec.impl;
 
-import static org.junit.Assert.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import org.junit.jupiter.api.Test;
 import org.opendaylight.yang.gen.v1.urn.yang.foo.rev160101.BooleanContainer;
index ffe62a8ae77fc82f667cf1aede546cde7e53b66b..b42d91b7453da1a0d86880dd3fa8b9e923ce2f12 100644 (file)
@@ -10,10 +10,10 @@ package org.opendaylight.yangtools.binding.data.codec.impl;
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.CoreMatchers.not;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import java.util.ArrayList;
 import java.util.List;
index c87db31e17bec4c61a04687fe9e644d4a6c04343..a915f0424155833c6f262dd409c5aca96dcd3de7 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.yangtools.binding.data.codec.impl;
 
-import static org.junit.Assert.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
index f9796224b06f377db4104ce0cd762f786d93df4f..16d1911aa8df1e79d2a74dc5a56091990b47e9cc 100644 (file)
@@ -12,7 +12,7 @@ import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
-import org.junit.Assert;
+import org.junit.jupiter.api.Assertions;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
@@ -29,7 +29,7 @@ abstract class AbstractSerializationTest {
         }
 
         final byte[] bytes = baos.toByteArray();
-        Assert.assertEquals(expectedSize, bytes.length);
+        Assertions.assertEquals(expectedSize, bytes.length);
 
         final NormalizedNode deser;
         try {
@@ -37,7 +37,7 @@ abstract class AbstractSerializationTest {
         } catch (IOException e) {
             throw new AssertionError("Failed to deserialize", e);
         }
-        Assert.assertEquals(node, deser);
+        Assertions.assertEquals(node, deser);
         return node;
     }
 
@@ -55,7 +55,7 @@ abstract class AbstractSerializationTest {
         }
 
         final byte[] bytes = baos.toByteArray();
-        Assert.assertEquals(expectedSize, bytes.length);
+        Assertions.assertEquals(expectedSize, bytes.length);
 
         final PathArgument deser;
         try {
@@ -63,7 +63,7 @@ abstract class AbstractSerializationTest {
         } catch (IOException e) {
             throw new AssertionError("Failed to deserialize", e);
         }
-        Assert.assertEquals(arg, deser);
+        Assertions.assertEquals(arg, deser);
         return (T) deser;
     }
 
@@ -78,12 +78,12 @@ abstract class AbstractSerializationTest {
         }
 
         final byte[] bytes = baos.toByteArray();
-        Assert.assertEquals(expectedSize, bytes.length);
+        Assertions.assertEquals(expectedSize, bytes.length);
 
         try {
             final var in = NormalizedNodeDataInput.newDataInput(ByteStreams.newDataInput(bytes));
-            Assert.assertEquals(arg, in.readPathArgument());
-            Assert.assertEquals(arg, in.readPathArgument());
+            Assertions.assertEquals(arg, in.readPathArgument());
+            Assertions.assertEquals(arg, in.readPathArgument());
         } catch (IOException e) {
             throw new AssertionError("Failed to deserialize", e);
         }
@@ -91,12 +91,12 @@ abstract class AbstractSerializationTest {
 
     static final void assertSame(final NormalizedNodeStreamVersion version, final Object value,
             final int expectedSize) {
-        Assert.assertSame(value, assertEquals(version, value, expectedSize));
+        Assertions.assertSame(value, assertEquals(version, value, expectedSize));
     }
 
     static final void assertSame(final NormalizedNodeStreamVersion version, final PathArgument arg,
             final int expectedSize) {
-        Assert.assertSame(arg, assertEquals(version, arg, expectedSize));
+        Assertions.assertSame(arg, assertEquals(version, arg, expectedSize));
     }
 
     static final List<QName> generateQNames(final int size) {
index e5eb80cac851cc0b6a810c916cb66f8f564a7a07..912f67b5e55afa5ccd3eb818f48f543bb61fec80 100644 (file)
@@ -7,8 +7,10 @@
  */
 package org.opendaylight.yangtools.yang.data.codec.binfmt;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import com.google.common.io.ByteStreams;
 import java.io.ByteArrayInputStream;
@@ -199,17 +201,17 @@ class NormalizedNodeStreamReaderWriterTest {
 
         final var nnin = NormalizedNodeDataInput.newDataInput(ByteStreams.newDataInput(bytes));
 
-        final var deserialized = (ContainerNode)nnin.readNormalizedNode();
+        final var deserialized = assertInstanceOf(ContainerNode.class, nnin.readNormalizedNode());
 
         final var child = deserialized.findChildByArg(new NodeIdentifier(TestModel.ANY_XML_QNAME));
-        assertEquals("AnyXml child present", true, child.isPresent());
+        assertTrue(child.isPresent());
 
         final var xmlOutput = new StreamResult(new StringWriter());
         final var transformer = TransformerFactory.newInstance().newTransformer();
         transformer.setOutputProperty(OutputKeys.OMIT_XML_DECLARATION, "yes");
         transformer.transform(((DOMSourceAnyxmlNode)child.orElseThrow()).body(), xmlOutput);
 
-        assertEquals("XML", xml, xmlOutput.getWriter().toString());
+        assertEquals(xml, xmlOutput.getWriter().toString());
         assertEquals("http://www.w3.org/TR/html4/",
             ((DOMSourceAnyxmlNode)child.orElseThrow()).body().getNode().getNamespaceURI());
     }
index e02de21711ea575f9cc88674f31ad2cdf1aa2d63..aad254f691ebf004525e5b8aa9b572d04abfdf44 100644 (file)
@@ -7,10 +7,9 @@
  */
 package org.opendaylight.yangtools.yang.data.codec.xml;
 
-import static org.hamcrest.CoreMatchers.instanceOf;
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 
 import java.io.StringWriter;
 import javax.xml.stream.XMLOutputFactory;
@@ -65,9 +64,7 @@ class AnydataSerializeTest extends AbstractAnydataTest {
         final var xmlParser = XmlParserStream.create(streamWriter, Inference.ofDataTreePath(SCHEMA_CONTEXT, FOO_QNAME));
         xmlParser.parse(reader);
 
-        final var transformedInput = result.getResult().data();
-        assertThat(transformedInput, instanceOf(AnydataNode.class));
-        final var anydataNode = (AnydataNode<?>) transformedInput;
+        final var anydataNode = assertInstanceOf(AnydataNode.class, result.getResult().data());
 
         // serialization
         final var writer = new StringWriter();
@@ -75,11 +72,12 @@ class AnydataSerializeTest extends AbstractAnydataTest {
         final var xmlNormalizedNodeStreamWriter = XMLStreamNormalizedNodeStreamWriter.create(xmlStreamWriter,
             SCHEMA_CONTEXT);
         final var normalizedNodeWriter = NormalizedNodeWriter.forStreamWriter(xmlNormalizedNodeStreamWriter);
-        normalizedNodeWriter.write(transformedInput);
+        normalizedNodeWriter.write(anydataNode);
         normalizedNodeWriter.flush();
 
         final String serializedXml = writer.toString();
-        final String deserializeXml = getXmlFromDOMSource(((DOMSourceAnydata) anydataNode.body()).getSource());
+        final String deserializeXml = getXmlFromDOMSource(assertInstanceOf(DOMSourceAnydata.class, anydataNode.body())
+            .getSource());
         assertFalse(serializedXml.isEmpty());
 
         // Check if is Serialize Node same as Deserialize Node
@@ -139,13 +137,11 @@ class AnydataSerializeTest extends AbstractAnydataTest {
         xmlParser.flush();
 
         //Get Result
-        final var node = normalizedResult.getResult().data();
-        assertThat(node, instanceOf(AnydataNode.class));
-        final var anydataResult = (AnydataNode<?>) node;
+        final var anydataResult = assertInstanceOf(AnydataNode.class, normalizedResult.getResult().data());
 
         //Get Result in formatted String
-        assertThat(anydataResult.body(), instanceOf(DOMSourceAnydata.class));
-        final String serializedXml = getXmlFromDOMSource(((DOMSourceAnydata)anydataResult.body()).getSource());
+        final String serializedXml = getXmlFromDOMSource(assertInstanceOf(DOMSourceAnydata.class, anydataResult.body())
+            .getSource());
         final String expectedXml = toString(doc.getDocumentElement());
 
         //Looking for difference in Serialized xml and in Loaded XML
index 4bd8a920bab43b61a4469c0ef79b4035e39b6d7e..85b6101f0cf77a6c77901d0d8be4d89b8fb2052c 100644 (file)
@@ -7,10 +7,10 @@
  */
 package org.opendaylight.yangtools.yang.common;
 
-import static org.junit.Assert.assertSame;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertSame;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
index 23aa95918556da9c14b95501d9e6bfac2d0bf434..0f2fc03e014095ad4f0851d5db80cc9825ae7e90 100644 (file)
@@ -10,9 +10,9 @@ package org.opendaylight.yangtools.yang.common;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.greaterThan;
 import static org.hamcrest.Matchers.lessThan;
-import static org.junit.Assert.assertSame;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertSame;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
index 4fa7a897b4c022a7888c6fa8cb9ec87849ab8f03..4e746ef6d70d14e9c16960cf7dd92d78243e47a6 100644 (file)
@@ -7,8 +7,8 @@
  */
 package org.opendaylight.yangtools.yang.common;
 
-import static org.junit.Assert.assertNull;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.Test;
index 6e835e43f897a120730767017da202aa7c479ae4..4f7354909ac97bf1f29f21b235c6e898c17adbcb 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.yangtools.yang.parser.rfc7950.antlr;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
index 1095212053fbee5ae72309a0bab6d08a43664fd7..0b91655a83f8823bc177fa5b95ba35ec4e053e05 100644 (file)
@@ -9,8 +9,8 @@ package org.opendaylight.yangtools.yang.stmt;
 
 import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.opendaylight.yangtools.yang.stmt.StmtTestUtils.sourceForResource;
 
 import org.junit.jupiter.api.Test;
index 98510bc79f8cea38bf014a9056cecb7a4efa6277..a238a8dad97f29c5ac53cb81048f3db10d9c53a5 100644 (file)
@@ -7,12 +7,12 @@
  */
 package org.opendaylight.yangtools.yang.stmt;
 
-import static org.junit.Assert.assertNull;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import com.google.common.collect.Iterables;