Improve BindingDOMTransactionChainAdapterTest coverage

We are not testing merging transaction chains, let's do that through
a few parameters.

Change-Id: I77fb2a9e6fd335afebccc254df741670023f3750
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapterTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapterTest.java
index 5d0b3f3199d8cbd3417a6bb5da830428e3402155..0a7fbe556ade3338e478e4107a7bc5dfe9d35ab3 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapterTest.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMTransactionChainAdapterTest.java
@@ -7,49 +7,114 @@
  */
 package org.opendaylight.mdsal.binding.dom.adapter;
 
+import static java.util.Objects.requireNonNull;
 import static org.junit.Assert.assertNotNull;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doCallRealMethod;
 import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 
-import com.google.common.collect.ImmutableClassToInstanceMap;
+import java.util.Collection;
+import java.util.List;
+import java.util.function.BiFunction;
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameters;
 import org.mockito.Mock;
-import org.mockito.junit.MockitoJUnitRunner;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
+import org.mockito.quality.Strictness;
 import org.opendaylight.mdsal.binding.api.DataBroker;
+import org.opendaylight.mdsal.binding.api.TransactionChain;
 import org.opendaylight.mdsal.binding.api.TransactionChainListener;
 import org.opendaylight.mdsal.binding.dom.codec.spi.BindingDOMCodecServices;
-import org.opendaylight.mdsal.dom.api.DOMDataBroker;
 import org.opendaylight.mdsal.dom.api.DOMDataTreeReadTransaction;
+import org.opendaylight.mdsal.dom.api.DOMDataTreeReadWriteTransaction;
 import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
 import org.opendaylight.mdsal.dom.api.DOMService;
 import org.opendaylight.mdsal.dom.api.DOMTransactionChain;
+import org.opendaylight.mdsal.dom.spi.PingPongMergingDOMDataBroker;
 
-@RunWith(MockitoJUnitRunner.StrictStubs.class)
+@RunWith(Parameterized.class)
 public class BindingDOMTransactionChainAdapterTest {
+    enum TransactionChainType implements BiFunction<DataBroker, TransactionChainListener, TransactionChain> {
+        NORMAL {
+            @Override
+            public TransactionChain apply(final DataBroker broker, final TransactionChainListener listener) {
+                return broker.createTransactionChain(listener);
+            }
 
-    @Mock
-    private DOMDataBroker domService;
+            @Override
+            void mockRead(final DOMTransactionChain chain) {
+                doReturn(mock(DOMDataTreeReadTransaction.class)).when(chain).newReadOnlyTransaction();
+            }
+
+            @Override
+            void mockWrite(final DOMTransactionChain chain) {
+                doReturn(mock(DOMDataTreeWriteTransaction.class)).when(chain).newWriteOnlyTransaction();
+            }
+
+        },
+        MERGING {
+            @Override
+            public TransactionChain apply(final DataBroker broker, final TransactionChainListener listener) {
+                return broker.createMergingTransactionChain(listener);
+            }
+
+            @Override
+            void mockRead(final DOMTransactionChain chain) {
+                mockReadWrite(chain);
+            }
+
+            @Override
+            void mockWrite(final DOMTransactionChain chain) {
+                mockReadWrite(chain);
+            }
+        };
+
+        abstract void mockRead(DOMTransactionChain chain);
+
+        abstract void mockWrite(DOMTransactionChain chain);
+    }
 
+    @Rule
+    public MockitoRule rule = MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS);
+
+    @Parameters
+    public static Collection<Object[]> parameters() {
+        return List.of(new Object[] { TransactionChainType.NORMAL }, new Object[] { TransactionChainType.MERGING });
+    }
+
+    private final TransactionChainType type;
+
+    @Mock
+    private PingPongMergingDOMDataBroker domService;
     @Mock
     private DOMTransactionChain transactionChain;
-
     @Mock
     private TransactionChainListener transactionChainListener;
-
     @Mock
     private BindingDOMCodecServices mockCodecRegistry;
 
     private BindingDOMTransactionChainAdapter bindingDOMTransactionChainAdapter;
 
+    public BindingDOMTransactionChainAdapterTest(final TransactionChainType type) {
+        this.type = requireNonNull(type);
+    }
+
     @Before
     public void setUp() {
+        doCallRealMethod().when(domService).getExtensions();
         doReturn(transactionChain).when(domService).createTransactionChain(any());
-        doReturn(ImmutableClassToInstanceMap.of()).when(domService).getExtensions();
+        if (type == TransactionChainType.MERGING) {
+            doCallRealMethod().when(domService).createMergingTransactionChain(any());
+        }
+
 
         BindingDOMAdapterLoader bindingDOMAdapterLoader = new BindingDOMAdapterLoader(
                 new ConstantAdapterContext(mockCodecRegistry)) {
@@ -61,9 +126,18 @@ public class BindingDOMTransactionChainAdapterTest {
 
         BindingDOMDataBrokerAdapter bindingDOMDataBrokerAdapter =
                 (BindingDOMDataBrokerAdapter) bindingDOMAdapterLoader.load(DataBroker.class).get();
-        bindingDOMTransactionChainAdapter = (BindingDOMTransactionChainAdapter) bindingDOMDataBrokerAdapter
-                .createTransactionChain(transactionChainListener);
+        bindingDOMTransactionChainAdapter =
+            (BindingDOMTransactionChainAdapter) type.apply(bindingDOMDataBrokerAdapter, transactionChainListener);
         assertNotNull(bindingDOMTransactionChainAdapter.getDelegate());
+
+    }
+
+    static void mockReadWrite(final DOMTransactionChain chain) {
+        doReturn(mock(DOMDataTreeReadWriteTransaction.class)).when(chain).newReadWriteTransaction();
+    }
+
+    @Test
+    public void closeTest() {
         doNothing().when(transactionChain).close();
         bindingDOMTransactionChainAdapter.close();
         verify(transactionChain).close();
@@ -71,13 +145,20 @@ public class BindingDOMTransactionChainAdapterTest {
 
     @Test
     public void readTransactionTest() throws Exception {
-        doReturn(mock(DOMDataTreeReadTransaction.class)).when(transactionChain).newReadOnlyTransaction();
+        type.mockRead(transactionChain);
         assertNotNull(bindingDOMTransactionChainAdapter.newReadOnlyTransaction());
     }
 
     @Test
     public void writeTransactionTest() throws Exception {
-        doReturn(mock(DOMDataTreeWriteTransaction.class)).when(transactionChain).newWriteOnlyTransaction();
+        type.mockWrite(transactionChain);
         assertNotNull(bindingDOMTransactionChainAdapter.newWriteOnlyTransaction());
     }
-}
\ No newline at end of file
+
+    @Test
+    public void readWriteTransactionTest() throws Exception {
+        mockReadWrite(transactionChain);
+        assertNotNull(bindingDOMTransactionChainAdapter.newReadWriteTransaction());
+    }
+
+}