ConnectionAdapterImpl fields should be private

This reduces visibility of protected fields to private, allowing us to
reason about their interactions.

Change-Id: Ie3954ad548c4fe20f98bda13cedf657513bd7d11
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
index bb16877013e54b59b7048db2b42ad008bbf82120..3e68227ddac702e0b1fef1e2721e88a52f646ed9 100644 (file)
--- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
+++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
@@ -82,8 +82,7 @@ import com.google.common.util.concurrent.SettableFuture;
  * @author michal.polkorab
  */
 public class ConnectionAdapterImpl implements ConnectionFacade {
-
-    /** after this time, rpc future response objects will be thrown away (in minutes) */
+    /** after this time, RPC future response objects will be thrown away (in minutes) */
     public static final int RPC_RESPONSE_EXPIRATION = 1;
 
     private static final Logger LOG = LoggerFactory
@@ -94,9 +93,9 @@ public class ConnectionAdapterImpl implements ConnectionFacade {
     private final Channel channel;
 
     /** expiring cache for future rpcResponses */
-    protected final Cache<RpcResponseKey, ResponseExpectedRpcListener<?>> responseCache;
+    private final Cache<RpcResponseKey, ResponseExpectedRpcListener<?>> responseCache;
 
-    protected ConnectionReadyListener connectionReadyListener;
+    private ConnectionReadyListener connectionReadyListener;
     private OpenflowProtocolListener messageListener;
     private SystemNotificationsListener systemListener;
     private boolean disconnectOccured = false;