Optimize checkListeners()

This changes the use of StringBuffer to StringBuilder. Also use
Preconditions.checkState().

Change-Id: I378cc84d7b70010cd9559ad6ef3a278ce5f07c90
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
index e6c669729667bf42dd708d091f13d1725093876c..28cee017230d8116a17f9408feb1631b46275805 100644 (file)
--- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
+++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterImpl.java
@@ -424,7 +424,7 @@ public class ConnectionAdapterImpl implements ConnectionFacade {
 
     @Override
     public void checkListeners() {
-        StringBuffer buffer =  new StringBuffer();
+        final StringBuilder buffer =  new StringBuilder();
         if (systemListener == null) {
             buffer.append("SystemListener ");
         }
@@ -435,9 +435,7 @@ public class ConnectionAdapterImpl implements ConnectionFacade {
             buffer.append("ConnectionReadyListener ");
         }
 
-        if (buffer.length() > 0) {
-            throw new IllegalStateException("Missing listeners: " + buffer.toString());
-        }
+        Preconditions.checkState(buffer.length() == 0, "Missing listeners: %s", buffer.toString());
     }
 
     @Override