Do not emit empty strings for Generated*BuilderImpl

With a null argument, we can end up creating quite a few empty strings,
which end up being non-shared. Place an explicit check and return an
interned empty string instead.

Change-Id: I4fd9126c9502f2c80c76ca3bb38aa94a99d3ae4b
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/BindingGeneratorImpl.java b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/BindingGeneratorImpl.java
index a72855fd0daf97d183ddc368b5c174d32135cba5..3aaee320b4eda4230a503327b0487484e1e3cf19 100644 (file)
--- a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/BindingGeneratorImpl.java
+++ b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/BindingGeneratorImpl.java
@@ -2192,7 +2192,7 @@ public class BindingGeneratorImpl implements BindingGenerator {
 
     @VisibleForTesting
     static String replaceAllIllegalChars(final StringBuilder stringBuilder){
-        return UNICODE_CHAR_PATTERN.matcher(stringBuilder).replaceAll("\\\\\\\\u");
+        final String ret = UNICODE_CHAR_PATTERN.matcher(stringBuilder).replaceAll("\\\\\\\\u");
+        return ret.isEmpty() ? "" : ret;
     }
-
 }