Modernize openflowplugin-impl 39/104239/5
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 3 Feb 2023 11:28:58 +0000 (12:28 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 2 May 2023 14:09:28 +0000 (16:09 +0200)
We have a ton of modernizer warnings here, bring them almost completely
under control.

Change-Id: I602ef4296db21106ab18dd21fa3b58344340234d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
49 files changed:
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/ConnectionContextImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/ConnectionManagerImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/connection/listener/OpenflowProtocolListenerInitialImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/PacketInRateLimiter.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/initialization/AbstractDeviceInitializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/initialization/OF10DeviceInitializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/initialization/OF13DeviceInitializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/listener/MultiMsgCollectorImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/action/SetFieldActionDeserializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/messages/FlowMessageDeserializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyFlowStatsDeserializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/deserialization/multipart/MultipartReplyMessageDeserializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/AbstractSetFieldActionSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/OutputActionSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/actions/SetFieldActionSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/messages/PortMessageSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowAggregateStatsSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestFlowStatsSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestGroupStatsSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMessageSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterConfigSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestMeterStatsSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/MultipartRequestQueueStatsSerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldMissTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/ApplySetfieldTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/MatchTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WildcardsTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldMissTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/protocol/serialization/multipart/tablefeatures/WriteSetfieldTablePropertySerializer.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowDescriptorFactory.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/registry/flow/FlowRegistryKeyFactory.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractRequestCallback.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractService.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/AbstractSimpleService.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SimpleRequestCallback.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/multilayer/MultiLayerAggregateFlowMultipartService.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalBundleServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalEchoServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlatBatchServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalFlowsBatchServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalGroupsBatchServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalMetersBatchServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/sal/SalRoleServiceImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/singlelayer/SingleLayerAggregateFlowMultipartService.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/ofpspecific/MessageIntelligenceAgencyImpl.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/direct/AbstractDirectStatisticsService.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/MdSalRegistrationUtils.java
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/NodeConnectorRefToPortTranslator.java
openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/configuration/ConfigurationServiceFactoryImplTest.java

index 5a44e12058f5f2b2d611d7e75b32373e9706b969..a4fa77a4e8086b07bc242946ee44a9e9e69875ff 100644 (file)
@@ -8,9 +8,8 @@
 package org.opendaylight.openflowplugin.impl.connection;
 
 import static java.util.Objects.requireNonNull;
+import static java.util.Objects.requireNonNullElse;
 
-import com.google.common.base.MoreObjects;
-import com.google.common.base.Preconditions;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -39,13 +38,13 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class ConnectionContextImpl implements ConnectionContext {
+    private static final Logger LOG = LoggerFactory.getLogger(ConnectionContextImpl.class);
 
     private final ConnectionAdapter connectionAdapter;
     private volatile CONNECTION_STATE connectionState;
     private FeaturesReply featuresReply;
     private NodeId nodeId;
     private DeviceDisconnectedHandler deviceDisconnectedHandler;
-    private static final Logger LOG = LoggerFactory.getLogger(ConnectionContextImpl.class);
     private OutboundQueueProvider outboundQueueProvider;
     private OutboundQueueHandlerRegistration<OutboundQueueProvider> outboundQueueHandlerRegistration;
     private HandshakeContext handshakeContext;
@@ -71,13 +70,13 @@ public class ConnectionContextImpl implements ConnectionContext {
 
     @Override
     public OutboundQueue getOutboundQueueProvider() {
-        return this.outboundQueueProvider;
+        return outboundQueueProvider;
     }
 
     @Override
     public void setOutboundQueueProvider(final OutboundQueueProvider outboundQueueProvider) {
         this.outboundQueueProvider = outboundQueueProvider;
-        ((DeviceInfoImpl)this.deviceInfo).setOutboundQueueProvider(this.outboundQueueProvider);
+        ((DeviceInfoImpl)deviceInfo).setOutboundQueueProvider(this.outboundQueueProvider);
     }
 
     @Override
@@ -107,7 +106,7 @@ public class ConnectionContextImpl implements ConnectionContext {
 
     @Override
     public void setFeatures(final FeaturesReply newFeaturesReply) {
-        this.featuresReply = newFeaturesReply;
+        featuresReply = newFeaturesReply;
     }
 
     @Override
@@ -195,7 +194,7 @@ public class ConnectionContextImpl implements ConnectionContext {
     @Override
     public void setOutboundQueueHandleRegistration(
             final OutboundQueueHandlerRegistration<OutboundQueueProvider> newRegistration) {
-        this.outboundQueueHandlerRegistration = newRegistration;
+        outboundQueueHandlerRegistration = newRegistration;
     }
 
     private void unregisterOutboundQueue() {
@@ -228,7 +227,7 @@ public class ConnectionContextImpl implements ConnectionContext {
         LOG.info("Received early port status message for node {} with reason {} and state {}",
                 getSafeNodeIdForLOG(),
                 portStatusMessage.getReason(),
-                MoreObjects.firstNonNull(portStatusMessage.getState(), portStatusMessage.getStateV10()));
+                requireNonNullElse(portStatusMessage.getState(), portStatusMessage.getStateV10()));
 
         LOG.debug("Early port status message body is {}", portStatusMessage);
         portStatusMessages.add(portStatusMessage);
@@ -243,14 +242,14 @@ public class ConnectionContextImpl implements ConnectionContext {
 
     @Override
     public DeviceInfo getDeviceInfo() {
-        return this.deviceInfo;
+        return deviceInfo;
     }
 
     @Override
     public void handshakeSuccessful() {
-        Preconditions.checkNotNull(nodeId, "Cannot create DeviceInfo if 'NodeId' is not set!");
-        Preconditions.checkNotNull(featuresReply, "Cannot create DeviceInfo if 'features' is not set!");
-        this.deviceInfo = new DeviceInfoImpl(
+        requireNonNull(nodeId, "Cannot create DeviceInfo if 'NodeId' is not set!");
+        requireNonNull(featuresReply, "Cannot create DeviceInfo if 'features' is not set!");
+        deviceInfo = new DeviceInfoImpl(
                 nodeId,
                 DeviceStateUtil.createNodeInstanceIdentifier(nodeId),
                 featuresReply.getVersion(),
@@ -315,7 +314,7 @@ public class ConnectionContextImpl implements ConnectionContext {
             this.version = requireNonNull(version);
             this.datapathId = datapathId;
             this.outboundQueueProvider = outboundQueueProvider;
-            this.serviceGroupIdentifier = ServiceGroupIdentifier.create(this.nodeId.getValue());
+            serviceGroupIdentifier = ServiceGroupIdentifier.create(this.nodeId.getValue());
         }
 
         @Override
@@ -340,7 +339,7 @@ public class ConnectionContextImpl implements ConnectionContext {
 
         @Override
         public ServiceGroupIdentifier getServiceIdentifier() {
-            return this.serviceGroupIdentifier;
+            return serviceGroupIdentifier;
         }
 
         @Override
index be08c91e78e1aba04be0739966b8bda4ed641b3c..f68b00fe7ac77ce7ee611883351937d8df329b6b 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.connection;
 
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import java.math.BigInteger;
 import java.net.InetAddress;
@@ -198,7 +199,7 @@ public class ConnectionManagerImpl implements ConnectionManager {
 
         @Override
         public void onDataTreeChanged(@NonNull final Collection<DataTreeModification<Node>> changes) {
-            Preconditions.checkNotNull(changes, "Changes must not be null!");
+            requireNonNull(changes, "Changes must not be null!");
             for (DataTreeModification<Node> change : changes) {
                 final DataObjectModification<Node> mod = change.getRootNode();
                 switch (mod.getModificationType()) {
index 08355bdf2658b2770c84b8ba1c5092015bf05dd8..eb9c190661d8eda11143eb2f6cc118d1a035bd0d 100644 (file)
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.openflowplugin.impl.connection.listener;
 
-import com.google.common.base.Objects;
+import java.util.Objects;
 import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.connection.HandshakeContext;
 import org.opendaylight.openflowplugin.impl.connection.HandshakeStepWrapper;
@@ -123,7 +123,7 @@ public class OpenflowProtocolListenerInitialImpl implements OpenflowProtocolList
      */
     protected boolean checkState(final ConnectionContext.CONNECTION_STATE expectedState) {
         boolean verdict = true;
-        if (! Objects.equal(connectionContext.getConnectionState(), expectedState)) {
+        if (!Objects.equals(connectionContext.getConnectionState(), expectedState)) {
             verdict = false;
             LOG.info("Expected state: {}, actual state: {}", expectedState,
                     connectionContext.getConnectionState());
index 35e9729c90c59bd455832f0d14c6ac4a80eef977..31b3dab542cb0f8be77879efeae95d64930279f3 100644 (file)
@@ -7,7 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.device;
 
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
 import org.opendaylight.openflowjava.protocol.api.connection.ConnectionAdapter;
 import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
 import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.MessageSpy;
@@ -16,6 +18,7 @@ import org.slf4j.LoggerFactory;
 
 final class PacketInRateLimiter extends SimpleRatelimiter {
     private static final Logger LOG = LoggerFactory.getLogger(PacketInRateLimiter.class);
+
     private final float rejectedDrainFactor;
     private final ConnectionAdapter connectionAdapter;
     private final MessageSpy messageSpy;
@@ -26,10 +29,10 @@ final class PacketInRateLimiter extends SimpleRatelimiter {
                         final MessageSpy messageSpy,
                         float rejectedDrainFactor) {
         super(lowWatermark, highWatermark);
-        Preconditions.checkArgument(rejectedDrainFactor > 0 && rejectedDrainFactor < 1);
+        checkArgument(rejectedDrainFactor > 0 && rejectedDrainFactor < 1);
         this.rejectedDrainFactor = rejectedDrainFactor;
-        this.connectionAdapter = Preconditions.checkNotNull(connectionAdapter);
-        this.messageSpy = Preconditions.checkNotNull(messageSpy);
+        this.connectionAdapter = requireNonNull(connectionAdapter);
+        this.messageSpy = requireNonNull(messageSpy);
     }
 
     @Override
index 25aa3b4e0ed060dd766147a00dedff16350d5a20..f6c458968042e4b6a0e48a29c0bebb2546ba355e 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.device.initialization;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import java.util.Collections;
 import java.util.concurrent.Future;
@@ -23,7 +24,6 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public abstract class AbstractDeviceInitializer {
-
     private static final Logger LOG = LoggerFactory.getLogger(AbstractDeviceInitializer.class);
 
     /**
@@ -41,7 +41,7 @@ public abstract class AbstractDeviceInitializer {
                                    final boolean skipTableFeatures,
                                    @Nullable final MultipartWriterProvider multipartWriterProvider,
                                    @Nullable final ConvertorExecutor convertorExecutor) {
-        Preconditions.checkNotNull(deviceContext);
+        requireNonNull(deviceContext);
 
         // Write node to datastore
         LOG.debug("Initializing node information for node {}", deviceContext.getDeviceInfo());
index 5f2b1c266448de24910218840b29a92a90129538..e6ad0bad0253063a9ee9bb396226664332c963d0 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.device.initialization;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -55,10 +56,9 @@ public class OF10DeviceInitializer extends AbstractDeviceInitializer {
                                                      final boolean skipTableFeatures,
                                                      @Nullable final MultipartWriterProvider multipartWriterProvider,
                                                      @Nullable final ConvertorExecutor convertorExecutor) {
-        final ConnectionContext connectionContext =
-                Preconditions.checkNotNull(deviceContext.getPrimaryConnectionContext());
-        final DeviceState deviceState = Preconditions.checkNotNull(deviceContext.getDeviceState());
-        final DeviceInfo deviceInfo = Preconditions.checkNotNull(deviceContext.getDeviceInfo());
+        final ConnectionContext connectionContext = requireNonNull(deviceContext.getPrimaryConnectionContext());
+        final DeviceState deviceState = requireNonNull(deviceContext.getDeviceState());
+        final DeviceInfo deviceInfo = requireNonNull(deviceContext.getDeviceInfo());
         final CapabilitiesV10 capabilitiesV10 = connectionContext.getFeatures().getCapabilitiesV10();
 
         // Set capabilities for this device based on capabilities of connection context
index 356bede583b7d8b979bc72a9a3d8d79be362c90d..0427d9f76380501b8345357a643164670f321929 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.device.initialization;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -40,7 +41,6 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class OF13DeviceInitializer extends AbstractDeviceInitializer {
-
     private static final Logger LOG = LoggerFactory.getLogger(OF13DeviceInitializer.class);
 
     @Override
@@ -49,10 +49,9 @@ public class OF13DeviceInitializer extends AbstractDeviceInitializer {
                                                      final boolean skipTableFeatures,
                                                      @Nullable final MultipartWriterProvider multipartWriterProvider,
                                                      @Nullable final ConvertorExecutor convertorExecutor) {
-        final ConnectionContext connectionContext =
-                Preconditions.checkNotNull(deviceContext.getPrimaryConnectionContext());
-        final DeviceState deviceState = Preconditions.checkNotNull(deviceContext.getDeviceState());
-        final DeviceInfo deviceInfo = Preconditions.checkNotNull(deviceContext.getDeviceInfo());
+        final ConnectionContext connectionContext = requireNonNull(deviceContext.getPrimaryConnectionContext());
+        final DeviceState deviceState = requireNonNull(deviceContext.getDeviceState());
+        final DeviceInfo deviceInfo = requireNonNull(deviceContext.getDeviceInfo());
         final Capabilities capabilities = connectionContext.getFeatures().getCapabilities();
         LOG.debug("Setting capabilities for device {}", deviceInfo);
         DeviceStateUtil.setDeviceStateBasedOnV13Capabilities(deviceState, capabilities);
@@ -195,9 +194,7 @@ public class OF13DeviceInitializer extends AbstractDeviceInitializer {
                             // If we collected meter features, check if we have support for meters
                             // and pass this information to device context
                             if (MultipartType.OFPMPMETERFEATURES.equals(type)
-                                    && translatedReply instanceof MeterFeatures) {
-                                final MeterFeatures meterFeatures = (MeterFeatures) translatedReply;
-
+                                    && translatedReply instanceof MeterFeatures meterFeatures) {
                                 if (meterFeatures.getMaxMeter().getValue().toJava() > 0) {
                                     deviceContext.getDeviceState().setMeterAvailable(true);
                                 }
index ac100b5267e6b3a59a6c406615a247d97f6ae9e4..0a0368e04effc295d44840be6f13b9b8d9cd1021 100644 (file)
@@ -7,7 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.device.listener;
 
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
 import java.util.ArrayList;
 import java.util.List;
 import org.eclipse.jdt.annotation.NonNull;
@@ -31,22 +33,23 @@ import org.slf4j.LoggerFactory;
  */
 public class MultiMsgCollectorImpl<T extends OfHeader> implements MultiMsgCollector<T> {
     private static final Logger LOG = LoggerFactory.getLogger(MultiMsgCollectorImpl.class);
+
     private final List<T> replyCollection = new ArrayList<>();
     private final RequestContext<List<T>> requestContext;
     private final DeviceReplyProcessor deviceReplyProcessor;
 
     public MultiMsgCollectorImpl(final DeviceReplyProcessor deviceReplyProcessor,
                                  final RequestContext<List<T>> requestContext) {
-        this.deviceReplyProcessor = Preconditions.checkNotNull(deviceReplyProcessor);
-        this.requestContext = Preconditions.checkNotNull(requestContext);
+        this.deviceReplyProcessor = requireNonNull(deviceReplyProcessor);
+        this.requestContext = requireNonNull(requestContext);
     }
 
     @Override
     public void addMultipartMsg(@NonNull final T reply, final boolean reqMore,
                                 @Nullable final EventIdentifier eventIdentifier) {
-        Preconditions.checkNotNull(reply);
-        Preconditions.checkNotNull(requestContext.getXid());
-        Preconditions.checkArgument(requestContext.getXid().getValue().equals(reply.getXid()));
+        requireNonNull(reply);
+        requireNonNull(requestContext.getXid());
+        checkArgument(requestContext.getXid().getValue().equals(reply.getXid()));
         LOG.trace("Try to add Multipart reply msg with XID {}", reply.getXid());
         replyCollection.add(reply);
 
index 8484d19db40cbb24a4e1b6a15ac5fcc14fef8ce7..b4cfdbc3a7dccd6bc30fe849919bd65d2c80909e 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.deserialization.action;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistry;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistryInjector;
@@ -36,7 +37,7 @@ public class SetFieldActionDeserializer extends AbstractActionDeserializer
 
     @Override
     public Action deserialize(final ByteBuf message) {
-        final MatchEntryDeserializer deserializer = Preconditions.checkNotNull(registry).getDeserializer(MATCH_KEY);
+        final MatchEntryDeserializer deserializer = requireNonNull(registry).getDeserializer(MATCH_KEY);
         final MatchBuilder builder = new MatchBuilder();
 
         final int startIndex = message.readerIndex();
index bce42a8f69c0bcd0b022d610ab7f18cee9d5aae0..29280cb61944090014300dbb53e6d06371cdf9a9 100644 (file)
@@ -7,12 +7,12 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.deserialization.messages;
 
+import static java.util.Objects.requireNonNull;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint16;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint32;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint64;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint8;
 
-import com.google.common.base.Preconditions;
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistry;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistryInjector;
@@ -67,7 +67,7 @@ public class FlowMessageDeserializer implements OFDeserializer<FlowMessage>, Des
 
         message.skipBytes(PADDING);
 
-        final OFDeserializer<Match> matchDeserializer = Preconditions.checkNotNull(registry).getDeserializer(MATCH_KEY);
+        final OFDeserializer<Match> matchDeserializer = requireNonNull(registry).getDeserializer(MATCH_KEY);
         builder.setMatch(new MatchBuilder(matchDeserializer.deserialize(message)).build());
 
         final int length = message.readableBytes();
@@ -84,13 +84,13 @@ public class FlowMessageDeserializer implements OFDeserializer<FlowMessage>, Des
                 OFDeserializer<Instruction> deserializer = null;
 
                 if (InstructionConstants.APPLY_ACTIONS_TYPE == type) {
-                    deserializer = Preconditions.checkNotNull(registry).getDeserializer(
+                    deserializer = requireNonNull(registry).getDeserializer(
                             new MessageCodeActionExperimenterKey(
                                 EncodeConstants.OF_VERSION_1_3, type, Instruction.class,
                                 ActionPath.INVENTORY_FLOWNODE_TABLE_APPLY_ACTIONS,
                                 null));
                 } else if (InstructionConstants.WRITE_ACTIONS_TYPE == type) {
-                    deserializer = Preconditions.checkNotNull(registry).getDeserializer(
+                    deserializer = requireNonNull(registry).getDeserializer(
                             new MessageCodeActionExperimenterKey(
                                 EncodeConstants.OF_VERSION_1_3, type, Instruction.class,
                                 ActionPath.INVENTORY_FLOWNODE_TABLE_WRITE_ACTIONS,
@@ -102,7 +102,7 @@ public class FlowMessageDeserializer implements OFDeserializer<FlowMessage>, Des
                         expId = message.getUnsignedInt(message.readerIndex() + 2 * Short.BYTES);
                     }
 
-                    deserializer = Preconditions.checkNotNull(registry).getDeserializer(
+                    deserializer = requireNonNull(registry).getDeserializer(
                             new MessageCodeExperimenterKey(
                                 EncodeConstants.OF_VERSION_1_3, type, Instruction.class, expId));
                 }
index ff0840560288be46bf4aca17ea4b555f3ef76a8b..c17f6efc277aa6429c1aa9a3d24512a83079489f 100644 (file)
@@ -7,12 +7,12 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.deserialization.multipart;
 
+import static java.util.Objects.requireNonNull;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint16;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint32;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint64;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint8;
 
-import com.google.common.base.Preconditions;
 import io.netty.buffer.ByteBuf;
 import java.util.ArrayList;
 import java.util.List;
@@ -83,8 +83,7 @@ public class MultipartReplyFlowStatsDeserializer implements OFDeserializer<Multi
                     .setPacketCount(new Counter64(readUint64(itemMessage)))
                     .setByteCount(new Counter64(readUint64(itemMessage)));
 
-            final OFDeserializer<Match> matchDeserializer =
-                    Preconditions.checkNotNull(registry).getDeserializer(MATCH_KEY);
+            final OFDeserializer<Match> matchDeserializer = requireNonNull(registry).getDeserializer(MATCH_KEY);
             itemBuilder.setMatch(MatchUtil.transformMatch(matchDeserializer.deserialize(itemMessage),
                     org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.Match.class));
 
index 0d968adff2e1f84b5836588f9f5cfea96bc69f1f..a10d9ea1c6e2855203f54586e7936b445e4f46be 100644 (file)
@@ -7,9 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.deserialization.multipart;
 
+import static java.util.Objects.requireNonNull;
 import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint32;
 
-import com.google.common.base.Preconditions;
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistry;
 import org.opendaylight.openflowjava.protocol.api.extensibility.DeserializerRegistryInjector;
@@ -22,7 +22,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.multipart.types.rev170112.m
 import org.opendaylight.yangtools.yang.common.Uint32;
 
 public class MultipartReplyMessageDeserializer implements OFDeserializer<MultipartReply>, DeserializerRegistryInjector {
-
     private static final byte PADDING_IN_MULTIPART_REPLY_HEADER = 4;
 
     private DeserializerRegistry registry;
@@ -34,7 +33,7 @@ public class MultipartReplyMessageDeserializer implements OFDeserializer<Multipa
         final boolean reqMore = (message.readUnsignedShort() & 0x01) != 0;
         message.skipBytes(PADDING_IN_MULTIPART_REPLY_HEADER);
 
-        final OFDeserializer<MultipartReplyBody> deserializer = Preconditions.checkNotNull(registry)
+        final OFDeserializer<MultipartReplyBody> deserializer = requireNonNull(registry)
             .getDeserializer(new MessageCodeKey(EncodeConstants.OF_VERSION_1_3, type, MultipartReplyBody.class));
 
         return new MultipartReplyBuilder()
@@ -49,5 +48,4 @@ public class MultipartReplyMessageDeserializer implements OFDeserializer<Multipa
     public void injectDeserializerRegistry(final DeserializerRegistry deserializerRegistry) {
         registry = deserializerRegistry;
     }
-
 }
index f03d13107f7651d9e800e3cd21311009268271a7..9be635b21a5e405399def32e81fc4380a64838fd 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.actions;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -24,7 +25,7 @@ public abstract class AbstractSetFieldActionSerializer extends AbstractActionSer
 
     @Override
     public void serialize(final Action input, final ByteBuf outBuffer) {
-        final OFSerializer<Action> serializer = Preconditions.checkNotNull(registry)
+        final OFSerializer<Action> serializer = requireNonNull(registry)
                 .getSerializer(new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_3, SetFieldCase.class));
 
         serializer.serialize(buildAction(input), outBuffer);
index 54e5cab1aa8667138b21d097d97ffe4818daa457..c80daad9eac6bb1dbb356a8775aaf656b241bc06 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.actions;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.impl.util.ActionConstants;
 import org.opendaylight.openflowplugin.api.openflow.md.util.OpenflowVersion;
@@ -31,7 +32,7 @@ public class OutputActionSerializer extends AbstractActionSerializer<OutputActio
                     + outputAction.getOutputNodeConnector().getValue());
         }
         outBuffer.writeInt(value.intValue());
-        outBuffer.writeShort(MoreObjects.firstNonNull(outputAction.getMaxLength(), Uint16.ZERO).toJava());
+        outBuffer.writeShort(requireNonNullElse(outputAction.getMaxLength(), Uint16.ZERO).toJava());
         outBuffer.writeZero(ActionConstants.OUTPUT_PADDING);
     }
 
index 678c412505ca2287b03144068958439e942f1153..16699632529fdf8c417570deb72b98701586f0cb 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.protocol.serialization.actions;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.HeaderSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -34,7 +34,7 @@ public class SetFieldActionSerializer extends AbstractActionSerializer<SetFieldC
 
         // Serialize match (using small workaround with serializeHeader method to serialize only match entries)
         final SetField setField = action.getSetField();
-        final HeaderSerializer<Match> serializer = Preconditions.checkNotNull(registry)
+        final HeaderSerializer<Match> serializer = requireNonNull(registry)
                 .getSerializer(new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_3, Match.class));
         serializer.serializeHeader(setField, outBuffer);
 
index 2928bf38ce7bc52d9e07b3e7ddf0db671cd47383..f6610d9e8bd45b319fefaf8dbbe23b3f2c6615e3 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.messages;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import com.google.common.collect.ImmutableMap;
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.util.ByteBufUtils;
@@ -23,7 +24,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.P
  * OF protocol versions: 1.3.
  */
 public class PortMessageSerializer extends AbstractMessageSerializer<PortMessage> {
-
     private static final byte PADDING_IN_PORT_MOD_MESSAGE_01 = 4;
     private static final byte PADDING_IN_PORT_MOD_MESSAGE_02 = 2;
     private static final byte PADDING_IN_PORT_MOD_MESSAGE_03 = 4;
@@ -40,8 +40,7 @@ public class PortMessageSerializer extends AbstractMessageSerializer<PortMessage
         outBuffer.writeBytes(IetfYangUtil.INSTANCE.macAddressBytes(message.getHardwareAddress()));
         outBuffer.writeZero(PADDING_IN_PORT_MOD_MESSAGE_02);
         outBuffer.writeInt(createPortConfigBitMask(message.getConfiguration()));
-        outBuffer.writeInt(MoreObjects
-                .firstNonNull(createPortConfigBitMask(message.getMask()), DEFAULT_PORT_CONFIG_MASK));
+        outBuffer.writeInt(requireNonNullElse(createPortConfigBitMask(message.getMask()), DEFAULT_PORT_CONFIG_MASK));
         outBuffer.writeInt(createPortFeaturesBitMask(message.getAdvertisedFeatures()));
         outBuffer.writeZero(PADDING_IN_PORT_MOD_MESSAGE_03);
         outBuffer.setShort(index + 2, outBuffer.writerIndex() - index);
index b1ce9b132b7af080eebcda40dd98c0a9577bb46a..0e8b63ce5b924ef12e87686b8994befc48b8f614 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -23,26 +24,26 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026
 
 public class MultipartRequestFlowAggregateStatsSerializer implements OFSerializer<MultipartRequestFlowAggregateStats>,
         SerializerRegistryInjector {
-
     private static final byte PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_01 = 3;
     private static final byte PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_02 = 4;
+
     private SerializerRegistry registry;
 
     @Override
     public void serialize(final MultipartRequestFlowAggregateStats multipartRequestFlowAggregateStats,
             final ByteBuf byteBuf) {
         final FlowAggregateStats stats = multipartRequestFlowAggregateStats.getFlowAggregateStats();
-        byteBuf.writeByte(MoreObjects.firstNonNull(stats.getTableId(), OFConstants.OFPTT_ALL).byteValue());
+        byteBuf.writeByte(requireNonNullElse(stats.getTableId(), OFConstants.OFPTT_ALL).byteValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_01);
-        byteBuf.writeInt(MoreObjects.firstNonNull(stats.getOutPort(), OFConstants.OFPP_ANY).intValue());
-        byteBuf.writeInt(MoreObjects.firstNonNull(stats.getOutGroup(), OFConstants.OFPG_ANY).intValue());
+        byteBuf.writeInt(requireNonNullElse(stats.getOutPort(), OFConstants.OFPP_ANY).intValue());
+        byteBuf.writeInt(requireNonNullElse(stats.getOutGroup(), OFConstants.OFPG_ANY).intValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_02);
-        byteBuf.writeLong(MoreObjects.firstNonNull(stats.getCookie(),
+        byteBuf.writeLong(requireNonNullElse(stats.getCookie(),
                 new FlowCookie(OFConstants.DEFAULT_COOKIE)).getValue().longValue());
-        byteBuf.writeLong(MoreObjects.firstNonNull(stats.getCookieMask(),
+        byteBuf.writeLong(requireNonNullElse(stats.getCookieMask(),
                 new FlowCookie(OFConstants.DEFAULT_COOKIE_MASK)).getValue().longValue());
 
-        Preconditions.checkNotNull(registry).<Match, OFSerializer<Match>>getSerializer(
+        requireNonNull(registry).<Match, OFSerializer<Match>>getSerializer(
                 new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_3, Match.class))
                 .serialize(stats.getMatch(), byteBuf);
     }
index 65e94ffda7ee4378942795973f0120f859cc9efa..ba939626106f54d33e54a2d463b764fef267be11 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -23,25 +24,25 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026
 
 public class MultipartRequestFlowStatsSerializer implements OFSerializer<MultipartRequestFlowStats>,
         SerializerRegistryInjector {
-
     private static final byte PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_01 = 3;
     private static final byte PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_02 = 4;
+
     private SerializerRegistry registry;
 
     @Override
     public void serialize(final MultipartRequestFlowStats multipartRequestFlowStats, final ByteBuf byteBuf) {
         final FlowStats stats = multipartRequestFlowStats.getFlowStats();
-        byteBuf.writeByte(MoreObjects.firstNonNull(stats.getTableId(), OFConstants.OFPTT_ALL).byteValue());
+        byteBuf.writeByte(requireNonNullElse(stats.getTableId(), OFConstants.OFPTT_ALL).byteValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_01);
-        byteBuf.writeInt(MoreObjects.firstNonNull(stats.getOutPort(), OFConstants.OFPP_ANY).intValue());
-        byteBuf.writeInt(MoreObjects.firstNonNull(stats.getOutGroup(), OFConstants.OFPG_ANY).intValue());
+        byteBuf.writeInt(requireNonNullElse(stats.getOutPort(), OFConstants.OFPP_ANY).intValue());
+        byteBuf.writeInt(requireNonNullElse(stats.getOutGroup(), OFConstants.OFPG_ANY).intValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_FLOW_BODY_02);
-        byteBuf.writeLong(MoreObjects.firstNonNull(stats.getCookie(),
+        byteBuf.writeLong(requireNonNullElse(stats.getCookie(),
                 new FlowCookie(OFConstants.DEFAULT_COOKIE)).getValue().longValue());
-        byteBuf.writeLong(MoreObjects.firstNonNull(stats.getCookieMask(),
+        byteBuf.writeLong(requireNonNullElse(stats.getCookieMask(),
                 new FlowCookie(OFConstants.DEFAULT_COOKIE_MASK)).getValue().longValue());
 
-        Preconditions.checkNotNull(registry).<Match, OFSerializer<Match>>getSerializer(
+        requireNonNull(registry).<Match, OFSerializer<Match>>getSerializer(
             new MessageTypeKey<>(EncodeConstants.OF_VERSION_1_3, Match.class))
             .serialize(stats.getMatch(), byteBuf);
     }
index e9d38d220b076cc9301320c712c13f36e1abdfbf..438eb056a9f59649e7e8645ce223fe0210a623f4 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowplugin.api.OFConstants;
@@ -16,16 +16,12 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.group.statistics.rev131111.
 import org.opendaylight.yang.gen.v1.urn.opendaylight.group.types.rev131018.GroupId;
 
 public class MultipartRequestGroupStatsSerializer implements OFSerializer<MultipartRequestGroupStats> {
-
     private static final byte PADDING_IN_MULTIPART_REQUEST_GROUP_BODY = 4;
 
     @Override
     public void serialize(final MultipartRequestGroupStats multipartRequestGroupStats, final ByteBuf byteBuf) {
-        byteBuf.writeInt(MoreObjects
-            .firstNonNull(multipartRequestGroupStats.getGroupId(), new GroupId(OFConstants.OFPG_ALL))
-            .getValue().intValue());
-
+        byteBuf.writeInt(requireNonNullElse(multipartRequestGroupStats.getGroupId(),
+            new GroupId(OFConstants.OFPG_ALL)).getValue().intValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_GROUP_BODY);
     }
-
 }
index fb4649e17046a17ccc0c8217c080124baf8e606a..22926e3700fb0408ed378f0e627753f6b41cace8 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -52,7 +53,7 @@ public class MultipartRequestMessageSerializer extends AbstractMessageSerializer
         outBuffer.writeShort(ByteBufUtils.fillBitMask(0, message.getRequestMore()));
         outBuffer.writeZero(PADDING_IN_MULTIPART_REQUEST_MESSAGE);
 
-        final OFSerializer<MultipartRequestBody> serializer = Preconditions.checkNotNull(registry)
+        final OFSerializer<MultipartRequestBody> serializer = requireNonNull(registry)
             .getSerializer(new MessageTypeKey<>(
                 EncodeConstants.OF_VERSION_1_3,
                 multipartRequestBody.implementedInterface()));
index 428892857654efedd58219b06a597916f405a258..356599be4c518fa49e11b982cd70b36e66116ac6 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowplugin.api.OFConstants;
@@ -16,14 +16,12 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.statistics.rev131111.
 import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.MeterId;
 
 public class MultipartRequestMeterConfigSerializer implements OFSerializer<MultipartRequestMeterConfig> {
-
     private static final byte PADDING_IN_MULTIPART_REQUEST_METER_CONFIG_BODY = 4;
 
     @Override
     public void serialize(final MultipartRequestMeterConfig multipartRequestMeterConfig, final ByteBuf byteBuf) {
-        byteBuf.writeInt(MoreObjects.firstNonNull(multipartRequestMeterConfig.getMeterId(),
-                new MeterId(OFConstants.OFPM_ALL)).getValue().intValue());
+        byteBuf.writeInt(requireNonNullElse(multipartRequestMeterConfig.getMeterId(),
+            new MeterId(OFConstants.OFPM_ALL)).getValue().intValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_METER_CONFIG_BODY);
     }
-
 }
index 40453b39807a388a5d7c3ac8e93a6d7d775925aa..66bfde7592c08e6c3ac13763f35b99ec2f6d96a7 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowplugin.api.OFConstants;
@@ -16,15 +16,12 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.statistics.rev131111.
 import org.opendaylight.yang.gen.v1.urn.opendaylight.meter.types.rev130918.MeterId;
 
 public class MultipartRequestMeterStatsSerializer implements OFSerializer<MultipartRequestMeterStats> {
-
     private static final byte PADDING_IN_MULTIPART_REQUEST_METER_BODY = 4;
 
     @Override
     public void serialize(final MultipartRequestMeterStats multipartRequestMeterStats, final ByteBuf byteBuf) {
-        byteBuf.writeInt(MoreObjects
-            .firstNonNull(multipartRequestMeterStats.getStatMeterId(), new MeterId(OFConstants.OFPM_ALL))
-                .getValue().intValue());
+        byteBuf.writeInt(requireNonNullElse(multipartRequestMeterStats.getStatMeterId(),
+            new MeterId(OFConstants.OFPM_ALL)).getValue().intValue());
         byteBuf.writeZero(PADDING_IN_MULTIPART_REQUEST_METER_BODY);
     }
-
 }
index 24cfada4f0436ef9bda6eb45e26b50083423f006..207743df37745654ae593e4e4552f9494a0c8a6e 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart;
 
-import com.google.common.base.MoreObjects;
+import static java.util.Objects.requireNonNullElse;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowplugin.api.OFConstants;
@@ -17,7 +18,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.queue.rev130925.
 import org.opendaylight.yang.gen.v1.urn.opendaylight.queue.statistics.rev131216.multipart.request.multipart.request.body.MultipartRequestQueueStats;
 
 public class MultipartRequestQueueStatsSerializer implements OFSerializer<MultipartRequestQueueStats> {
-
     @Override
     public void serialize(final MultipartRequestQueueStats multipartRequestQueueStats, final ByteBuf byteBuf) {
         if (multipartRequestQueueStats.getNodeConnectorId() == null) {
@@ -29,8 +29,7 @@ public class MultipartRequestQueueStatsSerializer implements OFSerializer<Multip
                     multipartRequestQueueStats.getNodeConnectorId()).intValue());
         }
 
-        byteBuf.writeInt(MoreObjects
-            .firstNonNull(multipartRequestQueueStats.getQueueId(), new QueueId(OFConstants.OFPQ_ALL))
+        byteBuf.writeInt(requireNonNullElse(multipartRequestQueueStats.getQueueId(), new QueueId(OFConstants.OFPQ_ALL))
                 .getValue().intValue());
     }
 }
index 60a959a6657b6ff82d26b9b98071d4305e35174c..df6bb8e6150cdf0b9c667d9b8c809dc386e44488 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -29,7 +30,7 @@ public class ApplySetfieldMissTablePropertySerializer extends
         property
             .getApplySetfieldMiss()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3, setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index da722f89c0a8459d7684ddff5892731caf1d425b..b29143caedef2d8b0238a136d264f104ab627b05 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -28,7 +29,7 @@ public class ApplySetfieldTablePropertySerializer extends AbstractTablePropertyS
         property
             .getApplySetfield()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3,setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index 251e51cd4e270e8f59903204098064ca486a6849..dbe1da395b5685e9d69ecafec39fc686482b1223 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -29,7 +30,7 @@ public class MatchTablePropertySerializer extends AbstractTablePropertySerialize
         property
             .getMatchSetfield()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3, setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index 3db83831fafe3fcd64afe50ec3e1f91cf6366b82..7cb1b9bb0f3c430babb5c7e927a4b7e219a6dc50 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -29,7 +30,7 @@ public class WildcardsTablePropertySerializer extends AbstractTablePropertySeria
         property
             .getWildcardSetfield()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3, setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index 2196b05ba493ea293845c8bae9e575700cbcc731..cfc376f7a3d8c82312a9ece72fe569dde3e51fb5 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -28,7 +29,7 @@ public class WriteSetfieldMissTablePropertySerializer extends
         property
             .getWriteSetfieldMiss()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3, setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index f266b5cadbca632c68e129480e8538b4762de8aa..0b4db8debd9306b560975fb7c9be02a3a1194026 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.protocol.serialization.multipart.tablefeatures;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import io.netty.buffer.ByteBuf;
 import org.opendaylight.openflowjava.protocol.api.extensibility.OFSerializer;
 import org.opendaylight.openflowjava.protocol.api.extensibility.SerializerRegistry;
@@ -29,7 +30,7 @@ public class WriteSetfieldTablePropertySerializer extends AbstractTablePropertyS
         property
             .getWriteSetfield()
             .nonnullSetFieldMatch().values()
-            .forEach(setFieldMatch -> Preconditions.checkNotNull(registry)
+            .forEach(setFieldMatch -> requireNonNull(registry)
                 .<MatchField, OFSerializer<SetFieldMatch>>getSerializer(new MessageTypeKey<>(
                     EncodeConstants.OF_VERSION_1_3, setFieldMatch.getMatchType().implementedInterface()))
                 .serialize(setFieldMatch, byteBuf));
index e57a146ba08eaa7e4f4384704532a3461dfb19a9..1fccf8dab525f53cb1c5f18fae26cdb51a40c262 100644 (file)
@@ -9,7 +9,7 @@ package org.opendaylight.openflowplugin.impl.registry.flow;
 
 import static java.util.Objects.requireNonNull;
 
-import com.google.common.base.Objects;
+import java.util.Objects;
 import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.openflowplugin.api.openflow.registry.flow.FlowDescriptor;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowId;
@@ -26,13 +26,11 @@ public final class FlowDescriptorFactory {
         // Hide implicit constructor
     }
 
-    @NonNull
-    public static FlowDescriptor create(final Uint8 tableId, @NonNull final FlowId flowId) {
+    public static @NonNull FlowDescriptor create(final Uint8 tableId, @NonNull final FlowId flowId) {
         return new FlowDescriptorDto(new TableKey(tableId), requireNonNull(flowId));
     }
 
     private static final class FlowDescriptorDto implements FlowDescriptor {
-
         private final FlowId flowId;
         private final TableKey tableKey;
 
@@ -42,20 +40,14 @@ public final class FlowDescriptorFactory {
         }
 
         @Override
-        public boolean equals(final Object object) {
-            if (this == object) {
-                return true;
-            }
-            if (object == null || getClass() != object.getClass()) {
-                return false;
-            }
-            FlowDescriptorDto that = (FlowDescriptorDto) object;
-            return Objects.equal(flowId, that.flowId) && Objects.equal(tableKey, that.tableKey);
+        public boolean equals(final Object obj) {
+            return this == obj || obj instanceof FlowDescriptorDto other && Objects.equals(flowId, other.flowId)
+                && Objects.equals(tableKey, other.tableKey);
         }
 
         @Override
         public int hashCode() {
-            return Objects.hashCode(flowId, tableKey);
+            return Objects.hash(flowId, tableKey);
         }
 
         @Override
index fdf28ad3980df1852b5832979dbe69b3c68cbb2d..8f8c7d20717b00e329bf35561f8fb6d0e7850932 100644 (file)
@@ -5,11 +5,11 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.registry.flow;
 
-import com.google.common.base.MoreObjects;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+import static java.util.Objects.requireNonNullElse;
+
 import java.util.Objects;
 import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.openflowplugin.api.OFConstants;
@@ -38,12 +38,11 @@ public final class FlowRegistryKeyFactory {
     @NonNull
     public static FlowRegistryKey create(final Uint8 version, @NonNull final Flow flow) {
         //TODO: mandatory flow input values (or default values) should be specified via yang model
-        final Uint8 tableId = Preconditions.checkNotNull(flow.getTableId(), "flow tableId must not be null");
-        final Uint16 priority = MoreObjects.firstNonNull(flow.getPriority(), OFConstants.DEFAULT_FLOW_PRIORITY);
-        final Uint64 cookie =
-                MoreObjects.firstNonNull(flow.getCookie(), OFConstants.DEFAULT_FLOW_COOKIE).getValue();
-        Match match = MatchNormalizationUtil
-                .normalizeMatch(MoreObjects.firstNonNull(flow.getMatch(), OFConstants.EMPTY_MATCH), version);
+        final Uint8 tableId = requireNonNull(flow.getTableId(), "flow tableId must not be null");
+        final Uint16 priority = requireNonNullElse(flow.getPriority(), OFConstants.DEFAULT_FLOW_PRIORITY);
+        final Uint64 cookie = requireNonNullElse(flow.getCookie(), OFConstants.DEFAULT_FLOW_COOKIE).getValue();
+        Match match = MatchNormalizationUtil.normalizeMatch(
+            requireNonNullElse(flow.getMatch(), OFConstants.EMPTY_MATCH), version);
         return new FlowRegistryKeyDto(tableId.toJava(), priority.toJava(), cookie, match);
     }
 
@@ -69,12 +68,10 @@ public final class FlowRegistryKeyFactory {
                 return true;
             }
 
-            if (object == null || !(object instanceof FlowRegistryKey)) {
+            if (object == null || !(object instanceof FlowRegistryKey that)) {
                 return false;
             }
 
-            final FlowRegistryKey that = (FlowRegistryKey) object;
-
             return getPriority() == that.getPriority()
                     && getTableId() == that.getTableId()
                     && getCookie().equals(that.getCookie())
index 4544e933f9bb983a7c0b7cc943d5a265ebb615c2..48678786d0746786a41f25ef13e8f3655deb788c 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
@@ -34,9 +35,9 @@ public abstract class AbstractRequestCallback<T> implements FutureCallback<OfHea
                             final Class<?> requestType,
                             final MessageSpy spy,
                             final EventIdentifier eventIdentifier) {
-        this.context = Preconditions.checkNotNull(context);
-        this.requestType = Preconditions.checkNotNull(requestType);
-        this.spy = Preconditions.checkNotNull(spy);
+        this.context = requireNonNull(context);
+        this.requestType = requireNonNull(requestType);
+        this.spy = requireNonNull(spy);
         this.eventIdentifier = eventIdentifier;
     }
 
@@ -46,7 +47,7 @@ public abstract class AbstractRequestCallback<T> implements FutureCallback<OfHea
     }
 
     protected final void spyMessage(@NonNull final StatisticsGroup group) {
-        spy.spyMessage(requestType, Preconditions.checkNotNull(group));
+        spy.spyMessage(requestType, requireNonNull(group));
     }
 
     public EventIdentifier getEventIdentifier() {
index d916cd35685e042feb322354a4ade970bd050f7d..2324783238505bb98346f3be2bd092e465e5c3f0 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.services;
 
-import com.google.common.base.Preconditions;
-import com.google.common.base.Verify;
+import static com.google.common.base.Verify.verify;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -114,7 +115,7 @@ public abstract class AbstractService<I, O> {
 
     public ListenableFuture<RpcResult<O>> handleServiceCall(@NonNull final I input,
             @Nullable final Function<OfHeader, Boolean> isComplete) {
-        Preconditions.checkNotNull(input);
+        requireNonNull(input);
 
         final Class<?> requestType = input instanceof DataContainer
             ? ((DataContainer) input).implementedInterface()
@@ -147,7 +148,7 @@ public abstract class AbstractService<I, O> {
         OfHeader request = null;
         try {
             request = buildRequest(xid, input);
-            Verify.verify(xid.getValue().equals(request.getXid()),
+            verify(xid.getValue().equals(request.getXid()),
                           "Expected XID %s got %s",
                           xid.getValue(),
                           request.getXid());
index 36174892d36514de4a6973c3b8ff40581327cd54..0cd8b312960d91e4d9822c192e31fc63741d1f74 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import org.opendaylight.openflowplugin.api.openflow.device.DeviceContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
@@ -22,7 +23,7 @@ public abstract class AbstractSimpleService<I, O extends DataObject> extends Abs
                                     final DeviceContext deviceContext,
                                     final Class<O> clazz) {
         super(requestContextStack, deviceContext);
-        this.clazz = Preconditions.checkNotNull(clazz);
+        this.clazz = requireNonNull(clazz);
     }
 
     @Override
index bff7f553cc792d6d4fe051c83bbf7d876bf969b2..604bcf3cb1610f36345fca401f2fb15385d0ac03 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
 import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.MessageSpy;
@@ -19,6 +20,7 @@ import org.slf4j.LoggerFactory;
 
 public final class SimpleRequestCallback<T extends DataObject> extends AbstractRequestCallback<T> {
     private static final Logger LOG = LoggerFactory.getLogger(SimpleRequestCallback.class);
+
     private final Class<T> clazz;
 
     private SimpleRequestCallback(final RequestContext<T> context,
@@ -26,7 +28,7 @@ public final class SimpleRequestCallback<T extends DataObject> extends AbstractR
                                   final MessageSpy spy,
                                   final Class<T> clazz) {
         super(context, requestType, spy, null);
-        this.clazz = Preconditions.checkNotNull(clazz);
+        this.clazz = requireNonNull(clazz);
     }
 
     public static <T extends DataObject> FutureCallback<OfHeader> create(final RequestContext<T> context,
index 0f696787f7b0ce8f077a3a54a1ff2891975a8783..e08c9023b65ae4d91d47708ad20b54e480ab7f14 100644 (file)
@@ -5,12 +5,11 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.services.multilayer;
 
 import static java.util.Objects.requireNonNull;
+import static java.util.Objects.requireNonNullElse;
 
-import com.google.common.base.MoreObjects;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -46,7 +45,6 @@ import org.opendaylight.yangtools.yang.common.Uint32;
 import org.opendaylight.yangtools.yang.common.Uint8;
 
 public class MultiLayerAggregateFlowMultipartService extends AbstractAggregateFlowMultipartService<MultipartReply> {
-
     private final TranslatorLibrary translatorLibrary;
     private final ConvertorExecutor convertorExecutor;
     private final VersionConvertorData data;
@@ -68,9 +66,9 @@ public class MultiLayerAggregateFlowMultipartService extends AbstractAggregateFl
         final MultipartRequestAggregateCaseBuilder multipartRequestAggregateCaseBuilder
                 = new MultipartRequestAggregateCaseBuilder();
         final MultipartRequestAggregateBuilder mprAggregateRequestBuilder = new MultipartRequestAggregateBuilder();
-        final Uint8 tableId = MoreObjects.firstNonNull(input.getTableId(), OFConstants.OFPTT_ALL);
+        final Uint8 tableId = requireNonNullElse(input.getTableId(), OFConstants.OFPTT_ALL);
         mprAggregateRequestBuilder.setTableId(tableId);
-        long outputPortValue = MoreObjects.firstNonNull(input.getOutPort(), OFConstants.OFPP_ANY).longValue();
+        long outputPortValue = requireNonNullElse(input.getOutPort(), OFConstants.OFPP_ANY).longValue();
         mprAggregateRequestBuilder.setOutPort(Uint32.valueOf(outputPortValue));
 
         final Uint8 version = getVersion();
@@ -80,16 +78,16 @@ public class MultiLayerAggregateFlowMultipartService extends AbstractAggregateFl
                 mprAggregateRequestBuilder.setCookie(OFConstants.DEFAULT_COOKIE);
             } else {
                 mprAggregateRequestBuilder
-                        .setCookie(MoreObjects.firstNonNull(input.getCookie().getValue(), OFConstants.DEFAULT_COOKIE));
+                        .setCookie(requireNonNullElse(input.getCookie().getValue(), OFConstants.DEFAULT_COOKIE));
             }
 
             if (input.getCookieMask() == null) {
                 mprAggregateRequestBuilder.setCookieMask(OFConstants.DEFAULT_COOKIE_MASK);
             } else {
                 mprAggregateRequestBuilder.setCookieMask(
-                        MoreObjects.firstNonNull(input.getCookieMask().getValue(), OFConstants.DEFAULT_COOKIE_MASK));
+                    requireNonNullElse(input.getCookieMask().getValue(), OFConstants.DEFAULT_COOKIE_MASK));
             }
-            Uint32 outGroup = MoreObjects.firstNonNull(input.getOutGroup(), OFConstants.OFPG_ANY);
+            Uint32 outGroup = requireNonNullElse(input.getOutGroup(), OFConstants.OFPG_ANY);
             mprAggregateRequestBuilder.setOutGroup(outGroup);
         } else {
             mprAggregateRequestBuilder.setOutGroup(OFConstants.OFPG_ANY);
index 30b60e127c2d359552e65abd451203d9347ba096..25a88e5b0b9c357df4fe60b58e77d0aa9b0371ca 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
@@ -41,11 +42,12 @@ import org.slf4j.LoggerFactory;
  */
 public class SalBundleServiceImpl implements SalBundleService {
     private static final Logger LOG = LoggerFactory.getLogger(SalBundleServiceImpl.class);
+
     private final SalExperimenterMessageService experimenterMessageService;
 
     public SalBundleServiceImpl(final SalExperimenterMessageService experimenterMessageService) {
-        this.experimenterMessageService = Preconditions
-                .checkNotNull(experimenterMessageService, "SalExperimenterMessageService can not be null!");
+        this.experimenterMessageService = requireNonNull(experimenterMessageService,
+            "SalExperimenterMessageService can not be null!");
     }
 
     @Override
index ec86351ef7a6a94ebf3cfb84dfb5571aa617ac5e..a857d4f5bc96e3144930e944c612a0be46a540dc 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -24,7 +25,6 @@ import org.opendaylight.yangtools.yang.common.RpcResult;
 import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 
 public final class SalEchoServiceImpl implements SalEchoService {
-
     private final EchoService echoService;
 
     public SalEchoServiceImpl(final RequestContextStack requestContextStack, final DeviceContext deviceContext) {
@@ -41,7 +41,7 @@ public final class SalEchoServiceImpl implements SalEchoService {
     private static ListenableFuture<RpcResult<SendEchoOutput>>
             transform(final ListenableFuture<RpcResult<EchoOutput>> rpcResultListenableFuture) {
         return Futures.transform(rpcResultListenableFuture, input -> {
-            Preconditions.checkNotNull(input, "echoOutput value is never expected to be NULL");
+            requireNonNull(input, "echoOutput value is never expected to be NULL");
             final RpcResult<SendEchoOutput> rpcOutput;
             if (input.isSuccessful()) {
                 final SendEchoOutput sendEchoOutput = new SendEchoOutputBuilder()
index ac03024aa58576ea55d7666dfa1df8879478357a..3f760e6b722aaaf177b534efd5c989833180017c 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -64,11 +65,9 @@ public class SalFlatBatchServiceImpl implements SalFlatBatchService {
     public SalFlatBatchServiceImpl(final SalFlowsBatchService salFlowBatchService,
                                    final SalGroupsBatchService salGroupsBatchService,
                                    final SalMetersBatchService salMetersBatchService) {
-        this.salFlowService = Preconditions.checkNotNull(salFlowBatchService, "delegate flow service must not be null");
-        this.salGroupService =
-                Preconditions.checkNotNull(salGroupsBatchService, "delegate group service must not be null");
-        this.salMeterService =
-                Preconditions.checkNotNull(salMetersBatchService, "delegate meter service must not be null");
+        salFlowService = requireNonNull(salFlowBatchService, "delegate flow service must not be null");
+        salGroupService = requireNonNull(salGroupsBatchService, "delegate group service must not be null");
+        salMeterService = requireNonNull(salMetersBatchService, "delegate meter service must not be null");
     }
 
     @Override
@@ -136,85 +135,74 @@ public class SalFlatBatchServiceImpl implements SalFlatBatchService {
     private ListenableFuture<RpcResult<ProcessFlatBatchOutput>> getChainOutput(final NodeRef node,
                                                                                final BatchPlanStep planStep,
                                                                                final int currentOffset) {
-        final ListenableFuture<RpcResult<ProcessFlatBatchOutput>> chainOutput;
-
-        switch (planStep.getStepType()) {
-            case FLOW_ADD:
+        return switch (planStep.getStepType()) {
+            case FLOW_ADD -> {
                 final AddFlowsBatchInput addFlowsBatchInput =
-                        FlatBatchFlowAdapters.adaptFlatBatchAddFlow(planStep, node);
+                    FlatBatchFlowAdapters.adaptFlatBatchAddFlow(planStep, node);
                 final ListenableFuture<RpcResult<AddFlowsBatchOutput>> resultAddFlowFuture =
-                        salFlowService.addFlowsBatch(addFlowsBatchInput);
-                chainOutput = FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultAddFlowFuture, currentOffset);
-                break;
-            case FLOW_REMOVE:
+                    salFlowService.addFlowsBatch(addFlowsBatchInput);
+                yield FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultAddFlowFuture, currentOffset);
+            }
+            case FLOW_REMOVE -> {
                 final RemoveFlowsBatchInput removeFlowsBatchInput =
-                        FlatBatchFlowAdapters.adaptFlatBatchRemoveFlow(planStep, node);
+                    FlatBatchFlowAdapters.adaptFlatBatchRemoveFlow(planStep, node);
                 final ListenableFuture<RpcResult<RemoveFlowsBatchOutput>> resultRemoveFlowFuture =
-                        salFlowService.removeFlowsBatch(removeFlowsBatchInput);
-                chainOutput =
-                        FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultRemoveFlowFuture, currentOffset);
-                break;
-            case FLOW_UPDATE:
+                    salFlowService.removeFlowsBatch(removeFlowsBatchInput);
+                yield FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultRemoveFlowFuture, currentOffset);
+            }
+            case FLOW_UPDATE -> {
                 final UpdateFlowsBatchInput updateFlowsBatchInput =
-                        FlatBatchFlowAdapters.adaptFlatBatchUpdateFlow(planStep, node);
+                    FlatBatchFlowAdapters.adaptFlatBatchUpdateFlow(planStep, node);
                 final ListenableFuture<RpcResult<UpdateFlowsBatchOutput>> resultUpdateFlowFuture =
-                        salFlowService.updateFlowsBatch(updateFlowsBatchInput);
-                chainOutput =
-                        FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultUpdateFlowFuture, currentOffset);
-                break;
-            case GROUP_ADD:
+                    salFlowService.updateFlowsBatch(updateFlowsBatchInput);
+                yield FlatBatchFlowAdapters.convertFlowBatchFutureForChain(resultUpdateFlowFuture, currentOffset);
+            }
+            case GROUP_ADD -> {
                 final AddGroupsBatchInput addGroupsBatchInput =
-                        FlatBatchGroupAdapters.adaptFlatBatchAddGroup(planStep, node);
+                    FlatBatchGroupAdapters.adaptFlatBatchAddGroup(planStep, node);
                 final ListenableFuture<RpcResult<AddGroupsBatchOutput>> resultAddGroupFuture =
-                        salGroupService.addGroupsBatch(addGroupsBatchInput);
-                chainOutput =
-                        FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultAddGroupFuture, currentOffset);
-                break;
-            case GROUP_REMOVE:
+                    salGroupService.addGroupsBatch(addGroupsBatchInput);
+                yield FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultAddGroupFuture, currentOffset);
+            }
+            case GROUP_REMOVE -> {
                 final RemoveGroupsBatchInput removeGroupsBatchInput =
-                        FlatBatchGroupAdapters.adaptFlatBatchRemoveGroup(planStep, node);
+                    FlatBatchGroupAdapters.adaptFlatBatchRemoveGroup(planStep, node);
                 final ListenableFuture<RpcResult<RemoveGroupsBatchOutput>> resultRemoveGroupFuture =
-                        salGroupService.removeGroupsBatch(removeGroupsBatchInput);
-                chainOutput =
-                        FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultRemoveGroupFuture, currentOffset);
-                break;
-            case GROUP_UPDATE:
+                    salGroupService.removeGroupsBatch(removeGroupsBatchInput);
+                yield FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultRemoveGroupFuture, currentOffset);
+            }
+            case GROUP_UPDATE -> {
                 final UpdateGroupsBatchInput updateGroupsBatchInput =
-                        FlatBatchGroupAdapters.adaptFlatBatchUpdateGroup(planStep, node);
+                    FlatBatchGroupAdapters.adaptFlatBatchUpdateGroup(planStep, node);
                 final ListenableFuture<RpcResult<UpdateGroupsBatchOutput>> resultUpdateGroupFuture =
-                        salGroupService.updateGroupsBatch(updateGroupsBatchInput);
-                chainOutput =
-                        FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultUpdateGroupFuture, currentOffset);
-                break;
-            case METER_ADD:
+                    salGroupService.updateGroupsBatch(updateGroupsBatchInput);
+                yield FlatBatchGroupAdapters.convertGroupBatchFutureForChain(resultUpdateGroupFuture, currentOffset);
+            }
+            case METER_ADD -> {
                 final AddMetersBatchInput addMetersBatchInput =
-                        FlatBatchMeterAdapters.adaptFlatBatchAddMeter(planStep, node);
+                    FlatBatchMeterAdapters.adaptFlatBatchAddMeter(planStep, node);
                 final ListenableFuture<RpcResult<AddMetersBatchOutput>> resultAddMeterFuture =
-                        salMeterService.addMetersBatch(addMetersBatchInput);
-                chainOutput =
-                        FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultAddMeterFuture, currentOffset);
-                break;
-            case METER_REMOVE:
+                    salMeterService.addMetersBatch(addMetersBatchInput);
+                yield FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultAddMeterFuture, currentOffset);
+            }
+            case METER_REMOVE -> {
                 final RemoveMetersBatchInput removeMetersBatchInput =
-                        FlatBatchMeterAdapters.adaptFlatBatchRemoveMeter(planStep, node);
+                    FlatBatchMeterAdapters.adaptFlatBatchRemoveMeter(planStep, node);
                 final ListenableFuture<RpcResult<RemoveMetersBatchOutput>> resultRemoveMeterFuture =
-                        salMeterService.removeMetersBatch(removeMetersBatchInput);
-                chainOutput =
-                        FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultRemoveMeterFuture, currentOffset);
-                break;
-            case METER_UPDATE:
+                    salMeterService.removeMetersBatch(removeMetersBatchInput);
+                yield FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultRemoveMeterFuture, currentOffset);
+            }
+            case METER_UPDATE -> {
                 final UpdateMetersBatchInput updateMetersBatchInput =
-                        FlatBatchMeterAdapters.adaptFlatBatchUpdateMeter(planStep, node);
+                    FlatBatchMeterAdapters.adaptFlatBatchUpdateMeter(planStep, node);
                 final ListenableFuture<RpcResult<UpdateMetersBatchOutput>> resultUpdateMeterFuture =
-                        salMeterService.updateMetersBatch(updateMetersBatchInput);
-                chainOutput =
-                        FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultUpdateMeterFuture, currentOffset);
-                break;
-            default:
+                    salMeterService.updateMetersBatch(updateMetersBatchInput);
+                yield FlatBatchMeterAdapters.convertMeterBatchFutureForChain(resultUpdateMeterFuture, currentOffset);
+            }
+            default -> {
                 LOG.warn("Unsupported plan-step type occurred: {} -> OMITTING", planStep.getStepType());
-                chainOutput = FlatBatchUtil.createEmptyRpcBatchResultFuture(true);
-        }
-
-        return chainOutput;
+                yield FlatBatchUtil.createEmptyRpcBatchResultFuture(true);
+            }
+        };
     }
 }
index 74c5f3613edf366f8b450bb122ce2132df8794ba..eee91f5b6b547b508dbad3c68b8d63c8fc87829d 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -59,9 +60,8 @@ public class SalFlowsBatchServiceImpl implements SalFlowsBatchService {
 
     public SalFlowsBatchServiceImpl(final SalFlowService salFlowService,
                                     final FlowCapableTransactionService transactionService) {
-        this.salFlowService = Preconditions.checkNotNull(salFlowService, "delegate flow service must not be null");
-        this.transactionService =
-                Preconditions.checkNotNull(transactionService, "delegate transaction service must not be null");
+        this.salFlowService = requireNonNull(salFlowService, "delegate flow service must not be null");
+        this.transactionService = requireNonNull(transactionService, "delegate transaction service must not be null");
     }
 
     @Override
index 108c13940eb612206d3523e43893453b6c2c72d0..6c22005b73f88304ab0b175ede1c671aba7c9c40 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -55,7 +56,6 @@ import org.slf4j.LoggerFactory;
  * Default implementation of {@link SalGroupsBatchService} - delegates work to {@link SalGroupService}.
  */
 public class SalGroupsBatchServiceImpl implements SalGroupsBatchService {
-
     private static final Logger LOG = LoggerFactory.getLogger(SalGroupsBatchServiceImpl.class);
 
     private final SalGroupService salGroupService;
@@ -63,8 +63,8 @@ public class SalGroupsBatchServiceImpl implements SalGroupsBatchService {
 
     public SalGroupsBatchServiceImpl(final SalGroupService salGroupService,
                                      final FlowCapableTransactionService transactionService) {
-        this.salGroupService = Preconditions.checkNotNull(salGroupService);
-        this.transactionService = Preconditions.checkNotNull(transactionService);
+        this.salGroupService = requireNonNull(salGroupService);
+        this.transactionService = requireNonNull(transactionService);
     }
 
     @Override
index fa27cd8f5698400a29d6c040a3f4a237b4cf8551..bfeb225e134d004be93b4f98468118efff4b2626 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -55,7 +56,6 @@ import org.slf4j.LoggerFactory;
  * Default implementation of {@link SalMetersBatchService} - delegates work to {@link SalMeterService}.
  */
 public class SalMetersBatchServiceImpl implements SalMetersBatchService {
-
     private static final Logger LOG = LoggerFactory.getLogger(SalMetersBatchServiceImpl.class);
 
     private final SalMeterService salMeterService;
@@ -63,8 +63,8 @@ public class SalMetersBatchServiceImpl implements SalMetersBatchService {
 
     public SalMetersBatchServiceImpl(final SalMeterService salMeterService,
                                      final FlowCapableTransactionService transactionService) {
-        this.salMeterService = Preconditions.checkNotNull(salMeterService);
-        this.transactionService = Preconditions.checkNotNull(transactionService);
+        this.salMeterService = requireNonNull(salMeterService);
+        this.transactionService = requireNonNull(transactionService);
     }
 
     @Override
index c40079f34be0b0f28d3c00f18c604d2be98f8f00..cb968a8e3e8aa6d6e960d076bff27b1eb57814e8 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.services.sal;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -31,7 +32,6 @@ import org.slf4j.LoggerFactory;
 
 public final class SalRoleServiceImpl extends AbstractSimpleService<SetRoleInput, SetRoleOutput>
                                       implements SalRoleService  {
-
     private static final Logger LOG = LoggerFactory.getLogger(SalRoleServiceImpl.class);
     private static final Uint64 MAX_GENERATION_ID = Uint64.valueOf("ffffffffffffffff", 16);
 
@@ -40,8 +40,8 @@ public final class SalRoleServiceImpl extends AbstractSimpleService<SetRoleInput
 
     public SalRoleServiceImpl(final RequestContextStack requestContextStack, final DeviceContext deviceContext) {
         super(requestContextStack, deviceContext, SetRoleOutput.class);
-        this.deviceContext = Preconditions.checkNotNull(deviceContext);
-        this.roleService =  new RoleService(requestContextStack, deviceContext, RoleRequestOutput.class);
+        this.deviceContext = requireNonNull(deviceContext);
+        roleService =  new RoleService(requestContextStack, deviceContext, RoleRequestOutput.class);
     }
 
     @Override
index 96d572d6b1a89975a52fd9d4f46d02102e20de84..c39aae13ac276b0dbc53b8697fd898e2746ba802 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.services.singlelayer;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -32,7 +32,6 @@ import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
 
 public class SingleLayerAggregateFlowMultipartService
         extends AbstractAggregateFlowMultipartService<MultipartReply> {
-
     public SingleLayerAggregateFlowMultipartService(final RequestContextStack requestContextStack,
                                                     final DeviceContext deviceContext) {
         super(requestContextStack, deviceContext);
@@ -54,7 +53,7 @@ public class SingleLayerAggregateFlowMultipartService
     public ListenableFuture<RpcResult<GetAggregateFlowStatisticsFromFlowTableForGivenMatchOutput>> handleAndReply(
             final GetAggregateFlowStatisticsFromFlowTableForGivenMatchInput input) {
         return Futures.transform(handleServiceCall(input), result -> {
-            if (Preconditions.checkNotNull(result).isSuccessful()) {
+            if (requireNonNull(result).isSuccessful()) {
                 return RpcResultBuilder
                         .success(new GetAggregateFlowStatisticsFromFlowTableForGivenMatchOutputBuilder()
                                 .setAggregatedFlowStatistics(result
index 9e7cd4383ab8cb5376f69037d935d738af5d0615..866882251dd027a2d736b9ad7cd8fc1f18e3439b 100644 (file)
@@ -5,10 +5,10 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.openflowplugin.impl.statistics.ofpspecific;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -26,7 +26,6 @@ import org.slf4j.LoggerFactory;
  * Class counts message of {@link StatisticsGroup} type and provides info as debug log.
  */
 public class MessageIntelligenceAgencyImpl implements MessageIntelligenceAgency, MessageIntelligenceAgencyMXBean {
-
     private static final Logger LOG = LoggerFactory.getLogger(MessageIntelligenceAgencyImpl.class);
 
     private static final class MessageCounters {
@@ -56,7 +55,7 @@ public class MessageIntelligenceAgencyImpl implements MessageIntelligenceAgency,
 
     @Override
     public void spyMessage(final Class<?> message, final StatisticsGroup statGroup) {
-        Preconditions.checkNotNull(message, "Message can't be null.");
+        requireNonNull(message, "Message can't be null.");
         getCounters(message, statGroup).increment();
     }
 
index 560fd7660b323db78a6e3ba7d0101af70d52eb98..af5e68e61340681156a677093b81d7e0a417c488 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.statistics.services.direct;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -81,13 +82,13 @@ abstract class AbstractDirectStatisticsService<I extends StoreStatsGrouping,
     }
 
     private RpcResult<O> transformResult(final RpcResult<List<T>> input) {
-        return Preconditions.checkNotNull(input).isSuccessful()
+        return requireNonNull(input).isSuccessful()
                 ? RpcResultBuilder.success(buildReply(input.getResult(), input.isSuccessful())).build()
                 : RpcResultBuilder.<O>failed().withRpcErrors(input.getErrors()).build();
     }
 
     private RpcResult<O> storeResult(final RpcResult<O> input) {
-        Preconditions.checkNotNull(input);
+        requireNonNull(input);
 
         if (input.isSuccessful()) {
             multipartWriterProvider.lookup(multipartType).ifPresent(writer -> {
index f19523726de6172882c0036e963f22de75a8b467..e9e866b9594c5ff7bda811677c847c1ead0c181e 100644 (file)
@@ -7,7 +7,8 @@
  */
 package org.opendaylight.openflowplugin.impl.util;
 
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
 import java.util.concurrent.atomic.AtomicLong;
 import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.mdsal.binding.api.NotificationPublishService;
@@ -172,7 +173,7 @@ public final class MdSalRegistrationUtils {
 
         AtomicLong compatibilityXidSeed = new AtomicLong();
         // pickup low statistics service
-        final OpendaylightFlowStatisticsService flowStatisticsService = Preconditions.checkNotNull(
+        final OpendaylightFlowStatisticsService flowStatisticsService = requireNonNull(
                 rpcContext.lookupRpcService(OpendaylightFlowStatisticsService.class));
 
         // attach delegate to flow statistics service (to cover all but aggregated stats with match filter input)
index 457df450082d14b8ee8b8c3b7c9a2d0c42c81caf..b570cca845ed9388d67b2a55d5481f637e3a4177 100644 (file)
@@ -7,8 +7,9 @@
  */
 package org.opendaylight.openflowplugin.impl.util;
 
+import static java.util.Objects.requireNonNull;
+
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
 import java.util.List;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
@@ -44,7 +45,7 @@ public final class NodeConnectorRefToPortTranslator {
      */
     @Nullable
     public static NodeConnectorRef toNodeConnectorRef(@NonNull final PacketIn packetIn, final Uint64 dataPathId) {
-        Preconditions.checkNotNull(packetIn);
+        requireNonNull(packetIn);
 
         NodeConnectorRef ref = null;
         Uint32 port = getPortNoFromPacketIn(packetIn);
@@ -67,7 +68,7 @@ public final class NodeConnectorRefToPortTranslator {
     @SuppressWarnings("unchecked")
     @Nullable
     public static Uint32 fromNodeConnectorRef(@NonNull final NodeConnectorRef nodeConnectorRef, final Uint8 version) {
-        Preconditions.checkNotNull(nodeConnectorRef);
+        requireNonNull(nodeConnectorRef);
 
         Uint32 port = null;
 
@@ -88,7 +89,7 @@ public final class NodeConnectorRefToPortTranslator {
     @VisibleForTesting
     @Nullable
     static Uint32 getPortNoFromPacketIn(@NonNull final PacketIn packetIn) {
-        Preconditions.checkNotNull(packetIn);
+        requireNonNull(packetIn);
 
         Uint32 port = null;
 
index 138e340847bb4c259081448fa0215722da51cb77..94b0a3765ea9b02bcab54df3fece849784c3773f 100644 (file)
@@ -15,7 +15,6 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 import com.google.common.collect.ImmutableMap;
-import java.util.Hashtable;
 import java.util.Map;
 import org.junit.Before;
 import org.junit.Test;
@@ -92,12 +91,10 @@ public class ConfigurationServiceFactoryImplTest {
         when(config.getDeviceConnectionHoldTimeInSeconds()).thenReturn(DEVICE_CONNECTION_HOLD_TIME_IN_SECONDS);
         when(config.getDeviceDatastoreRemovalDelay()).thenReturn(new NonZeroUint32Type(DEVICE_DATASTORE_REMOVAL_DELAY));
 
-        final Map<String, String> properties = new Hashtable<>();
-        properties.put(ConfigurationProperty.IS_STATISTICS_POLLING_ON.toString(),
-                Boolean.toString(IS_STATISTICS_POLLING_ON));
-
         configurationService = new ConfigurationServiceFactoryImpl().newInstance(config);
-        configurationService.update(properties);
+        configurationService.update(Map.of(
+            ConfigurationProperty.IS_STATISTICS_POLLING_ON.toString(),
+            Boolean.toString(IS_STATISTICS_POLLING_ON)));
     }
 
     @Test