Use NodeIdentifier.create()

Using create() results in reused instances, thus lowering memory
footprint.

Change-Id: If1a1a3c3c74567374093a76df6e00ed7110b4f1c
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/LazySerializedContainerNode.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/LazySerializedContainerNode.java
index d684cf11ffdcc56e242c704df13221bae9461ea1..5f62660c26ecae8427d1743aae43b1a4a5ce7252 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/LazySerializedContainerNode.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/LazySerializedContainerNode.java
@@ -24,7 +24,7 @@ import org.opendaylight.yangtools.yang.model.api.SchemaPath;
 
 /**
  *
- * FIXME: Should be this moved to binding-data-codec?
+ * FIXME: Should this be moved to binding-data-codec?
  *
  */
 class LazySerializedContainerNode implements ContainerNode {
@@ -37,7 +37,7 @@ class LazySerializedContainerNode implements ContainerNode {
 
     private LazySerializedContainerNode(final QName identifier, final DataObject binding,
             final BindingNormalizedNodeCodecRegistry registry) {
-        this.identifier = new NodeIdentifier(identifier);
+        this.identifier = NodeIdentifier.create(identifier);
         this.bindingData = binding;
         this.registry = registry;
         this.domData = null;

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/ChoiceNodeCodecContext.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/ChoiceNodeCodecContext.java
index e15a36c7ea85ff889540a8bc845c234fef551253..1106c598dc8481c88e53dd7739a5e63a52001cbc 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/ChoiceNodeCodecContext.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/ChoiceNodeCodecContext.java
@@ -70,7 +70,7 @@ final class ChoiceNodeCodecContext<D extends DataObject> extends DataContainerCo
                             continue;
                         }
                     }
-                    byYangCaseChildBuilder.put(new NodeIdentifier(cazeChild.getQName()), cazeDef);
+                    byYangCaseChildBuilder.put(NodeIdentifier.create(cazeChild.getQName()), cazeDef);
                 }
             } else {
                 /*

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/DataContainerCodecPrototype.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/DataContainerCodecPrototype.java
index 839876317b3c111aa834fe982edb1e2eef8de3cf..4560bd6274822ce1a3d6c1db3819c7a2eff40940 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/DataContainerCodecPrototype.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/DataContainerCodecPrototype.java
@@ -57,13 +57,12 @@ final class DataContainerCodecPrototype<T> implements NodeContextSupplier {
     @SuppressWarnings({ "unchecked", "rawtypes" })
     static <T extends DataSchemaNode> DataContainerCodecPrototype<T> from(final Class<?> cls, final T schema,
             final CodecContextFactory factory) {
-        final NodeIdentifier arg = new NodeIdentifier(schema.getQName());
-        return new DataContainerCodecPrototype(cls, arg, schema, factory);
+        return new DataContainerCodecPrototype(cls, NodeIdentifier.create(schema.getQName()), schema, factory);
     }
 
     static DataContainerCodecPrototype<SchemaContext> rootPrototype(final CodecContextFactory factory) {
         final SchemaContext schema = factory.getRuntimeContext().getSchemaContext();
-        final NodeIdentifier arg = new NodeIdentifier(schema.getQName());
+        final NodeIdentifier arg = NodeIdentifier.create(schema.getQName());
         return new DataContainerCodecPrototype<SchemaContext>(DataRoot.class, arg, schema, factory);
     }
 
@@ -75,7 +74,7 @@ final class DataContainerCodecPrototype<T> implements NodeContextSupplier {
     }
 
     static DataContainerCodecPrototype<NotificationDefinition> from(final Class<?> augClass, final NotificationDefinition schema, final CodecContextFactory factory) {
-        final PathArgument arg = new NodeIdentifier(schema.getQName());
+        final PathArgument arg = NodeIdentifier.create(schema.getQName());
         return new DataContainerCodecPrototype<NotificationDefinition>(augClass,arg, schema, factory);
     }