Add a FIXME 51/116251/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 27 Mar 2025 08:09:50 +0000 (09:09 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 14 Apr 2025 12:13:23 +0000 (14:13 +0200)
Simple EOS implementation could be improved, add a FIXME detailing that.

Change-Id: Ia356b287a86c5c28199154cdebe5e2a8e5d14dc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
entityownership/mdsal-eos-dom-simple/src/main/java/org/opendaylight/mdsal/eos/dom/simple/SimpleDOMEntityOwnershipService.java

index 09c63e07e9ac5b1599f0d83a5fc079a73c9a4c12..a6204431307b16a3517b370ed3b79a27080e4fca 100644 (file)
@@ -37,6 +37,12 @@ import org.osgi.service.component.annotations.Component;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+// FIXME: split this out to OSGiEntityOwnershipService and @MetaInf LoaderEntityOwnershipService, both of which inherit
+//        from AbstracEntityOwnershipService, which contains the bulk of the implementation.
+//        Then Use a virtual thread to invoke the callback-on-registration in all of that.
+//        Then rename the remainder to 'ImmediateEntityOwnershipService' with immediate invocation.
+//        Then consider moving ImmediateEntityOwnershipService et al. 'dom.api'.
+//        Then consider hiding LoaderEntityOwnershipService.
 @Component
 @MetaInfServices
 public final class SimpleDOMEntityOwnershipService implements DOMEntityOwnershipService {