BUG 9014: Remove unnecessary Log statements for evpn/subnetroute

1.Modified error logs to debug logs in necessary places
from evpn rt2 code, especially which hits for non-evpn scenarios.

2. This cannot find portOp Error was earlier relevant
where race conditions existed between interface-state
event southbound and subnet-port openstack configuraiton from
northbound.   Later we divided handling the subnetroute
creation into two batches to address the race condition
properly in [1].

As a result with [1] being merged, the error statement for
portOp is not required anymore and so this fix removes that
error statement.

[1] https://git.opendaylight.org/gerrit/#/c/61823/

Change-Id: Ic61f7ec5e3b9733f3e2f9a6bfc56af15c8af6d73
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

diff --git a/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java b/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java
index 687748a160abff3c8cf74d3a4fc4ca0215e5b8ec..b5468acba1b46caf7c6b2d601ffaf7858a1bed54 100644 (file)
--- a/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java
+++ b/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java
@@ -161,7 +161,7 @@ public class EvpnUtils {
     public String getEvpnRd(ElanInstance elanInfo) {
         String evpnName = getEvpnNameFromElan(elanInfo);
         if (evpnName == null) {
-            LOG.error("getEvpnRd : evpnName is NULL for elanInfo {}", elanInfo);
+            LOG.debug("getEvpnRd : evpnName is NULL for elanInfo {}", elanInfo);
             return null;
         }
         return vpnManager.getVpnRd(broker, evpnName);
@@ -177,12 +177,12 @@ public class EvpnUtils {
     private void advertisePrefix(ElanInstance elanInfo, String rd,
                                  String macAddress, String prefix, String interfaceName, BigInteger dpnId) {
         if (rd == null) {
-            LOG.error("advertisePrefix : rd is NULL for elanInfo {}, macAddress {}", elanInfo, macAddress);
+            LOG.debug("advertisePrefix : rd is NULL for elanInfo {}, macAddress {}", elanInfo, macAddress);
             return;
         }
         String nextHop = getEndpointIpAddressForDPN(dpnId);
         if (nextHop == null) {
-            LOG.error("Failed to get the dpn tep ip for dpn {}", dpnId);
+            LOG.debug("Failed to get the dpn tep ip for dpn {}", dpnId);
             return;
         }
         int vpnLabel = 0;

diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java
index 7a8a491cb58f1d0e4af91a3c8fd1fa4479bc2dc9..9406b4fac48e8696e545843f4238e59960358274 100644 (file)
--- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java
+++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java
@@ -231,7 +231,6 @@ public class SubnetOpDpnManager {
         Optional<PortOpDataEntry> optionalPortOp =
             VpnUtil.read(broker, LogicalDatastoreType.OPERATIONAL, portOpIdentifier);
         if (!optionalPortOp.isPresent()) {
-            LOG.error("getPortOpDataEntry: Cannot get, portOp for port {} is not available in datastore", intfName);
             return null;
         }
         return optionalPortOp.get();