Remove an unneeded branch

Instead of maintaining a boolean in an else branch,
examine the resulting collection to see if there is
anything left. Simplifies and speeds up the code.

Change-Id: Ie87c5f845b866e6637a6af0e43cb2153d8e05363
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java
index 154b325dd5539a469de3ff5d49a405943d31a6f6..3e1cb3f44f38a513ef32ea1b9014400042ccd342 100644 (file)
--- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java
+++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java
@@ -68,19 +68,16 @@ class ModifierImpl implements ModelActionBuilder {
     }
 
     private boolean removeSatisfied() {
-        Iterator<AbstractPrerequisite<?>> it = unsatisfied.iterator();
-        boolean allSatisfied = true;
+        final Iterator<AbstractPrerequisite<?>> it = unsatisfied.iterator();
         while (it.hasNext()) {
             final AbstractPrerequisite<?> prereq = it.next();
             if (prereq.isDone()) {
                 // We are removing current prerequisite from list.
                 LOG.trace("Modifier {} prerequisite {} satisfied", this, prereq);
                 it.remove();
-            } else {
-                allSatisfied  = false;
             }
         }
-        return allSatisfied;
+        return unsatisfied.isEmpty();
     }
 
     ModelProcessingPhase getPhase() {