Improve InstanceIdentifierCodecImpl performance

Instead of key iterator and lookup, use entrySet(), just as suggested by
Sonar.

Change-Id: Idada8d9a01a92b4398589df593f96b39748394a9
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/helpers/InstanceIdentifierCodecImpl.java b/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/helpers/InstanceIdentifierCodecImpl.java
index 5904859f13633d8f1454781a3caf28db5534acef..455bdf4edb048bc5f95dbbac2187cfc2c069c792 100644 (file)
--- a/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/helpers/InstanceIdentifierCodecImpl.java
+++ b/yang/yang-data-codec-gson/src/main/java/org/opendaylight/yangtools/yang/data/codec/gson/helpers/InstanceIdentifierCodecImpl.java
@@ -133,10 +133,9 @@ class InstanceIdentifierCodecImpl extends AbstractCodecImpl implements InstanceI
     }
 
     private static List<Predicate> keyValuesToPredicateList(final Map<QName, Object> keyValues) {
-        List<Predicate> result = new ArrayList<>();
-        for (QName qName : keyValues.keySet()) {
-            Object value = keyValues.get(qName);
-            result.add(new Predicate(qNameToIdentityValue(qName), String.valueOf(value)));
+        List<Predicate> result = new ArrayList<>(keyValues.size());
+        for (Map.Entry<QName, Object> e : keyValues.entrySet()) {
+            result.add(new Predicate(qNameToIdentityValue(e.getKey()), String.valueOf(e.getValue())));
         }
         return result;
     }
@@ -148,4 +147,4 @@ class InstanceIdentifierCodecImpl extends AbstractCodecImpl implements InstanceI
         }
         return null;
     }
-}
\ No newline at end of file
+}