BUG: jira NETCONF-493 ReconnectPromise throws IllegalStateException continuously

ReconnectPromise will execute method setFailure() more than once
if reconnecting to a netconf device failed more than once, and the
setFailure() method will start throwing IllegalStateException at
the second time invocation, so there should add limitation to the
call of setFailure() to avoid IllegalStateException.

Change-Id: I2d6802e6ac643215192527319d565da36a16caf5
Signed-off-by: Li guosheng <li.guosheng6@zte.com.cn>

diff --git a/protocol-framework/src/main/java/org/opendaylight/protocol/framework/ReconnectPromise.java b/protocol-framework/src/main/java/org/opendaylight/protocol/framework/ReconnectPromise.java
index f9fadb04b0e0c19b8d89444883c71ac0d58a1a5e..f449b51d0deff211b5469e56f4504ea4788e0bbc 100644 (file)
--- a/protocol-framework/src/main/java/org/opendaylight/protocol/framework/ReconnectPromise.java
+++ b/protocol-framework/src/main/java/org/opendaylight/protocol/framework/ReconnectPromise.java
@@ -54,7 +54,7 @@ final class ReconnectPromise<S extends ProtocolSession<?>, L extends SessionList
         });
 
         pending.addListener((GenericFutureListener<Future<Object>>) future -> {
-            if (!future.isSuccess()) {
+            if (!future.isSuccess() && !ReconnectPromise.this.isDone()) {
                 ReconnectPromise.this.setFailure(future.cause());
             }
         });