Bug 2661 - method name should start with lower case letter

Method names started with underscore

Change-Id: I650bc9b11b280a62bad270c30c681ce3c59483e9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

diff --git a/drop-test/src/main/java/org/opendaylight/openflowplugin/droptest/DropTestCommandProvider.java b/drop-test/src/main/java/org/opendaylight/openflowplugin/droptest/DropTestCommandProvider.java
index 1a5f81aec442a8b2262c286ffd0eaf4c76e488f2..3fe38ddaa5115c55f9300b3b2c2741ce17a5a79a 100644 (file)
--- a/drop-test/src/main/java/org/opendaylight/openflowplugin/droptest/DropTestCommandProvider.java
+++ b/drop-test/src/main/java/org/opendaylight/openflowplugin/droptest/DropTestCommandProvider.java
@@ -8,6 +8,7 @@
 
 package org.opendaylight.openflowplugin.droptest;
 
+import com.google.common.base.Preconditions;
 import org.eclipse.osgi.framework.console.CommandInterpreter;
 import org.eclipse.osgi.framework.console.CommandProvider;
 import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderContext;
@@ -15,8 +16,13 @@ import org.opendaylight.openflowplugin.testcommon.DropTestDsProvider;
 import org.opendaylight.openflowplugin.testcommon.DropTestRpcProvider;
 import org.osgi.framework.BundleContext;
 
-import com.google.common.base.Preconditions;
-
+/**
+ *
+ * use the same methods defined via karaf commands (defined in drop-test-karaf artifact)
+ * Can be deleted after patch https://git.opendaylight.org/gerrit/#/c/15660/ for bug 2750 will be merged.
+ *
+ */
+@Deprecated
 public class DropTestCommandProvider implements CommandProvider {
 
     private final BundleContext ctx;
@@ -37,7 +43,7 @@ public class DropTestCommandProvider implements CommandProvider {
         this.sessionInitiated = true;
     }
 
-    public void _dropAllPackets(final CommandInterpreter ci) {
+    public void dropAllPackets(final CommandInterpreter ci) {
         if (sessionInitiated) {
             String onoff = ci.nextArgument();
             if (onoff.equalsIgnoreCase("on")) {
@@ -60,7 +66,7 @@ public class DropTestCommandProvider implements CommandProvider {
         }
     }
 
-    public void _dropAllPacketsRpc(final CommandInterpreter ci) {
+    public void dropAllPacketsRpc(final CommandInterpreter ci) {
         if (sessionInitiated) {
             String onoff = ci.nextArgument();
             if (onoff.equalsIgnoreCase("on")) {
@@ -83,7 +89,7 @@ public class DropTestCommandProvider implements CommandProvider {
         }
     }
 
-    public void _showDropStats(final CommandInterpreter ci) {
+    public void showDropStats(final CommandInterpreter ci) {
         if (sessionInitiated) {
             ci.println("RPC Test Statistics: " + this.rpcProvider.getStats().toString());
             ci.println("FRM Test Statistics: " + this.provider.getStats().toString());
@@ -92,7 +98,7 @@ public class DropTestCommandProvider implements CommandProvider {
         }
     }
 
-    public void _clearDropStats(final CommandInterpreter ci) {
+    public void clearDropStats(final CommandInterpreter ci) {
         if (sessionInitiated) {
             ci.print("Clearing drop statistics... ");
             this.rpcProvider.clearStats();

diff --git a/drop-test/src/main/java/org/opendaylight/openflowplugin/outputtest/OutputTestCommandProvider.java b/drop-test/src/main/java/org/opendaylight/openflowplugin/outputtest/OutputTestCommandProvider.java
index cd7d638c16af83095a07d36e1127c441b769ba05..5070b69dbf60034e47677e772539849a6bbc3586 100644 (file)
--- a/drop-test/src/main/java/org/opendaylight/openflowplugin/outputtest/OutputTestCommandProvider.java
+++ b/drop-test/src/main/java/org/opendaylight/openflowplugin/outputtest/OutputTestCommandProvider.java
@@ -50,7 +50,7 @@ public class OutputTestCommandProvider implements CommandProvider {
         this.sessionInitiated = true;
     }
 
-    public void _sendOutputMsg(final CommandInterpreter ci) {
+    public void sendOutputMsg(final CommandInterpreter ci) {
         /* Sending package OUT */
         LOG.debug("SendOutMsg");
         if (sessionInitiated) {
@@ -70,7 +70,7 @@ public class OutputTestCommandProvider implements CommandProvider {
         }
     }
 
-    public void _sendPacketOutputMsg(final CommandInterpreter ci) {
+    public void sendPacketOutputMsg(final CommandInterpreter ci) {
         /* Sending package OUT with action */
         LOG.debug("SendOutMsgWithAction");
         if (sessionInitiated) {
@@ -147,7 +147,7 @@ public class OutputTestCommandProvider implements CommandProvider {
         }
     }
 
-    public void _sendOutTopologyMsg(final CommandInterpreter ci) {
+    public void sendOutTopologyMsg(final CommandInterpreter ci) {
         /* Sending package OUT */
         LOG.debug("SendOutTopologyMsg");