Switch to java.util.Base64 86/80286/1
authorStephen Kitt <skitt@redhat.com>
Tue, 12 Feb 2019 14:23:30 +0000 (15:23 +0100)
committerStephen Kitt <skitt@redhat.com>
Tue, 12 Feb 2019 14:23:30 +0000 (15:23 +0100)
Change-Id: Ib944fdd09543d423478267d0ea8a386ae3efe02d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/yang/types/AbstractTypeProvider.java
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/UnionTemplate.xtend

index 4441081f771c231059f4e14c29f91f0719ad7af1..bf18b8ceb9e91a869fe753090d215d851fe3f4c0 100644 (file)
@@ -17,10 +17,10 @@ import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Sets;
-import com.google.common.io.BaseEncoding;
 import java.math.BigDecimal;
 import java.math.BigInteger;
 import java.util.ArrayList;
+import java.util.Base64;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
@@ -1455,8 +1455,7 @@ public abstract class AbstractTypeProvider implements TypeProvider {
 
     private static String binaryToDef(final String defaultValue) {
         final StringBuilder sb = new StringBuilder();
-        final BaseEncoding en = BaseEncoding.base64();
-        final byte[] encoded = en.decode(defaultValue);
+        final byte[] encoded = Base64.getDecoder().decode(defaultValue);
         sb.append("new byte[] {");
         for (int i = 0; i < encoded.length; i++) {
             sb.append(encoded[i]);
index f48ba581ca066b06d84d46beee1e3387bb05c1fd..8fd35a3c9e3a9be14b975890f0268659ca95d5ca 100644 (file)
@@ -12,9 +12,9 @@ import static extension org.apache.commons.text.StringEscapeUtils.escapeJava
 
 import com.google.common.collect.ImmutableList
 import com.google.common.collect.Lists
-import com.google.common.io.BaseEncoding
 import java.beans.ConstructorProperties
 import java.util.ArrayList
+import java.util.Base64;
 import java.util.Collections
 import java.util.List
 import java.util.Map
@@ -330,8 +330,7 @@ class ClassTemplate extends BaseTemplate {
             «IF !("org.opendaylight.yangtools.yang.binding.InstanceIdentifier".equals(prop.returnType.fullyQualifiedName))»
             public static «genTO.name» getDefaultInstance(String defaultValue) {
                 «IF "byte[]".equals(prop.returnType.name)»
-                    «BaseEncoding.importedName» baseEncoding = «BaseEncoding.importedName».base64();
-                    return new «genTO.name»(baseEncoding.decode(defaultValue));
+                    return new «genTO.name»(«Base64.importedName».getDecoder().decode(defaultValue));
                 «ELSEIF "java.lang.String".equals(prop.returnType.fullyQualifiedName)»
                     return new «genTO.name»(defaultValue);
                 «ELSEIF allProperties.size > 1»
index 84e9d78f665b750f94a0cb63371878b1cff1b442..37774ea1f1f0faeaf8c8203617e06c401c14b033 100644 (file)
@@ -10,8 +10,8 @@ package org.opendaylight.mdsal.binding.java.api.generator
 import static org.opendaylight.mdsal.binding.model.util.Types.BOOLEAN;
 import static org.opendaylight.mdsal.binding.model.util.Types.getOuterClassName;
 
-import com.google.common.io.BaseEncoding
 import java.util.Arrays
+import java.util.Base64;
 import org.opendaylight.mdsal.binding.model.api.GeneratedTransferObject
 import org.opendaylight.mdsal.binding.model.api.Enumeration
 import org.opendaylight.yangtools.yang.model.api.type.BitsTypeDefinition
@@ -136,7 +136,7 @@ class UnionTemplate extends ClassTemplate {
                         && (propRet as GeneratedTransferObject).properties.get(0).name.equals("value")
                         && "byte[]".equals((propRet as GeneratedTransferObject).properties.get(0).returnType.name)»
                     ««« generated byte[] typedef
-                return «BaseEncoding.importedName».base64().encode(«field».getValue());
+                return «Base64.importedName».getEncoder().encodeToString(«field».getValue());
                 «ELSEIF propRet instanceof GeneratedTransferObject // Is it a GeneratedTransferObject
                         && (propRet as GeneratedTransferObject).typedef  // Is it a typedef
                         && (propRet as GeneratedTransferObject).baseType instanceof BitsTypeDefinition»