Changed messages based on list feedback

Changed and clarified some messages from error to warning or info.
  The conditions were not errors.

Changed REST abstract class exception handling to differentiate
 between REST Server not responding and invocation exception.

Change-Id: I7349f1d0c4fa3ceabfe1d7c1c006d12b269e40ab
Signed-off-by: Reinaldo Penno <[email protected]>

diff --git a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/SfcProviderAbstractRestAPI.java b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/SfcProviderAbstractRestAPI.java
index 4d02968daf6a860012798f751fea359be0ca4cd7..ad98f2a65538d8f99bb9839eaf6e58c9810c3369 100755 (executable)
--- a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/SfcProviderAbstractRestAPI.java
+++ b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/SfcProviderAbstractRestAPI.java
@@ -86,7 +86,7 @@ abstract public class SfcProviderAbstractRestAPI implements Runnable {
                 LOG.error("Could not find method {} in class", methodName);
                 return;
             } catch (InvocationTargetException e) {
-                LOG.error("Invocation target exception: {}", e.getMessage());
+                LOG.error("Invocation target exception: {}", e.getTargetException().getMessage());
                 return;
             } catch (UniformInterfaceException e) {
                 LOG.error("REST Server error. Message: {}",
@@ -98,5 +98,4 @@ abstract public class SfcProviderAbstractRestAPI implements Runnable {
             }
         }
     }
-
 }

diff --git a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServicePathAPI.java b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServicePathAPI.java
index 852e0b6f7f249d943ac6b25ec302fcc2de8d0504..446c063206f5eea1c179646188bc46714ac83eb1 100755 (executable)
--- a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServicePathAPI.java
+++ b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServicePathAPI.java
@@ -624,7 +624,7 @@ public class SfcProviderServicePathAPI extends SfcProviderAbstractAPI {
                 LOG.error("Could not remove all paths containing function: {} ", serviceFunction.getName());
             }
         } else {
-            LOG.warn("Failed to get reference to Service Function State {} ", serviceFunction.getName());
+            LOG.info("Could not find Service function Paths using Service Function: {} ", serviceFunction.getName());
         }
         printTraceStop(LOG);
     }

diff --git a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServiceTypeAPI.java b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServiceTypeAPI.java
index a8f591c825d03f191ff430538d55a862313c730c..870c3f135c3f503d16a6ee3458b7c221b9b858e8 100755 (executable)
--- a/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServiceTypeAPI.java
+++ b/sfc-provider/src/main/java/org/opendaylight/sfc/provider/api/SfcProviderServiceTypeAPI.java
@@ -313,7 +313,7 @@ public class SfcProviderServiceTypeAPI extends SfcProviderAbstractAPI {
         CheckedFuture<Void,TransactionCommitFailedException> submitFuture = writeTx.submit();
         Futures.addCallback(submitFuture, sfcDataStoreCallback);
         if (!sfcDataStoreCallback.getTransactioSuccessful()) {
-            LOG.error("Failed to create Service Function Type entry for SF: {}",
+            LOG.warn("Failed to create Service Function Type entry for SF: {}",
                     serviceFunction.getName());
 
         }