Fixup DataObjectCodecContext.createBindingProxy() nullness

This method cannot return a null, nor can anything which ultimately
uses it as its sole return.

Change-Id: Ia7bc32fa050777130a635d3929fbce6da705bb22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectCodecContext.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectCodecContext.java
index 22a2f33bf2d11f797c6bf2e6a15b2a60b0c55e5f..82e1ce591382cd480a251d1939e10266c02894b2 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectCodecContext.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectCodecContext.java
@@ -506,7 +506,7 @@ public abstract class DataObjectCodecContext<D extends DataObject, T extends Dat
     }
 
     @SuppressWarnings("checkstyle:illegalCatch")
-    protected final D createBindingProxy(final NormalizedNodeContainer<?, ?, ?> node) {
+    protected final @NonNull D createBindingProxy(final NormalizedNodeContainer<?, ?, ?> node) {
         try {
             return (D) proxyConstructor.invokeExact(this, node);
         } catch (final Throwable e) {

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/ListNodeCodecContext.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/ListNodeCodecContext.java
index 83e38fdc20f692864a2717d0251f534961febcab..1e98817947ab75aca2b1c53db8dd96240c7ec606 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/ListNodeCodecContext.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/ListNodeCodecContext.java
@@ -12,6 +12,7 @@ import com.google.common.collect.ImmutableList.Builder;
 import java.lang.reflect.Method;
 import java.util.Collection;
 import java.util.List;
+import org.eclipse.jdt.annotation.NonNull;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.data.api.schema.MapEntryNode;
 import org.opendaylight.yangtools.yang.data.api.schema.MapNode;
@@ -71,11 +72,11 @@ class ListNodeCodecContext<D extends DataObject> extends DataObjectCodecContext<
         return builder.build();
     }
 
-    final D fromMapEntry(final MapEntryNode node) {
+    final @NonNull D fromMapEntry(final MapEntryNode node) {
         return createBindingProxy(node);
     }
 
-    private D fromUnkeyedListEntry(final UnkeyedListEntryNode node) {
+    private @NonNull D fromUnkeyedListEntry(final UnkeyedListEntryNode node) {
         return createBindingProxy(node);
     }