Fix unknown objects not being reported

Change-Id: I85cb176b8b0d8ce0277f7691ed005f29cd76f14c
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/pojo/SimpleObjectHandlerRegistry.java b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/pojo/SimpleObjectHandlerRegistry.java
index 2a3e704ac72f8fc25ddd14b5c30afacae1f8ab51..cb812803a6271b4be462cb4e3cabb5e879239cf1 100644 (file)
--- a/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/pojo/SimpleObjectHandlerRegistry.java
+++ b/pcep/spi/src/main/java/org/opendaylight/protocol/pcep/spi/pojo/SimpleObjectHandlerRegistry.java
@@ -11,6 +11,7 @@ import org.opendaylight.protocol.concepts.HandlerRegistry;
 import org.opendaylight.protocol.pcep.spi.ObjectHandlerRegistry;
 import org.opendaylight.protocol.pcep.spi.ObjectParser;
 import org.opendaylight.protocol.pcep.spi.ObjectSerializer;
+import org.opendaylight.protocol.pcep.spi.PCEPErrors;
 import org.opendaylight.protocol.pcep.spi.UnknownObject;
 import org.opendaylight.protocol.util.Util;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev131005.Object;
@@ -51,23 +52,19 @@ public final class SimpleObjectHandlerRegistry implements ObjectHandlerRegistry
                boolean foundClass = false;
 
                // FIXME: search the parsers, check classes
-               //e.getError() == PCEPErrors.UNRECOGNIZED_OBJ_CLASS || e.getError() == PCEPErrors.UNRECOGNIZED_OBJ_TYPE
 
                if (!foundClass) {
                        return new ObjectParser() {
                                @Override
                                public Object parseObject(final ObjectHeader header, final byte[] buffer) {
-                                       // FIXME: appropriate error (unrecognized object class)
-                                       return new UnknownObject(null);
+                                       return new UnknownObject(PCEPErrors.UNRECOGNIZED_OBJ_CLASS);
                                }
                        };
-
                } else {
                        return new ObjectParser() {
                                @Override
                                public Object parseObject(final ObjectHeader header, final byte[] buffer) {
-                                       // FIXME: appropriate error (unrecognized object type)
-                                       return new UnknownObject(null);
+                                       return new UnknownObject(PCEPErrors.UNRECOGNIZED_OBJ_TYPE);
                                }
                        };
                }