From: Robert Varga <robert.varga@pantheon.sk>
Date: Thu, 25 Feb 2016 10:43:18 +0000 (+0100)
Subject: BUG-2825: remove unused calculation
X-Git-Tag: release/boron~185
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;ds=sidebyside;h=9a67b0da3bef59901445cdb2bf2f94f4080bed15;p=mdsal.git

BUG-2825: remove unused calculation

Funky way of writing a constant, let's fold it. Make it clearer what we
are doing and also helps the compiler.

Change-Id: I64e6667347568e0e472b053508c545e5b79fff3a
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
---

diff --git a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java
index 6672600dc1..d50a07ef30 100644
--- a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java
+++ b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java
@@ -130,8 +130,8 @@ final class Ipv6Utils {
 
            final int n = j - colonp;
            for (i = 1; i <= n; i++) {
-               dst[INADDR6SZ - i] = dst[colonp + n - i];
-               dst[colonp + n - i] = 0;
+               dst[INADDR6SZ - i] = dst[j - i];
+               dst[j - i] = 0;
            }
        } else {
            Verify.verify(j == INADDR6SZ, "Overrun in parsing of '%s', should not occur", addrStr);