From: Jie Han Date: Mon, 17 Jul 2017 02:22:13 +0000 (+0800) Subject: Binding generator v2 - fix action #2 X-Git-Tag: release/carbon-sr2~26 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;ds=sidebyside;h=bf39a1f519db5391cc69287d7010a9422f6e80b1;p=mdsal.git Binding generator v2 - fix action #2 - delete duplicate resolving data node which has been done in resolveOperationNode Change-Id: I1fda7f35cc84f14dff1213f7c70fd844d9d08607 Signed-off-by: Jie Han (cherry picked from commit de3659e9417072d31f34812a65fdaa79b9eeba83) --- diff --git a/binding2/mdsal-binding2-generator-impl/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/impl/RpcActionGenHelper.java b/binding2/mdsal-binding2-generator-impl/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/impl/RpcActionGenHelper.java index 3a3812b9ca..a9b9f438c0 100644 --- a/binding2/mdsal-binding2-generator-impl/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/impl/RpcActionGenHelper.java +++ b/binding2/mdsal-binding2-generator-impl/src/main/java/org/opendaylight/mdsal/binding/javav2/generator/impl/RpcActionGenHelper.java @@ -210,7 +210,6 @@ final class RpcActionGenHelper { return genCtx; } - //TODO: This method should be reusable for convertion of action that is in grouping. /** * Converts RPC, Action or routed RPC into generated type * @return generated type @@ -282,9 +281,6 @@ final class RpcActionGenHelper { interfaceBuilder.addImplementsType(parameterizedTypeFor(LIST_ACTION, parentType, inType, outType)); } else { //Action - GenHelperUtil.resolveDataSchemaNodes(module, basePackageName, parentType, parentType, - ((ContainerSchemaNode) parent).getChildNodes(), genCtx, schemaContext, verboseClassComments, - genTypeBuilders, typeProvider, namespaceType); operationMethod.addParameter(parameterizedTypeFor(INSTANCE_IDENTIFIER, parentType), "ii"); interfaceBuilder.addImplementsType(parameterizedTypeFor(ACTION, parentType, inType, outType)); }