From: Michael Vorburger <vorburger@redhat.com>
Date: Wed, 29 Jun 2016 22:24:16 +0000 (+0200)
Subject: Checkstyle java.nio.charset.StandardCharsets instead of com.google.common.base.Charsets
X-Git-Tag: release/boron~40
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;ds=sidebyside;h=d53833e7748d51142ed948c8ea64b9f3ba6333a5;hp=55eb72507de0131ae1802f2ac35479dea931d105;p=odlparent.git

Checkstyle java.nio.charset.StandardCharsets instead of com.google.common.base.Charsets

http://blog2.vorburger.ch/2016/06/how-to-use-checkstyle-to-enforce-using.html

Change-Id: Ibdc5520a7700f548e735c569ee8a3c1c9426dcd1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
---

diff --git a/checkstyle/src/main/resources/odl_checks.xml b/checkstyle/src/main/resources/odl_checks.xml
index 701b0aa9b..e1eefa04e 100644
--- a/checkstyle/src/main/resources/odl_checks.xml
+++ b/checkstyle/src/main/resources/odl_checks.xml
@@ -256,5 +256,12 @@
 
           -->
 
+        <!-- Checks for API conventions and the like -->
+        <module name="com.github.sevntu.checkstyle.checks.coding.ForbidCertainImportsCheck">
+            <property name="packageNameRegexp" value=".*" />
+            <property name="forbiddenImportsRegexp" value="com.google.common.base.Charsets" />
+            <property name="forbiddenImportsExcludesRegexp" value="" />
+            <message key="forbid.certain.imports" value="Use ''java.nio.charset.StandardCharsets'' instead of ''{0}''" />
+        </module>
     </module>
 </module>
diff --git a/odlparent/pom.xml b/odlparent/pom.xml
index 0a8601aac..9867fcb16 100644
--- a/odlparent/pom.xml
+++ b/odlparent/pom.xml
@@ -1195,6 +1195,11 @@
               <artifactId>odl-license</artifactId>
               <version>0.1.0-SNAPSHOT</version>
             </dependency>
+            <dependency>
+              <groupId>com.github.sevntu.checkstyle</groupId>
+              <artifactId>sevntu-checkstyle-maven-plugin</artifactId>
+              <version>1.21.0</version>
+            </dependency>
           </dependencies>
           <configuration>
             <configLocation>odl_checks.xml</configLocation>
@@ -1636,4 +1641,5 @@
       <url>${nexus.site.url}/${project.artifactId}/</url>
     </site>
   </distributionManagement>
+
 </project>