From: Igor Foltin <igor.foltin@pantheon.sk>
Date: Mon, 14 Sep 2015 08:25:36 +0000 (+0200)
Subject: Fixed some major sonar issues in  yang-validation-tool
X-Git-Tag: release/beryllium~273
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;ds=sidebyside;h=fd5fa735b663df913f24bd1b50066dbd9e9d0370;p=yangtools.git

Fixed some major sonar issues in  yang-validation-tool

Change-Id: Ifba514ef314df1829f8e1497238cfc3a7705bd0f
Signed-off-by: Igor Foltin <igor.foltin@pantheon.sk>
---

diff --git a/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Main.java b/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Main.java
index b1c94b0cbc..78ee8a535a 100644
--- a/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Main.java
+++ b/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Main.java
@@ -11,8 +11,13 @@ import java.io.File;
 import java.net.URISyntaxException;
 import java.util.Arrays;
 import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public final class Main {
+
+    private static final Logger LOG = LoggerFactory.getLogger(Main.class);
+
     private Main() {
 
     }
@@ -27,7 +32,7 @@ public final class Main {
             try {
                 yangParser.parseFiles(Arrays.asList(yangModels));
             } catch (Exception e) {
-
+                LOG.error("Yang files could not be parsed.", e);
             }
         }
     }
diff --git a/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Params.java b/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Params.java
index 6cd01cd642..205f54c331 100644
--- a/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Params.java
+++ b/yang-validation-tool/src/main/java/org/opendaylight/yangtools/yang/validation/tool/Params.java
@@ -12,9 +12,12 @@ import java.net.URISyntaxException;
 import net.sourceforge.argparse4j.ArgumentParsers;
 import net.sourceforge.argparse4j.annotation.Arg;
 import net.sourceforge.argparse4j.inf.ArgumentParser;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 final class Params {
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(Params.class);
     @Arg(dest = "yang-source-dir")
     private File yangSourceDir;
 
@@ -39,15 +42,15 @@ final class Params {
             return false;
         }
         if (!yangSourceDir.exists()) {
-            System.err.println("Yang source directory has to exist");
+            LOGGER.error("Yang source directory has to exist");
             return false;
         }
         if (!yangSourceDir.canRead()) {
-            System.err.println("Yang source directory has to be readable");
+            LOGGER.error("Yang source directory has to be readable");
             return false;
         }
         if (yangSourceDir.list().length == 0) {
-            System.err.printf("Yang source directory '%s' does't contain any model%n", yangSourceDir.getPath());
+            LOGGER.error("Yang source directory {} doesn't contain any model", yangSourceDir.getPath());
             return false;
         }