From: Sam Hague Date: Wed, 20 Sep 2017 21:44:04 +0000 (-0400) Subject: Lower log levels for non error's X-Git-Tag: release/oxygen~340 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=062f957a7cf83f7a5918b7e842782dacaf865c97;p=netvirt.git Lower log levels for non error's Change-Id: Ia60e0b8bc87182cc2e4ac6611b77b0f421947da9 Signed-off-by: Sam Hague --- diff --git a/vpnservice/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterfaceCacheUtil.java b/vpnservice/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterfaceCacheUtil.java index d9915d95d3..59946c9e8e 100644 --- a/vpnservice/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterfaceCacheUtil.java +++ b/vpnservice/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterfaceCacheUtil.java @@ -24,7 +24,7 @@ public final class AclInterfaceCacheUtil { public static synchronized void removeAclInterfaceFromCache(String interfaceId) { AclInterface aclInterface = cachedMap.get(interfaceId); if (aclInterface == null) { - LOG.warn("AclInterface object not found in cache for interface {}", interfaceId); + LOG.debug("AclInterface object not found in cache for interface {}", interfaceId); return; } if (aclInterface.isMarkedForDelete()) { diff --git a/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java b/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java index 53422860a2..262b2d680a 100755 --- a/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java +++ b/vpnservice/elanmanager/elanmanager-impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java @@ -831,7 +831,7 @@ public class ElanUtils { .getEgressActionsForInterface(getEgressActionInput); RpcResult rpcResult = result.get(); if (!rpcResult.isSuccessful()) { - LOG.warn("RPC Call to Get egress actions for interface {} returned with Errors {}", ifName, + LOG.debug("RPC Call to Get egress actions for interface {} returned with Errors {}", ifName, rpcResult.getErrors()); } else { List actions = rpcResult.getResult().getAction(); diff --git a/vpnservice/fibmanager/fibmanager-impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java b/vpnservice/fibmanager/fibmanager-impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java index 539d2c3c8d..96b0dfcc23 100644 --- a/vpnservice/fibmanager/fibmanager-impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java +++ b/vpnservice/fibmanager/fibmanager-impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java @@ -291,7 +291,7 @@ public class BaseVrfEntryHandler implements AutoCloseable { String ipPrefix = prefixInfo.getIpAddress(); String ifName = prefixInfo.getVpnInterfaceName(); if (ifName == null) { - LOG.warn("Failed to get VPN interface for prefix {}", ipPrefix); + LOG.debug("Failed to get VPN interface for prefix {}", ipPrefix); return; } String macAddress = FibUtil.getMacAddressFromPrefix(dataBroker, ifName, ipPrefix); diff --git a/vpnservice/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java b/vpnservice/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java index 7dcb1d58b4..c761dcd902 100644 --- a/vpnservice/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java +++ b/vpnservice/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java @@ -401,7 +401,7 @@ public class IfMgr { public void updateHostIntf(Uuid portId, Boolean portIncludesV6Address) { VirtualPort intf = vintfs.get(portId); if (intf == null) { - LOG.warn("Update Host interface failed. Could not get Host interface details {}", portId); + LOG.debug("Update Host interface failed. Could not get Host interface details {}", portId); return; } diff --git a/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java b/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java index d2b37185d3..3b2a6d8253 100644 --- a/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java +++ b/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java @@ -62,7 +62,7 @@ public class ExternalNetworkGroupInstaller { } if (NatUtil.isIPv6Subnet(subnetMap.getSubnetIp())) { - LOG.error("installExtNetGroupEntries : Subnet id {} is not an IPv4 subnet, hence skipping.", + LOG.debug("installExtNetGroupEntries : Subnet id {} is not an IPv4 subnet, hence skipping.", subnetMap.getId()); return; } @@ -86,7 +86,7 @@ public class ExternalNetworkGroupInstaller { } if (NatUtil.isIPv6Subnet(subnetMap.getSubnetIp())) { - LOG.warn("installExtNetGroupEntries : Subnet-id {} is not an IPv4 subnet, hence skipping.", + LOG.debug("installExtNetGroupEntries : Subnet-id {} is not an IPv4 subnet, hence skipping.", subnetMap.getId()); return; } @@ -171,7 +171,7 @@ public class ExternalNetworkGroupInstaller { Collection extInterfaces = elanService.getExternalElanInterfaces(networkId.getValue()); if (extInterfaces == null || extInterfaces.isEmpty()) { - LOG.error("removeExtNetGroupEntries : No external ELAN interfaces attached to network {} subnet {}", + LOG.debug("removeExtNetGroupEntries : No external ELAN interfaces attached to network {} subnet {}", networkId, subnetName); return; } @@ -192,8 +192,8 @@ public class ExternalNetworkGroupInstaller { long groupId, String extInterface) { BigInteger dpId = NatUtil.getDpnForInterface(interfaceManager, extInterface); if (BigInteger.ZERO.equals(dpId)) { - LOG.error("buildExtNetGroupEntity: No DPN for interface {}. NAT ext-net flow will not be installed " - + "for subnet {}", extInterface, subnetName); + LOG.info("buildExtNetGroupEntity: No DPN for interface {}. NAT ext-net flow will not be installed " + + "for subnet {}", extInterface, subnetName); return null; } diff --git a/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java b/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java index 7d0d8f941b..525484b103 100644 --- a/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java +++ b/vpnservice/natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java @@ -601,7 +601,7 @@ public class NatUtil { } } } - LOG.error("getVpnForRouter : VPN not found for routerID:{}", routerId); + LOG.debug("getVpnForRouter : VPN not found for routerID:{}", routerId); return null; } @@ -1108,7 +1108,7 @@ public class NatUtil { WriteTransaction writeOperTxn) { BigInteger dpId = getDpnForInterface(ifaceMgrRpcService, vpnInterfaceName); if (dpId.equals(BigInteger.ZERO)) { - LOG.warn("removeFromNeutronRouterDpnsMap : Could not retrieve dp id for interface {} to handle router {}" + LOG.debug("removeFromNeutronRouterDpnsMap : Could not retrieve dp id for interface {} to handle router {}" + " dissociation model", vpnInterfaceName, routerName); return; } @@ -1153,8 +1153,9 @@ public class NatUtil { OdlInterfaceRpcService ifaceMgrRpcService, WriteTransaction writeOperTxn) { BigInteger dpId = getDpnForInterface(ifaceMgrRpcService, vpnInterfaceName); if (dpId.equals(BigInteger.ZERO)) { - LOG.warn("removeFromDpnRoutersMap : removeFromDpnRoutersMap() : Could not retrieve DPN ID for interface {} " - + "to handle router {} dissociation model", vpnInterfaceName, routerName); + LOG.debug("removeFromDpnRoutersMap : removeFromDpnRoutersMap() : " + + "Could not retrieve DPN ID for interface {} to handle router {} dissociation model", + vpnInterfaceName, routerName); return; } removeFromDpnRoutersMap(broker, routerName, vpnInterfaceName, dpId, ifaceMgrRpcService, writeOperTxn); @@ -1238,7 +1239,7 @@ public class NatUtil { continue; } if (!vmInterfaceName.equalsIgnoreCase(vpnInterfaceName)) { - LOG.error("removeFromDpnRoutersMap : Router {} is present in the DPN {} through the other interface {} " + LOG.info("removeFromDpnRoutersMap : Router {} is present in the DPN {} through the other interface {} " + "Hence DPN router model WOULD NOT be cleared", routerName, curDpnId, vmInterfaceName); return; } @@ -1278,7 +1279,7 @@ public class NatUtil { if (dpIdResult.isSuccessful()) { nodeId = dpIdResult.getResult().getDpid(); } else { - LOG.error("removeFromDpnRoutersMap : Could not retrieve DPN Id for interface {}", ifName); + LOG.debug("removeFromDpnRoutersMap : Could not retrieve DPN Id for interface {}", ifName); } } catch (NullPointerException | InterruptedException | ExecutionException e) { LOG.error("removeFromDpnRoutersMap : Exception when getting dpn for interface {}", ifName, e); diff --git a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java index 56009c1a0c..f0ac3a1350 100644 --- a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java +++ b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java @@ -565,7 +565,7 @@ public class NeutronvpnNatManager implements AutoCloseable { if (optionalRouters.isPresent()) { builder = new RoutersBuilder(optionalRouters.get()); } else { - LOG.error("No Routers element found for router {}", routerId.getValue()); + LOG.debug("No Routers element found for router {}", routerId.getValue()); return; } List subList = NeutronvpnUtils.getNeutronRouterSubnetIds(broker, routerId); diff --git a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java index abec07ccf1..d527087503 100644 --- a/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java +++ b/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java @@ -213,7 +213,7 @@ public class NeutronvpnUtils { } } } - LOG.error("getVpnForNetwork: Failed for network {} as no VPN present in VPNMaps DS", network.getValue()); + LOG.debug("getVpnForNetwork: Failed for network {} as no VPN present in VPNMaps DS", network.getValue()); return null; } @@ -259,7 +259,7 @@ public class NeutronvpnUtils { } } } - LOG.error("getVpnForRouter: Failed for router {} as no VPN present in VPNMaps DS", routerId.getValue()); + LOG.debug("getVpnForRouter: Failed for router {} as no VPN present in VPNMaps DS", routerId.getValue()); return null; } diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java index 336ef98a9a..e734221e0a 100644 --- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java +++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java @@ -174,7 +174,7 @@ public class SubnetOpDpnManager { subOpIdentifier.child(SubnetToDpn.class, new SubnetToDpnKey(dpnId)); Optional optionalSubDpn = VpnUtil.read(broker, LogicalDatastoreType.OPERATIONAL, dpnOpId); if (!optionalSubDpn.isPresent()) { - LOG.error("removeInterfaceFromDpn: Cannot delete, SubnetToDpn for intf {} subnet {} DPN {}" + LOG.debug("removeInterfaceFromDpn: Cannot delete, SubnetToDpn for intf {} subnet {} DPN {}" + " not available in datastore", intfName, subnetId.getValue(), dpnId); return false; } diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java index 7f6c346f90..c54121c8f3 100644 --- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java +++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java @@ -80,7 +80,7 @@ public class SubnetRouteInterfaceStateChangeListener extends AsyncDataTreeChange if (intrf.getOperStatus().equals(Interface.OperStatus.Up)) { subnetId = getSubnetId(intrf); if (subnetId == null) { - LOG.error("SubnetRouteInterfaceListener add: Port {} doesnt exist in configDS", + LOG.trace("SubnetRouteInterfaceListener add: Port {} doesnt exist in configDS", intrf.getName()); return; } @@ -120,7 +120,7 @@ public class SubnetRouteInterfaceStateChangeListener extends AsyncDataTreeChange LOG.trace("SubnetRouteInterfaceListener remove: Received interface {} down event", intrf); subnetId = getSubnetId(intrf); if (subnetId == null) { - LOG.error("SubnetRouteInterfaceListener add: Port {} doesnt exist in configDS", + LOG.trace("SubnetRouteInterfaceListener add: Port {} doesnt exist in configDS", intrf.getName()); return; } @@ -172,7 +172,7 @@ public class SubnetRouteInterfaceStateChangeListener extends AsyncDataTreeChange original, update); subnetId = getSubnetId(update); if (subnetId == null) { - LOG.error("SubnetRouteInterfaceListener update: Port {} doesnt exist in configDS", + LOG.trace("SubnetRouteInterfaceListener update: Port {} doesnt exist in configDS", update.getName()); return; } diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java index a8b8bc03ce..21d8153cd0 100644 --- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java +++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java @@ -307,7 +307,7 @@ public class VpnFootprintService implements IVpnFootprintService { } List ipAddresses = dpnInVpn.getIpAddresses(); if (ipAddresses == null) { - LOG.error("Could not find ipAddresses for DpnInVpn map for VPN=[name={} rd={} id={}] and dpnId={}", + LOG.info("Could not find ipAddresses for DpnInVpn map for VPN=[name={} rd={} id={}] and dpnId={}", vpnName, rd, id, dpnId); return; } diff --git a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java index 6e43b77543..1df2f5d14e 100644 --- a/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java +++ b/vpnservice/vpnmanager/vpnmanager-impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java @@ -552,7 +552,7 @@ public class VpnSubnetRouteHandler { Optional optionalSubs = VpnUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, subOpIdentifier); if (!optionalSubs.isPresent()) { - LOG.error("{} onInterfaceUp: SubnetOpDataEntry for subnet {} is not available." + LOG.trace("{} onInterfaceUp: SubnetOpDataEntry for subnet {} is not available." + " Ignoring interfaceUp for port{}", LOGGING_PREFIX, subnetId.getValue(), intfName); return; }