From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 14 Feb 2019 16:40:47 +0000 (+0100)
Subject: Fix ImmutableUnkeyedListNodeBuilder.valueEquals()
X-Git-Tag: v2.0.17~17
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=0736c9c93dff667dd2abaf5de92ca68ea64869d6;p=yangtools.git

Fix ImmutableUnkeyedListNodeBuilder.valueEquals()

Returning an empty Set from getValue() means that if we ever
encountered two instances of this class in comparison, their values
would fail to compare, as valueEquals() expects a List.

Fix this by returning ImmutableList.of() and codify that in the
return value.

Change-Id: I4301f4161648ea391f2e0a1e712e3f87c6dca33c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 25754bb0fdf91e8d48994f9c186e90f9f1901f5c)
---

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListNodeBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListNodeBuilder.java
index 4e08521e38..224d0aef84 100644
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListNodeBuilder.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/ImmutableUnkeyedListNodeBuilder.java
@@ -125,8 +125,8 @@ public class ImmutableUnkeyedListNodeBuilder implements CollectionNodeBuilder<Un
         }
 
         @Override
-        public Collection<UnkeyedListEntryNode> getValue() {
-            return Collections.emptySet();
+        public ImmutableList<UnkeyedListEntryNode> getValue() {
+            return ImmutableList.of();
         }
 
         @Override