From: Robert Varga <robert.varga@pantheon.tech>
Date: Mon, 12 Jun 2023 15:13:04 +0000 (+0200)
Subject: Use instanceof pattern in constructor
X-Git-Tag: v11.0.0~24
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=07c16e960602baf5089dc703bfd30644b06df4b3;p=yangtools.git

Use instanceof pattern in constructor

Take advantage of an instanceof pattern, so we eliminate an explicit
cast.

Change-Id: I5bf63332ec2021c79c27b3e8746b42aeb6f66376
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/data/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/NormalizedNodeStreamWriterStack.java b/data/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/NormalizedNodeStreamWriterStack.java
index 57ab071a6e..820e700196 100644
--- a/data/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/NormalizedNodeStreamWriterStack.java
+++ b/data/yang-data-util/src/main/java/org/opendaylight/yangtools/yang/data/util/NormalizedNodeStreamWriterStack.java
@@ -72,10 +72,12 @@ public final class NormalizedNodeStreamWriterStack implements LeafrefResolver {
     private NormalizedNodeStreamWriterStack(final SchemaInferenceStack dataTree) {
         this.dataTree = requireNonNull(dataTree);
         if (!dataTree.isEmpty()) {
-            final EffectiveStatement<?, ?> current = dataTree.currentStatement();
-            checkArgument(current instanceof DataNodeContainer, "Cannot instantiate on %s", current);
-
-            root = (DataNodeContainer) current;
+            final var current = dataTree.currentStatement();
+            if (current instanceof DataNodeContainer container) {
+                root = container;
+            } else {
+                throw new IllegalArgumentException("Cannot instantiate on " + current);
+            }
         } else {
             root = dataTree.getEffectiveModelContext();
         }