From: Stephen Kitt Date: Thu, 14 Feb 2019 14:34:12 +0000 (+0100) Subject: Switch to JDT annotations for Nullable and NonNull X-Git-Tag: release/sodium~60 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=09e87c1f400b1f41e1efa1a53d1fdcbfc8ac63a8;p=netvirt.git Switch to JDT annotations for Nullable and NonNull This reduces our dependency on JSR-305 which causes a number of issues (e.g. with javax.annotation resolution in OSGi bundles). Annotations on local variables are removed because they trigger a Javac bug which crashes ASM and then FindBugs, SpotBugs and JaCoCo. Change-Id: I8c7736fe57e1e953dfa8e7dcf46d89d2166c892e Signed-off-by: Stephen Kitt --- diff --git a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclInterfaceCache.java b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclInterfaceCache.java index db833891c8..c6aea69bfd 100644 --- a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclInterfaceCache.java +++ b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclInterfaceCache.java @@ -11,8 +11,8 @@ import java.util.Collection; import java.util.Map.Entry; import java.util.function.BiConsumer; import java.util.function.BiFunction; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.aclservice.api.utils.AclInterface; /** @@ -32,9 +32,9 @@ public interface AclInterfaceCache { * the Builder is initially populated from the existing instance. * @return the new or updated AclInterface */ - @Nonnull - AclInterface addOrUpdate(@Nonnull String interfaceId, - @Nonnull BiConsumer updateFunction); + @NonNull + AclInterface addOrUpdate(@NonNull String interfaceId, + @NonNull BiConsumer updateFunction); /** * Updates an existing AclInterface instance in the cache. The given updateFunction is used to build a new instance. @@ -47,8 +47,8 @@ public interface AclInterfaceCache { * @return the updated AclInterface or null if no instance was present or no updates were made */ @Nullable - AclInterface updateIfPresent(@Nonnull String interfaceId, - @Nonnull BiFunction updateFunction); + AclInterface updateIfPresent(@NonNull String interfaceId, + @NonNull BiFunction updateFunction); /** * Removes an AclInterface instance from the cache. @@ -56,7 +56,7 @@ public interface AclInterfaceCache { * @param interfaceId the interface Id * @return the AclInterface if present, null oherwise */ - AclInterface remove(@Nonnull String interfaceId); + AclInterface remove(@NonNull String interfaceId); /** * Gets an AclInterface instance from the cache if present. @@ -65,8 +65,8 @@ public interface AclInterfaceCache { * @return the AclInterface instance if found, null otherwise */ @Nullable - AclInterface get(@Nonnull String interfaceId); + AclInterface get(@NonNull String interfaceId); - @Nonnull + @NonNull Collection> entries(); } diff --git a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclServiceManager.java b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclServiceManager.java index e4b064537f..9bc153f1b7 100644 --- a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclServiceManager.java +++ b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/AclServiceManager.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.aclservice.api; import java.util.Collection; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.aclservice.api.utils.AclInterface; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.acl.access.list.entries.Ace; diff --git a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclDataCache.java b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclDataCache.java index 16b9536fba..0d1a79a67f 100644 --- a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclDataCache.java +++ b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclDataCache.java @@ -10,8 +10,8 @@ package org.opendaylight.netvirt.aclservice.api.utils; import java.util.Collection; import java.util.Map; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.DirectionBase; @@ -30,19 +30,19 @@ public interface AclDataCache { @Nullable Integer getAclTag(String aclId); - @Nonnull + @NonNull Map> getAclInterfaceMap(); - @Nonnull + @NonNull Map> getEgressRemoteAclIdMap(); - @Nonnull + @NonNull Map> getIngressRemoteAclIdMap(); - @Nonnull + @NonNull Map getAclTagMap(); - @Nonnull + @NonNull Map getAclMap(); } diff --git a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterface.java b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterface.java index 1699bf00e5..2a3ebe2269 100644 --- a/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterface.java +++ b/aclservice/api/src/main/java/org/opendaylight/netvirt/aclservice/api/utils/AclInterface.java @@ -12,7 +12,7 @@ import com.google.common.collect.ImmutableSortedSet; import java.math.BigInteger; import java.util.List; import java.util.SortedSet; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.interfaces._interface.AllowedAddressPairs; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.interfaces._interface.SubnetInfo; diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java index b92f27b1ca..cbf4d4b995 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java @@ -22,7 +22,7 @@ import java.util.Map.Entry; import java.util.Set; import java.util.SortedSet; import java.util.stream.Collectors; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.infra.ManagedNewTransactionRunner; import org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl; diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AclInterfaceCacheImpl.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AclInterfaceCacheImpl.java index 4be2c34401..cd1e2d19ef 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AclInterfaceCacheImpl.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AclInterfaceCacheImpl.java @@ -15,9 +15,9 @@ import java.util.concurrent.ConcurrentMap; import java.util.concurrent.atomic.AtomicBoolean; import java.util.function.BiConsumer; import java.util.function.BiFunction; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.aclservice.api.AclInterfaceCache; import org.opendaylight.netvirt.aclservice.api.utils.AclInterface; import org.opendaylight.netvirt.aclservice.api.utils.AclInterface.Builder; @@ -36,7 +36,7 @@ public class AclInterfaceCacheImpl implements AclInterfaceCache { private final ConcurrentMap cache = new ConcurrentHashMap<>(); @Override - public AclInterface addOrUpdate(@Nonnull String interfaceId, + public AclInterface addOrUpdate(@NonNull String interfaceId, BiConsumer updateFunction) { while (true) { // First try to update the existing instance in the cache if one exists. diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclEventListener.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclEventListener.java index 3f0a85ed37..75985301db 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclEventListener.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclEventListener.java @@ -17,11 +17,11 @@ import java.util.List; import java.util.Objects; import java.util.Set; import java.util.SortedSet; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -265,7 +265,7 @@ public class AclEventListener extends AsyncDataTreeChangeListenerBase getChangedAceList(Acl updatedAcl, Acl currentAcl) { if (updatedAcl == null) { return Collections.emptyList(); diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceListener.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceListener.java index e076fdbbd9..fd4fe04e46 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceListener.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclInterfaceListener.java @@ -9,10 +9,10 @@ package org.opendaylight.netvirt.aclservice.listeners; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -201,8 +201,8 @@ public class AclInterfaceListener extends AsyncDataTreeChangeListenerBase { List sgs = new ArrayList<>(); if (aclInPort != null) { diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclNodeListener.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclNodeListener.java index 64c425299d..cf02d2d241 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclNodeListener.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/listeners/AclNodeListener.java @@ -12,10 +12,10 @@ import static org.opendaylight.genius.infra.Datastore.CONFIGURATION; import java.math.BigInteger; import java.util.Collections; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/stats/AclLiveStatisticsHelper.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/stats/AclLiveStatisticsHelper.java index 955e59b20c..43706a1166 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/stats/AclLiveStatisticsHelper.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/stats/AclLiveStatisticsHelper.java @@ -13,8 +13,8 @@ import java.util.ArrayList; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.mdsalutil.MetaDataUtil; import org.opendaylight.genius.mdsalutil.NwConstants; @@ -71,7 +71,7 @@ public final class AclLiveStatisticsHelper { * @param dataBroker the data broker * @return the acl port stats */ - public static List getAclPortStats(Direction direction, @Nonnull List interfaceNames, + public static List getAclPortStats(Direction direction, @NonNull List interfaceNames, OpendaylightDirectStatisticsService odlDirectStatsService, DataBroker dataBroker) { LOG.trace("Get ACL port stats for direction {} and interfaces {}", direction, interfaceNames); List lstAclPortStats = new ArrayList<>(); diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclDataUtil.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclDataUtil.java index 1cfa4ef969..dda987e04c 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclDataUtil.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclDataUtil.java @@ -21,9 +21,9 @@ import java.util.Map.Entry; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.aclservice.api.utils.AclDataCache; import org.opendaylight.netvirt.aclservice.api.utils.AclInterface; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; @@ -101,7 +101,7 @@ public class AclDataUtil implements AclDataCache { } @Override - @Nonnull + @NonNull public Collection getInterfaceList(Uuid acl) { final ConcurrentMap interfaceMap = aclInterfaceMap.get(acl); return interfaceMap != null ? interfaceMap.values() : Collections.emptySet(); diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclNodeDefaultFlowsTxBuilder.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclNodeDefaultFlowsTxBuilder.java index 02d8df6143..4eccbc73d2 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclNodeDefaultFlowsTxBuilder.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclNodeDefaultFlowsTxBuilder.java @@ -13,7 +13,7 @@ import java.math.BigInteger; import java.util.ArrayList; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.TypedWriteTransaction; import org.opendaylight.genius.mdsalutil.ActionInfo; diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java index cd48ac37d0..7d35bef466 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java @@ -14,7 +14,7 @@ import java.util.List; import java.util.Map; import java.util.Map.Entry; import java.util.function.BiFunction; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.mdsalutil.ActionInfo; import org.opendaylight.genius.mdsalutil.InstructionInfo; import org.opendaylight.genius.mdsalutil.MatchInfoBase; diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java index 49cc0cfb7a..a5d3e7756d 100644 --- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java +++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceUtils.java @@ -31,9 +31,9 @@ import java.util.SortedSet; import java.util.TreeSet; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -215,9 +215,8 @@ public final class AclServiceUtils { * @param interfaceName the interface name. * @return the interface state. */ - @Nullable public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state - .Interface getInterfaceStateFromOperDS(DataBroker dataBroker, String interfaceName) { + .@Nullable Interface getInterfaceStateFromOperDS(DataBroker dataBroker, String interfaceName) { InstanceIdentifier ifStateId = buildStateInterfaceId(interfaceName); return MDSALUtil.read(LogicalDatastoreType.OPERATIONAL, ifStateId, dataBroker).orNull(); diff --git a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpConfigurationManager.java b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpConfigurationManager.java index d872a6d7b7..ab413b9ee8 100755 --- a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpConfigurationManager.java +++ b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpConfigurationManager.java @@ -43,13 +43,13 @@ import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.atomic.AtomicReference; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.thrift.TApplicationException; import org.apache.thrift.TException; import org.apache.thrift.transport.TTransport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpManager.java b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpManager.java index af53799370..663ad2ae2c 100644 --- a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpManager.java +++ b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/BgpManager.java @@ -15,12 +15,12 @@ import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.thrift.TException; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/oam/BgpCounters.java b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/oam/BgpCounters.java index 95a6299550..36fde58d44 100644 --- a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/oam/BgpCounters.java +++ b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/oam/BgpCounters.java @@ -9,7 +9,6 @@ package org.opendaylight.netvirt.bgpmanager.oam; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; - import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; @@ -29,10 +28,8 @@ import java.util.List; import java.util.Map; import java.util.Scanner; import java.util.concurrent.ConcurrentHashMap; - -import javax.annotation.Nonnull; import javax.inject.Inject; - +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.infrautils.metrics.Counter; import org.opendaylight.infrautils.metrics.Labeled; import org.opendaylight.infrautils.metrics.MetricDescriptor; @@ -176,7 +173,7 @@ public class BgpCounters implements Runnable, AutoCloseable { } } - private static boolean validate(@Nonnull final String ip, af_afi afi) { + private static boolean validate(@NonNull final String ip, af_afi afi) { if (ip.equals("")) { return false; } diff --git a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/thrift/client/BgpRouter.java b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/thrift/client/BgpRouter.java index ab9433ab1b..143af53ea7 100644 --- a/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/thrift/client/BgpRouter.java +++ b/bgpmanager/impl/src/main/java/org/opendaylight/netvirt/bgpmanager/thrift/client/BgpRouter.java @@ -17,12 +17,12 @@ import java.util.Arrays; import java.util.List; import java.util.function.BooleanSupplier; import java.util.function.Supplier; -import javax.annotation.Nullable; import org.apache.thrift.TException; import org.apache.thrift.protocol.TBinaryProtocol; import org.apache.thrift.transport.TSocket; import org.apache.thrift.transport.TTransport; import org.apache.thrift.transport.TTransportException; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.bgpmanager.BgpConfigurationManager; import org.opendaylight.netvirt.bgpmanager.RetryOnException; import org.opendaylight.netvirt.bgpmanager.thrift.gen.BfdConfigData; diff --git a/cloud-servicechain/impl/src/main/java/org/opendaylight/netvirt/cloudservicechain/utils/VpnPseudoPortCache.java b/cloud-servicechain/impl/src/main/java/org/opendaylight/netvirt/cloudservicechain/utils/VpnPseudoPortCache.java index be8208e846..1960556c73 100755 --- a/cloud-servicechain/impl/src/main/java/org/opendaylight/netvirt/cloudservicechain/utils/VpnPseudoPortCache.java +++ b/cloud-servicechain/impl/src/main/java/org/opendaylight/netvirt/cloudservicechain/utils/VpnPseudoPortCache.java @@ -10,11 +10,11 @@ package org.opendaylight.netvirt.cloudservicechain.utils; import java.util.List; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.cloud.servicechain.state.rev160711.vpn.to.pseudo.port.list.VpnToPseudoPortData; @@ -49,18 +49,18 @@ public class VpnPseudoPortCache { } } - public void add(@Nonnull String vrfId, long vpnPseudoLportTag) { + public void add(@NonNull String vrfId, long vpnPseudoLportTag) { LOG.debug("Adding vpn {} and vpnPseudoLportTag {} to VpnPseudoPortCache", vrfId, vpnPseudoLportTag); cache.put(vrfId, Long.valueOf(vpnPseudoLportTag)); } @Nullable - public Long get(@Nonnull String vrfId) { + public Long get(@NonNull String vrfId) { return cache.get(vrfId); } @Nullable - public Long remove(@Nonnull String vrfId) { + public Long remove(@NonNull String vrfId) { LOG.debug("Removing vpn {} from VpnPseudoPortCache", vrfId); return cache.remove(vrfId); } diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ClusterListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ClusterListener.java index 1712c38ff7..12fb41c69f 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ClusterListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ClusterListener.java @@ -14,9 +14,9 @@ import com.google.common.util.concurrent.ListenableFuture; import java.util.ArrayList; import java.util.List; import java.util.concurrent.Callable; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.ManagedNewTransactionRunner; @@ -52,7 +52,7 @@ public class ClusterListener extends AbstractSyncDataTreeChangeListener instanceIdentifier, @Nonnull K8sClusters clusters) { + public void remove(@NonNull InstanceIdentifier instanceIdentifier, @NonNull K8sClusters clusters) { LOG.trace("K8 Cluster deleted {}", clusters); if (clusters.getClusterId() == null) { LOG.error("K8 cluster {} deleted with null cluster-id"); @@ -64,14 +64,14 @@ public class ClusterListener extends AbstractSyncDataTreeChangeListener instanceIdentifier, - @Nonnull K8sClusters originalClusters, - @Nonnull final K8sClusters updatedClusters) { + public void update(@NonNull InstanceIdentifier instanceIdentifier, + @NonNull K8sClusters originalClusters, + @NonNull final K8sClusters updatedClusters) { LOG.trace("K8 Cluster updated {} to {} . doing nothing", originalClusters, updatedClusters); } @Override - public void add(@Nonnull InstanceIdentifier instanceIdentifier, @Nonnull K8sClusters clusters) { + public void add(@NonNull InstanceIdentifier instanceIdentifier, @NonNull K8sClusters clusters) { LOG.trace("K8 Cluster added {}", clusters); if (clusters.getClusterId() == null) { LOG.error("K8 cluster {} added with null cluster-id"); diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/InventoryNodeListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/InventoryNodeListener.java index 0904c25cc7..73d0db35ac 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/InventoryNodeListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/InventoryNodeListener.java @@ -10,11 +10,10 @@ package org.opendaylight.netvirt.coe.listeners; import java.math.BigInteger; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; - import org.apache.aries.blueprint.annotation.service.Reference; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore; @@ -55,18 +54,18 @@ public class InventoryNodeListener extends AbstractSyncDataTreeChangeListener instanceIdentifier, @Nonnull Node node) { + public void remove(@NonNull InstanceIdentifier instanceIdentifier, @NonNull Node node) { // Do nothing } @Override - public void update(@Nonnull InstanceIdentifier instanceIdentifier, @Nonnull Node originalNode, - @Nonnull final Node updatedNode) { + public void update(@NonNull InstanceIdentifier instanceIdentifier, @NonNull Node originalNode, + @NonNull final Node updatedNode) { // Nothing to do } @Override - public void add(@Nonnull InstanceIdentifier instanceIdentifier, @Nonnull Node node) { + public void add(@NonNull InstanceIdentifier instanceIdentifier, @NonNull Node node) { NodeId nodeId = node.getId(); String[] nodeIdVal = nodeId.getValue().split(":"); if (nodeIdVal.length < 2) { diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/NetworkPolicyListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/NetworkPolicyListener.java index 6e5a7cfd5a..4755888875 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/NetworkPolicyListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/NetworkPolicyListener.java @@ -12,10 +12,10 @@ import static org.opendaylight.netvirt.coe.utils.AceNetworkPolicyUtils.buildAcl; import static org.opendaylight.netvirt.coe.utils.AceNetworkPolicyUtils.getAclNameFromPolicy; import static org.opendaylight.netvirt.coe.utils.AclUtils.getAclIid; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.aries.blueprint.annotation.service.Reference; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.RetryingManagedNewTransactionRunner; @@ -42,25 +42,25 @@ public class NetworkPolicyListener extends AbstractSyncDataTreeChangeListener instanceIdentifier, @Nonnull NetworkPolicy policy) { + public void add(@NonNull InstanceIdentifier instanceIdentifier, @NonNull NetworkPolicy policy) { LOG.info("add: id: {}\npolicy: {}", instanceIdentifier, policy); updateAcl(policy, false); } @Override - public void remove(@Nonnull InstanceIdentifier instanceIdentifier, @Nonnull NetworkPolicy policy) { + public void remove(@NonNull InstanceIdentifier instanceIdentifier, @NonNull NetworkPolicy policy) { LOG.info("remove: id: {}\npolicy: {}", instanceIdentifier, policy); updateAcl(policy, true); } @Override - public void update(@Nonnull InstanceIdentifier instanceIdentifier, - @Nonnull NetworkPolicy oldPolicy, @Nonnull NetworkPolicy policy) { + public void update(@NonNull InstanceIdentifier instanceIdentifier, + @NonNull NetworkPolicy oldPolicy, @NonNull NetworkPolicy policy) { LOG.info("update: id: {}\nold policy: {}\nnew policy: {}", instanceIdentifier, oldPolicy, policy); updateAcl(policy, false); } - private void updateAcl(@Nonnull NetworkPolicy policy, boolean isDeleted) { + private void updateAcl(@NonNull NetworkPolicy policy, boolean isDeleted) { LoggingFutures.addErrorLogging(txRunner.callWithNewWriteOnlyTransactionAndSubmit(CONFIGURATION, tx -> { String aclName = getAclNameFromPolicy(policy); Acl acl = buildAcl(policy, isDeleted); diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/PodListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/PodListener.java index 13e0a87141..ecdcf485f8 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/PodListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/PodListener.java @@ -17,11 +17,11 @@ import java.util.Collection; import java.util.List; import java.util.Objects; import java.util.concurrent.Callable; -import javax.annotation.Nonnull; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.aries.blueprint.annotation.service.Reference; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; import org.opendaylight.controller.md.sal.binding.api.DataTreeChangeListener; @@ -80,7 +80,7 @@ public class PodListener implements DataTreeChangeListener { } @Override - public void onDataTreeChanged(@Nonnull Collection> collection) { + public void onDataTreeChanged(@NonNull Collection> collection) { collection.forEach( podsDataTreeModification -> podsDataTreeModification.getRootNode().getModifiedChildren().stream() .filter( diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ServiceListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ServiceListener.java index e9c34d6f87..caef4774ab 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ServiceListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/ServiceListener.java @@ -11,11 +11,11 @@ package org.opendaylight.netvirt.coe.listeners; import static org.opendaylight.genius.infra.Datastore.CONFIGURATION; import java.util.Collection; -import javax.annotation.Nonnull; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.aries.blueprint.annotation.service.Reference; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; import org.opendaylight.controller.md.sal.binding.api.DataTreeChangeListener; @@ -70,7 +70,7 @@ public class ServiceListener implements DataTreeChangeListener { } @Override - public void onDataTreeChanged(@Nonnull Collection> changes) { + public void onDataTreeChanged(@NonNull Collection> changes) { for (DataTreeModification change : changes) { final DataObjectModification mod = change.getRootNode(); diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/TerminationPointStateListener.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/TerminationPointStateListener.java index f48629d95b..3288a23cfb 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/TerminationPointStateListener.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/listeners/TerminationPointStateListener.java @@ -14,10 +14,10 @@ import java.util.ArrayList; import java.util.List; import java.util.Objects; import java.util.Optional; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.aries.blueprint.annotation.service.Reference; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.listeners.DataTreeEventCallbackRegistrar; diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AceNetworkPolicyUtils.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AceNetworkPolicyUtils.java index 477d3609d2..031ae5f052 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AceNetworkPolicyUtils.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AceNetworkPolicyUtils.java @@ -12,7 +12,7 @@ import static org.opendaylight.netvirt.coe.utils.AclUtils.buildName; import static org.opendaylight.netvirt.coe.utils.NetworkPolicyUtils.PROTOCOL_MAP; import java.util.ArrayList; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.Ipv4Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.AclBuilder; @@ -50,8 +50,8 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev16060 public final class AceNetworkPolicyUtils { private AceNetworkPolicyUtils() {} - @Nonnull - public static String getAclNameFromPolicy(@Nonnull NetworkPolicy policy) { + @NonNull + public static String getAclNameFromPolicy(@NonNull NetworkPolicy policy) { String aclName = ""; if (policy.getUuid() != null) { aclName = policy.getUuid().getValue(); @@ -62,8 +62,8 @@ public final class AceNetworkPolicyUtils { // TODO map empty rules: // ingress:empty - no incoming allowed // egress:empty - no outgoing allowed - @Nonnull - public static Acl buildAcl(@Nonnull NetworkPolicy policy, boolean isDeleted) { + @NonNull + public static Acl buildAcl(@NonNull NetworkPolicy policy, boolean isDeleted) { String aclName = getAclNameFromPolicy(policy); ArrayList aceList = new ArrayList<>(); @@ -129,10 +129,10 @@ public final class AceNetworkPolicyUtils { return aclBuilder.build(); } - @Nonnull + @NonNull public static AceBuilder getAceBuilder(boolean isDeleted, String ruleName, - @Nonnull Class direction, - @Nonnull AceIpBuilder aceIpBuilder) { + @NonNull Class direction, + @NonNull AceIpBuilder aceIpBuilder) { MatchesBuilder matchesBuilder = new MatchesBuilder(); matchesBuilder.setAceType(aceIpBuilder.build()); ActionsBuilder actionsBuilder = new ActionsBuilder(); @@ -151,10 +151,10 @@ public final class AceNetworkPolicyUtils { return aceBuilder; } - @Nonnull - public static Ace buildPortAce(boolean isDeleted, @Nonnull String aclName, - @Nonnull Class direction, - @Nonnull NetworkPolicyPort port) { + @NonNull + public static Ace buildPortAce(boolean isDeleted, @NonNull String aclName, + @NonNull Class direction, + @NonNull NetworkPolicyPort port) { AceIpBuilder aceIpBuilder = new AceIpBuilder(); String ruleName = AclUtils.buildName(aclName, DIRECTION_MAP.get(direction), "port"); if (port.getProtocol() != null) { @@ -177,10 +177,10 @@ public final class AceNetworkPolicyUtils { return aceBuilder.build(); } - @Nonnull - public static Ace buildPolicyAce(boolean isDeleted, @Nonnull String aclName, - @Nonnull Class direction, - @Nonnull NetworkPolicyPeer peer) { + @NonNull + public static Ace buildPolicyAce(boolean isDeleted, @NonNull String aclName, + @NonNull Class direction, + @NonNull NetworkPolicyPeer peer) { AceIpBuilder aceIpBuilder = new AceIpBuilder(); String ruleName = AclUtils.buildName(aclName, DIRECTION_MAP.get(direction), "peer"); diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AclUtils.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AclUtils.java index 1a6e6737c7..4cbbcf73da 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AclUtils.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/AclUtils.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.coe.utils; import com.google.common.collect.ImmutableBiMap; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.AccessLists; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.Ipv4Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; @@ -31,23 +31,23 @@ public final class AclUtils { private AclUtils() {} - @Nonnull - public static InstanceIdentifier getAclIid(@Nonnull String aclName) { + @NonNull + public static InstanceIdentifier getAclIid(@NonNull String aclName) { return InstanceIdentifier .builder(AccessLists.class) .child(Acl.class, new AclKey(aclName, Ipv4Acl.class)) .build(); } - @Nonnull - public static InstanceIdentifier getAceIid(@Nonnull String aclName, @Nonnull String ruleName) { + @NonNull + public static InstanceIdentifier getAceIid(@NonNull String aclName, @NonNull String ruleName) { return getAclIid(aclName).builder() .child(AccessListEntries.class) .child(Ace.class, new AceKey(ruleName)) .build(); } - @Nonnull + @NonNull public static String buildName(String... args) { return String.join("_", args); } diff --git a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/NetworkPolicyUtils.java b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/NetworkPolicyUtils.java index eb1ba99c1e..5f7e5995a2 100644 --- a/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/NetworkPolicyUtils.java +++ b/coe/impl/src/main/java/org/opendaylight/netvirt/coe/utils/NetworkPolicyUtils.java @@ -9,8 +9,8 @@ package org.opendaylight.netvirt.coe.utils; import com.google.common.collect.ImmutableBiMap; import java.util.List; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.k8s.core.rev181205.Protocol; import org.opendaylight.yang.gen.v1.urn.opendaylight.k8s.meta.v1.rev181205.label.selector.MatchLabels; @@ -58,24 +58,24 @@ public final class NetworkPolicyUtils { private NetworkPolicyUtils() {} - @Nonnull - public static MatchLabels buildMatchLabels(@Nonnull String key, @Nonnull String value) { + @NonNull + public static MatchLabels buildMatchLabels(@NonNull String key, @NonNull String value) { return new MatchLabelsBuilder().setKey(key).setValue(value).build(); } - @Nonnull - public static PodSelector buildPodSelector(@Nonnull List matchLabels) { + @NonNull + public static PodSelector buildPodSelector(@NonNull List matchLabels) { return new PodSelectorBuilder().setMatchLabels(matchLabels).build(); } - @Nonnull - public static InstanceIdentifier getNetworkPolicyIid(@Nonnull String uuid) { + @NonNull + public static InstanceIdentifier getNetworkPolicyIid(@NonNull String uuid) { return InstanceIdentifier.create(K8s.class).child(NetworkPolicies.class) .child(NetworkPolicy.class, new NetworkPolicyKey(new Uuid(uuid))); } - @Nonnull - public static IpBlock buildIpBlock(@Nonnull String cidr, @Nullable List except) { + @NonNull + public static IpBlock buildIpBlock(@NonNull String cidr, @Nullable List except) { IpBlockBuilder ipBlockBuilder = new IpBlockBuilder().setCidr(cidr); if (except != null && !except.isEmpty()) { @@ -86,37 +86,37 @@ public final class NetworkPolicyUtils { } // TODO add pod and namespace selector handling - @Nonnull - public static NetworkPolicyPeer buildNetworkPolicyPeer(@Nonnull IpBlock ipBlock) { + @NonNull + public static NetworkPolicyPeer buildNetworkPolicyPeer(@NonNull IpBlock ipBlock) { return new NetworkPolicyPeerBuilder().setIpBlock(ipBlock).build(); } - @Nonnull - public static NetworkPolicyPort buildNetworkPolicyPort(@Nonnull String port, @Nonnull Protocol protocol) { + @NonNull + public static NetworkPolicyPort buildNetworkPolicyPort(@NonNull String port, @NonNull Protocol protocol) { return new NetworkPolicyPortBuilder().setPort(port).setProtocol(protocol).build(); } - @Nonnull - public static IngressPorts buildIngressPorts(@Nonnull NetworkPolicyPort port) { + @NonNull + public static IngressPorts buildIngressPorts(@NonNull NetworkPolicyPort port) { return new IngressPortsBuilder().setNetworkPolicyPort(port).build(); } - @Nonnull - public static From buildFrom(@Nonnull NetworkPolicyPeer peer) { + @NonNull + public static From buildFrom(@NonNull NetworkPolicyPeer peer) { return new FromBuilder().setNetworkPolicyPeer(peer).build(); } - @Nonnull - public static EgressPorts buildEgressPorts(@Nonnull NetworkPolicyPort port) { + @NonNull + public static EgressPorts buildEgressPorts(@NonNull NetworkPolicyPort port) { return new EgressPortsBuilder().setNetworkPolicyPort(port).build(); } - @Nonnull - public static To buildTo(@Nonnull NetworkPolicyPeer peer) { + @NonNull + public static To buildTo(@NonNull NetworkPolicyPeer peer) { return new ToBuilder().setNetworkPolicyPeer(peer).build(); } - @Nonnull + @NonNull public static NetworkPolicyIngressRule buildNetworkPolicyIngressRule(@Nullable List ports, @Nullable List fromList) { @@ -132,7 +132,7 @@ public final class NetworkPolicyUtils { return networkPolicyIngressRuleBuilder.build(); } - @Nonnull + @NonNull public static NetworkPolicyEgressRule buildNetworkPolicyEgressRule(@Nullable List ports, @Nullable List toList) { @@ -148,18 +148,18 @@ public final class NetworkPolicyUtils { return networkPolicyEgressRuleBuilder.build(); } - @Nonnull - public static Ingress buildIngress(@Nonnull NetworkPolicyIngressRule rule) { + @NonNull + public static Ingress buildIngress(@NonNull NetworkPolicyIngressRule rule) { return new IngressBuilder().setNetworkPolicyIngressRule(rule).build(); } - @Nonnull - public static Egress buildEgress(@Nonnull NetworkPolicyEgressRule rule) { + @NonNull + public static Egress buildEgress(@NonNull NetworkPolicyEgressRule rule) { return new EgressBuilder().setNetworkPolicyEgressRule(rule).build(); } - @Nonnull - public static NetworkPolicySpec buildNetworkPolicySpec(@Nonnull PodSelector podSelector, + @NonNull + public static NetworkPolicySpec buildNetworkPolicySpec(@NonNull PodSelector podSelector, @Nullable List ingress, @Nullable List egress, @Nullable List policyTypes) { @@ -178,8 +178,8 @@ public final class NetworkPolicyUtils { return networkPolicySpecBuilder.build(); } - @Nonnull - public static NetworkPolicy buildNetworkPolicy(@Nonnull String uuid, @Nullable String name, + @NonNull + public static NetworkPolicy buildNetworkPolicy(@NonNull String uuid, @Nullable String name, @Nullable NetworkPolicySpec spec) { NetworkPolicyBuilder networkPolicyBuilder = new NetworkPolicyBuilder().setUuid(new Uuid(uuid)); if (name != null) { diff --git a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPOptions.java b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPOptions.java index 5fa7146a60..5c6c554fba 100644 --- a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPOptions.java +++ b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPOptions.java @@ -17,8 +17,8 @@ import java.net.UnknownHostException; import java.nio.charset.StandardCharsets; import java.util.LinkedHashMap; import java.util.List; -import javax.annotation.Nullable; import org.apache.commons.lang3.ArrayUtils; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.openflowplugin.libraries.liblldp.HexEncode; import org.opendaylight.openflowplugin.libraries.liblldp.NetUtils; diff --git a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPUtils.java b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPUtils.java index b24fe90584..603b76ac5b 100644 --- a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPUtils.java +++ b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCPUtils.java @@ -13,7 +13,7 @@ import java.math.BigInteger; import java.net.InetAddress; import java.net.UnknownHostException; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; public abstract class DHCPUtils { diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpAllocationPoolManager.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpAllocationPoolManager.java index 750c038d92..29c205bc8f 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpAllocationPoolManager.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpAllocationPoolManager.java @@ -16,12 +16,12 @@ import java.util.Map; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -132,7 +132,7 @@ public class DhcpAllocationPoolManager implements AutoCloseable, EventListener { } } - @Nonnull + @NonNull public Map> getElanDpnInterfacesByName(DataBroker broker, String elanInstanceName) { InstanceIdentifier elanDpnIfacesIid = InstanceIdentifier.builder(ElanDpnInterfaces.class) .child(ElanDpnInterfacesList.class, new ElanDpnInterfacesListKey(elanInstanceName)).build(); diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpConfigListener.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpConfigListener.java index a2cb5d304c..3267c0de68 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpConfigListener.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpConfigListener.java @@ -7,11 +7,11 @@ */ package org.opendaylight.netvirt.dhcpservice; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase; diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java index 5adef7fcfc..504a642916 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java @@ -27,13 +27,13 @@ import java.util.concurrent.ConcurrentMap; import java.util.concurrent.CopyOnWriteArraySet; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Named; import javax.inject.Singleton; import org.apache.commons.lang3.tuple.ImmutablePair; import org.apache.commons.lang3.tuple.Pair; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpL2GwUtil.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpL2GwUtil.java index 13a41a14ea..5e806ab194 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpL2GwUtil.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpL2GwUtil.java @@ -10,9 +10,9 @@ package org.opendaylight.netvirt.dhcpservice; import com.google.common.base.Optional; import java.util.List; import java.util.function.Predicate; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpManager.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpManager.java index 0d9606fb45..71963ed772 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpManager.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpManager.java @@ -12,12 +12,12 @@ import java.math.BigInteger; import java.util.ArrayList; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Named; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore.Configuration; diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpMcastMacListener.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpMcastMacListener.java index 47bb1e90b0..1738a53621 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpMcastMacListener.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpMcastMacListener.java @@ -11,10 +11,10 @@ import com.google.common.util.concurrent.MoreExecutors; import java.math.BigInteger; import java.util.List; import java.util.concurrent.TimeUnit; -import javax.annotation.Nonnull; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.utils.hwvtep.HwvtepNodeHACache; @@ -63,13 +63,13 @@ public class DhcpMcastMacListener } @Override - public void update(@Nonnull InstanceIdentifier identifier, @Nonnull RemoteMcastMacs original, - @Nonnull RemoteMcastMacs update) { + public void update(@NonNull InstanceIdentifier identifier, @NonNull RemoteMcastMacs original, + @NonNull RemoteMcastMacs update) { // NOOP } @Override - public void add(@Nonnull InstanceIdentifier identifier, @Nonnull RemoteMcastMacs remoteMcastMacs) { + public void add(@NonNull InstanceIdentifier identifier, @NonNull RemoteMcastMacs remoteMcastMacs) { String elanInstanceName = getElanName(remoteMcastMacs); IpAddress tunnelIp = dhcpL2GwUtil.getHwvtepNodeTunnelIp(identifier.firstIdentifierOf(Node.class)); if (tunnelIp == null) { @@ -84,8 +84,8 @@ public class DhcpMcastMacListener } @Override - public void remove(@Nonnull InstanceIdentifier identifier, - @Nonnull RemoteMcastMacs remoteMcastMacs) { + public void remove(@NonNull InstanceIdentifier identifier, + @NonNull RemoteMcastMacs remoteMcastMacs) { String elanInstanceName = getElanName(remoteMcastMacs); IpAddress tunnelIp = dhcpL2GwUtil.getHwvtepNodeTunnelIp(identifier.firstIdentifierOf(Node.class)); if (tunnelIp == null) { diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPktHandler.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPktHandler.java index 47cbdac5d7..4de582223a 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPktHandler.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPktHandler.java @@ -19,12 +19,12 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.net.util.SubnetUtils; import org.apache.commons.net.util.SubnetUtils.SubnetInfo; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.genius.interfacemanager.globals.InterfaceInfo; @@ -363,7 +363,7 @@ public class DhcpPktHandler implements PacketProcessingListener { return dhcpInfo; } - @Nonnull + @NonNull private static DhcpInfo getApDhcpInfo(AllocationPool ap, IpAddress allocatedIp) { String clientIp = allocatedIp.stringValue(); String serverIp = ap.getGateway().stringValue(); @@ -746,7 +746,7 @@ public class DhcpPktHandler implements PacketProcessingListener { } } - @Nonnull + @NonNull protected byte[] convertToClasslessRouteOption(String dest, String router) { ByteArrayOutputStream byteArray = new ByteArrayOutputStream(); if (dest == null || router == null) { diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPortCache.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPortCache.java index 66b1f95fc9..d7b6c28670 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPortCache.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpPortCache.java @@ -8,11 +8,10 @@ package org.opendaylight.netvirt.dhcpservice; import java.util.concurrent.ConcurrentHashMap; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Singleton; - +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.ports.attributes.ports.Port; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -28,17 +27,17 @@ public class DhcpPortCache { LOG.trace("Initialize DhcpPortCache. "); } - public void put(@Nonnull String interfaceName, Port port) { + public void put(@NonNull String interfaceName, Port port) { portMap.put(interfaceName, port); LOG.trace("Added the interface {} to DhcpPortCache",interfaceName); } @Nullable - public Port get(@Nonnull String interfaceName) { + public Port get(@NonNull String interfaceName) { return portMap.get(interfaceName); } - public void remove(@Nonnull String interfaceName) { + public void remove(@NonNull String interfaceName) { portMap.remove(interfaceName); } } diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpServiceUtils.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpServiceUtils.java index e9035dd33b..9d52d641bc 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpServiceUtils.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpServiceUtils.java @@ -26,8 +26,8 @@ import java.util.function.BiConsumer; import java.util.function.Consumer; import java.util.stream.Collectors; import java.util.stream.LongStream; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -260,7 +260,7 @@ public final class DhcpServiceUtils { InstanceIdentifier.builder(Nodes.class).build())); } - @Nonnull + @NonNull private static List extractDpnsFromNodes(Optional optionalNodes) { return optionalNodes.toJavaUtil().map( nodes -> nodes.nonnullNode().stream().map(Node::getId).filter(Objects::nonNull).map( @@ -268,7 +268,7 @@ public final class DhcpServiceUtils { Collectors.toList())).orElse(Collections.emptyList()); } - @Nonnull + @NonNull public static List getDpnsForElan(String elanInstanceName, DataBroker broker) { List elanDpns = new LinkedList<>(); InstanceIdentifier elanDpnInstanceIdentifier = @@ -285,9 +285,8 @@ public final class DhcpServiceUtils { return elanDpns; } - @Nullable - public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces - .state.Interface getInterfaceFromOperationalDS(String interfaceName, DataBroker dataBroker) { + public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state + .@Nullable Interface getInterfaceFromOperationalDS(String interfaceName, DataBroker dataBroker) { org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces .state.InterfaceKey interfaceKey = new org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces @@ -486,7 +485,7 @@ public final class DhcpServiceUtils { return null; } - @Nonnull + @NonNull public static List getSubnetIdsFromNetworkId(DataBroker broker, Uuid networkId) { InstanceIdentifier id = buildNetworkMapIdentifier(networkId); Optional optionalNetworkMap = MDSALUtil.read(broker, LogicalDatastoreType.CONFIGURATION, id); diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpUCastMacListener.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpUCastMacListener.java index 77f1e39a8a..332c844c91 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpUCastMacListener.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpUCastMacListener.java @@ -9,13 +9,13 @@ package org.opendaylight.netvirt.dhcpservice; import com.google.common.base.Optional; import java.math.BigInteger; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.tuple.ImmutablePair; import org.apache.commons.lang3.tuple.Pair; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase; diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java index 7d94e248f5..fe2e92dc2c 100644 --- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java +++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/jobs/DhcpInterfaceRemoveJob.java @@ -17,7 +17,7 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.Callable; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.infra.Datastore; import org.opendaylight.genius.infra.ManagedNewTransactionRunner; diff --git a/dhcpservice/shell/src/main/java/org/opendaylight/netvirt/dhcpservice/shell/DhcpCacheCli.java b/dhcpservice/shell/src/main/java/org/opendaylight/netvirt/dhcpservice/shell/DhcpCacheCli.java index 05838d2b64..9dd21630f8 100644 --- a/dhcpservice/shell/src/main/java/org/opendaylight/netvirt/dhcpservice/shell/DhcpCacheCli.java +++ b/dhcpservice/shell/src/main/java/org/opendaylight/netvirt/dhcpservice/shell/DhcpCacheCli.java @@ -7,9 +7,9 @@ */ package org.opendaylight.netvirt.dhcpservice.shell; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.dhcpservice.api.IDhcpExternalTunnelManager; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/api/IL2gwService.java b/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/api/IL2gwService.java index f6eb2d6f3a..86c847d11a 100644 --- a/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/api/IL2gwService.java +++ b/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/api/IL2gwService.java @@ -11,7 +11,7 @@ package org.opendaylight.netvirt.elanmanager.api; import java.util.List; import java.util.Set; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.neutronvpn.api.l2gw.L2GatewayDevice; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; diff --git a/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/utils/ElanL2GwCacheUtils.java b/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/utils/ElanL2GwCacheUtils.java index 953774572f..c28b794509 100644 --- a/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/utils/ElanL2GwCacheUtils.java +++ b/elanmanager/api/src/main/java/org/opendaylight/netvirt/elanmanager/utils/ElanL2GwCacheUtils.java @@ -13,8 +13,8 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.utils.cache.CacheUtil; import org.opendaylight.netvirt.neutronvpn.api.l2gw.L2GatewayDevice; @@ -87,7 +87,7 @@ public final class ElanL2GwCacheUtils { return result; } - @Nonnull + @NonNull public static List getAllElanDevicesFromCache() { ConcurrentMap> cachedMap = (ConcurrentMap>) CacheUtil.getCache( diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInstanceDpnsCache.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInstanceDpnsCache.java index e751323a86..9a537e9799 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInstanceDpnsCache.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInstanceDpnsCache.java @@ -12,8 +12,8 @@ import java.util.Collections; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nonnull; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.dpn.interfaces.elan.dpn.interfaces.list.DpnInterfaces; /** @@ -25,20 +25,20 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan public class ElanInstanceDpnsCache { private final ConcurrentMap> elanInstanceToDpnsCache = new ConcurrentHashMap<>(); - public void add(@Nonnull String elanInstanceName, @Nonnull DpnInterfaces dpnInterfaces) { + public void add(@NonNull String elanInstanceName, @NonNull DpnInterfaces dpnInterfaces) { elanInstanceToDpnsCache.computeIfAbsent(elanInstanceName, key -> ConcurrentHashMap.newKeySet()) .add(dpnInterfaces); } - public void remove(@Nonnull String elanInstanceName, @Nonnull DpnInterfaces dpnInterfaces) { + public void remove(@NonNull String elanInstanceName, @NonNull DpnInterfaces dpnInterfaces) { elanInstanceToDpnsCache.computeIfPresent(elanInstanceName, (key, prevInterfacesSet) -> { prevInterfacesSet.remove(dpnInterfaces); return !prevInterfacesSet.isEmpty() ? prevInterfacesSet : null; }); } - @Nonnull - public Collection get(@Nonnull String elanInstanceName) { + @NonNull + public Collection get(@NonNull String elanInstanceName) { Set dpns = elanInstanceToDpnsCache.get(elanInstanceName); return dpns != null ? Collections.unmodifiableCollection(dpns) : Collections.emptyList(); } diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInterfaceCache.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInterfaceCache.java index 2755a1e52a..20dc778c40 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInterfaceCache.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cache/ElanInterfaceCache.java @@ -13,9 +13,9 @@ import java.util.Collections; import java.util.Map; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -47,8 +47,8 @@ public class ElanInterfaceCache extends InstanceIdDataObjectCache InstanceIdentifier.create(ElanInterfaces.class).child(ElanInterface.class), cacheProvider); } - @Nonnull - public Optional get(@Nonnull String interfaceName) { + @NonNull + public Optional get(@NonNull String interfaceName) { try { return get(ElanUtils.getElanInterfaceConfigurationDataPathId(interfaceName)); } catch (ReadFailedException e) { @@ -57,15 +57,15 @@ public class ElanInterfaceCache extends InstanceIdDataObjectCache } } - @Nonnull - public Optional getEtreeInterface(@Nonnull String interfaceName) { + @NonNull + public Optional getEtreeInterface(@NonNull String interfaceName) { Optional elanInterface = get(interfaceName); return elanInterface.isPresent() ? Optional.fromNullable( elanInterface.get().augmentation(EtreeInterface.class)) : Optional.absent(); } - @Nonnull - public Collection getInterfaceNames(@Nonnull String elanInstanceName) { + @NonNull + public Collection getInterfaceNames(@NonNull String elanInstanceName) { Set removed = elanInstanceToInterfacesCache.remove(elanInstanceName); return removed != null ? Collections.unmodifiableCollection(removed) : Collections.emptySet(); } diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanAdd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanAdd.java index 26b0d5896b..9e6aea1cf9 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanAdd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanAdd.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanDelete.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanDelete.java index 8ea21c3f21..50cd0ba947 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanDelete.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanDelete.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanGet.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanGet.java index 608659c03f..c560813668 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanGet.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanGet.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.utils.ElanCLIUtils; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.instances.ElanInstance; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceAdd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceAdd.java index 9e6fd8e6cf..3078ea488d 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceAdd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceAdd.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceDelete.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceDelete.java index 8d00ee71e9..1c7bad99ab 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceDelete.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceDelete.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceGet.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceGet.java index 46ea6c79d7..dd54ec21a0 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceGet.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceGet.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.interfacemanager.globals.InterfaceInfo; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; import org.opendaylight.netvirt.elan.utils.ElanCLIUtils; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceUpdate.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceUpdate.java index 714665450b..7c233081c2 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceUpdate.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanInterfaceUpdate.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableFlush.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableFlush.java index 3cf3ecbef3..ec5b849891 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableFlush.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableFlush.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableGet.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableGet.java index 326860c50e..80014c88aa 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableGet.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanMacTableGet.java @@ -10,10 +10,10 @@ package org.opendaylight.netvirt.elan.cli; import java.text.SimpleDateFormat; import java.util.Collection; import java.util.Date; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.utils.ElanCLIUtils; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.forwarding.entries.MacEntry; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanUpdate.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanUpdate.java index 8aca18544f..3edf42190a 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanUpdate.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/ElanUpdate.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacAdd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacAdd.java index 1938999f55..0c1abb0a4c 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacAdd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacAdd.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacDelete.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacDelete.java index 03b4991681..26b4a7f09d 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacDelete.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/StaticMacDelete.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeAdd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeAdd.java index e8d5dc712e..76e9c8bb52 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeAdd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeAdd.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli.etree; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeDelete.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeDelete.java index a1a11d3f66..8db917e1b0 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeDelete.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeDelete.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli.etree; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeGet.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeGet.java index 9b2737f213..01caadabc7 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeGet.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeGet.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli.etree; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.utils.ElanCLIUtils; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.etree.rev160614.EtreeInstance; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceAdd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceAdd.java index 44c9b6bbb9..7209fc2cfe 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceAdd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceAdd.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli.etree; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.etree.rev160614.EtreeInstance; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.etree.rev160614.EtreeInterface.EtreeInterfaceType; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceDelete.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceDelete.java index 2484a555dd..6a06e82825 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceDelete.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceDelete.java @@ -7,10 +7,10 @@ */ package org.opendaylight.netvirt.elan.cli.etree; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elanmanager.api.IElanService; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.etree.rev160614.EtreeInterface; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.interfaces.ElanInterface; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceGet.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceGet.java index 41666e3132..783f3637f0 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceGet.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/etree/EtreeInterfaceGet.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.elan.cli.etree; import java.util.List; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.interfacemanager.globals.InterfaceInfo; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; import org.opendaylight.netvirt.elan.utils.ElanCLIUtils; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwUtilsCacheCli.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwUtilsCacheCli.java index 6b035924df..933c1cad92 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwUtilsCacheCli.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwUtilsCacheCli.java @@ -17,10 +17,10 @@ import java.util.Collection; import java.util.Map; import java.util.Map.Entry; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.utils.cache.CacheUtil; import org.opendaylight.genius.utils.hwvtep.HwvtepNodeHACache; import org.opendaylight.netvirt.elanmanager.utils.ElanL2GwCacheUtils; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwValidateCli.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwValidateCli.java index 189a4b7ae9..127d769819 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwValidateCli.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/L2GwValidateCli.java @@ -23,9 +23,9 @@ import java.util.Map; import java.util.Map.Entry; import java.util.Set; import java.util.stream.Collectors; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/NetworkL2gwDeviceInfoCli.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/NetworkL2gwDeviceInfoCli.java index 23f8989360..b8e6f2b1d8 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/NetworkL2gwDeviceInfoCli.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/cli/l2gw/NetworkL2gwDeviceInfoCli.java @@ -15,10 +15,10 @@ import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Set; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnMacVrfUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnMacVrfUtils.java index e3916b03e6..15c5b32213 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnMacVrfUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnMacVrfUtils.java @@ -13,9 +13,9 @@ import java.math.BigInteger; import java.util.ArrayList; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java index 5f5652ae28..417fc14279 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/evpn/utils/EvpnUtils.java @@ -23,9 +23,9 @@ import java.util.function.BiConsumer; import java.util.function.BiPredicate; import java.util.function.Function; import java.util.function.Predicate; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanBridgeManager.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanBridgeManager.java index 81e545bc9f..e064cba32f 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanBridgeManager.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanBridgeManager.java @@ -18,9 +18,9 @@ import java.util.List; import java.util.Map; import java.util.Optional; import java.util.Random; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanInterfaceManager.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanInterfaceManager.java index 1175c78a7c..da3670bb13 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanInterfaceManager.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanInterfaceManager.java @@ -30,7 +30,6 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentLinkedQueue; import java.util.concurrent.ExecutionException; import java.util.concurrent.locks.ReentrantLock; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; @@ -268,7 +267,7 @@ public class ElanInterfaceManager extends AsyncDataTreeChangeListenerBase { - @Nullable List elanInterfaces = elanState.getElanInterfaces(); + List elanInterfaces = elanState.getElanInterfaces(); if (elanInterfaces == null || elanInterfaces.isEmpty()) { holder.isLastElanInterface = true; } @@ -728,7 +727,7 @@ public class ElanInterfaceManager extends AsyncDataTreeChangeListenerBase existingInterfaces = existingElanDpnInterfaces.get().getInterfaces(); + List existingInterfaces = existingElanDpnInterfaces.get().getInterfaces(); List elanInterfaces = existingInterfaces != null ? new ArrayList<>(existingInterfaces) : new ArrayList<>(); elanInterfaces.add(interfaceName); @@ -744,7 +743,7 @@ public class ElanInterfaceManager extends AsyncDataTreeChangeListenerBase existingInterfaces = existingElanDpnInterfaces.get().getInterfaces(); + List existingInterfaces = existingElanDpnInterfaces.get().getInterfaces(); List elanInterfaces = existingInterfaces != null ? new ArrayList<>(existingInterfaces) : new ArrayList<>(); elanInterfaces.add(interfaceName); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanServiceProvider.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanServiceProvider.java index 9c161ab0fc..cbde09c7ea 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanServiceProvider.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/internal/ElanServiceProvider.java @@ -23,10 +23,10 @@ import java.util.Objects; import java.util.Set; import java.util.concurrent.Future; import java.util.function.BiFunction; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore; @@ -435,7 +435,7 @@ public class ElanServiceProvider extends AbstractLifecycle implements IElanServi } @Override - @Nonnull + @NonNull public List getElanInterfaces(String elanInstanceName) { List elanInterfaces = new ArrayList<>(); InstanceIdentifier elanInterfacesIdentifier = InstanceIdentifier.builder(ElanInterfaces.class) diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/HwvtepHAUtil.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/HwvtepHAUtil.java index ab86ae74fe..bc70c7e392 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/HwvtepHAUtil.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/HwvtepHAUtil.java @@ -20,7 +20,7 @@ import java.util.List; import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; import org.opendaylight.genius.infra.Datastore; import org.opendaylight.genius.infra.Datastore.Configuration; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/BaseCommand.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/BaseCommand.java index 74cee2f4ee..63b13a43ca 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/BaseCommand.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/BaseCommand.java @@ -10,8 +10,8 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.ArrayList; import java.util.Comparator; import java.util.List; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; public abstract class BaseCommand { @@ -54,7 +54,7 @@ public abstract class BaseCommand { * @param original Origina list to be compared with * @return List of diff based */ - @Nonnull + @NonNull public List diffOf(List updated, final List original) { if (updated == null) { return new ArrayList<>(); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalMcastCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalMcastCmd.java index 0ffecc6b13..23a7600881 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalMcastCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalMcastCmd.java @@ -10,7 +10,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.ArrayList; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalUcastCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalUcastCmd.java index 4aefc90907..d58ba26d15 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalUcastCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LocalUcastCmd.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LogicalSwitchesCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LogicalSwitchesCmd.java index f977830264..4bc536e19f 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LogicalSwitchesCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/LogicalSwitchesCmd.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/MergeCommand.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/MergeCommand.java index ddc2bfcad0..a15b431ac6 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/MergeCommand.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/MergeCommand.java @@ -16,8 +16,8 @@ import java.util.Comparator; import java.util.List; import java.util.Objects; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -56,7 +56,7 @@ public abstract class MergeCommand diffByKey(List updated, final List original) { if (updated == null) { return new ArrayList<>(); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/PhysicalLocatorCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/PhysicalLocatorCmd.java index e7234f8e08..48adb503dc 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/PhysicalLocatorCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/PhysicalLocatorCmd.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepPhysicalLocatorAugmentation; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.NodeBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteMcastCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteMcastCmd.java index 02c16e2aa7..cc5f5ce4b3 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteMcastCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteMcastCmd.java @@ -10,7 +10,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.ArrayList; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteUcastCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteUcastCmd.java index d8abdfe01d..cee6dc4697 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteUcastCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/RemoteUcastCmd.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/SwitchesCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/SwitchesCmd.java index 1b9670188f..61ad12cd4c 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/SwitchesCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/SwitchesCmd.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TerminationPointCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TerminationPointCmd.java index db1cf06eac..f0c249683a 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TerminationPointCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TerminationPointCmd.java @@ -11,7 +11,7 @@ import java.io.Serializable; import java.util.Comparator; import java.util.List; import java.util.stream.Collectors; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepPhysicalPortAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepPhysicalPortAugmentationBuilder; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelCmd.java index 2d7cfc2e20..9c701561e4 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelCmd.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepPhysicalLocatorRef; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.PhysicalSwitchAugmentation; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelIpCmd.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelIpCmd.java index e64c5a55fb..c1ffa3be00 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelIpCmd.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/ha/commands/TunnelIpCmd.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.elan.l2gw.ha.commands; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.PhysicalSwitchAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.PhysicalSwitchAugmentationBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.hwvtep.physical._switch.attributes.TunnelIps; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/jobs/DisAssociateHwvtepFromElanJob.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/jobs/DisAssociateHwvtepFromElanJob.java index cf6a4c7d06..4f2b5fe1d5 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/jobs/DisAssociateHwvtepFromElanJob.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/jobs/DisAssociateHwvtepFromElanJob.java @@ -11,7 +11,7 @@ import com.google.common.util.concurrent.ListenableFuture; import java.util.ArrayList; import java.util.List; import java.util.concurrent.Callable; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.elan.l2gw.ha.HwvtepHAUtil; import org.opendaylight.netvirt.elan.l2gw.utils.ElanL2GatewayMulticastUtils; import org.opendaylight.netvirt.elan.l2gw.utils.ElanL2GatewayUtils; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ChildListener.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ChildListener.java index 3a3e6b2968..b0e2b3d201 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ChildListener.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ChildListener.java @@ -11,8 +11,8 @@ import java.util.Collection; import java.util.HashMap; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; import org.opendaylight.controller.md.sal.binding.api.DataTreeChangeListener; @@ -205,8 +205,7 @@ public abstract class ChildListener

mod) { try { return mod.getModificationType(); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ElanGroupListener.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ElanGroupListener.java index f610b45ec7..7a98143a70 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ElanGroupListener.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/ElanGroupListener.java @@ -12,9 +12,9 @@ import static org.opendaylight.genius.infra.Datastore.CONFIGURATION; import java.math.BigInteger; import java.util.List; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/HwvtepPhysicalSwitchListener.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/HwvtepPhysicalSwitchListener.java index 525031420d..802ee837f6 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/HwvtepPhysicalSwitchListener.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/HwvtepPhysicalSwitchListener.java @@ -18,10 +18,10 @@ import java.util.Objects; import java.util.Set; import java.util.function.BiPredicate; import java.util.function.Predicate; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/LocalUcastMacListener.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/LocalUcastMacListener.java index 00a77653c9..e49a2f08ff 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/LocalUcastMacListener.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/listeners/LocalUcastMacListener.java @@ -17,10 +17,10 @@ import java.util.HashSet; import java.util.Map; import java.util.Set; import java.util.function.Predicate; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayMulticastUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayMulticastUtils.java index c258e8772e..c07ab0087a 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayMulticastUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayMulticastUtils.java @@ -19,10 +19,10 @@ import java.util.Arrays; import java.util.List; import java.util.Objects; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -314,7 +314,7 @@ public class ElanL2GatewayMulticastUtils { return listBucketInfo; } - @Nonnull + @NonNull public List getRemoteBCGroupBuckets(ElanInstance elanInfo, @Nullable DpnInterfaces dpnInterfaces, BigInteger dpnId, int bucketId, long elanTag) { List listBucketInfo = new ArrayList<>(); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayUtils.java index a6623cb378..3e4d17ad83 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/ElanL2GatewayUtils.java @@ -31,13 +31,13 @@ import java.util.concurrent.ScheduledFuture; import java.util.concurrent.TimeUnit; import java.util.function.Function; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.tuple.ImmutablePair; import org.apache.commons.lang3.tuple.Pair; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -1091,7 +1091,7 @@ public class ElanL2GatewayUtils { } } - @Nonnull + @NonNull public Collection getElanDpns(String elanName) { Collection dpnInterfaces = elanInstanceDpnsCache.get(elanName); if (!dpnInterfaces.isEmpty()) { diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/L2GatewayConnectionUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/L2GatewayConnectionUtils.java index cea2408db0..a96358f6b7 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/L2GatewayConnectionUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/l2gw/utils/L2GatewayConnectionUtils.java @@ -21,11 +21,11 @@ import java.util.List; import java.util.Objects; import java.util.Set; import java.util.concurrent.CopyOnWriteArrayList; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; @@ -118,14 +118,14 @@ public class L2GatewayConnectionUtils implements AutoCloseable { return MDSALUtil.read(broker, LogicalDatastoreType.CONFIGURATION, inst).orNull(); } - @Nonnull + @NonNull public static List getL2gatewayList(DataBroker broker) { InstanceIdentifier inst = InstanceIdentifier.create(Neutron.class).child(L2gateways.class); return MDSALUtil.read(broker, LogicalDatastoreType.CONFIGURATION, inst).toJavaUtil().map( L2gateways::getL2gateway).orElse(emptyList()); } - @Nonnull + @NonNull public static List getAllL2gatewayConnections(DataBroker broker) { InstanceIdentifier inst = InstanceIdentifier.create(Neutron.class) .child(L2gatewayConnections.class); @@ -142,7 +142,7 @@ public class L2GatewayConnectionUtils implements AutoCloseable { * the l2 gateway ids * @return the associated l2 gw connections */ - @Nonnull + @NonNull public static List getAssociatedL2GwConnections(DataBroker broker, Set l2GatewayIds) { List allL2GwConns = getAllL2gatewayConnections(broker); List l2GwConnections = new ArrayList<>(); @@ -165,7 +165,7 @@ public class L2GatewayConnectionUtils implements AutoCloseable { * the elan Name * @return the associated l2 gw connection with elan */ - @Nonnull + @NonNull public static List getL2GwConnectionsByElanName(DataBroker broker, String elanName) { List allL2GwConns = getAllL2gatewayConnections(broker); List elanL2GateWayConnections = new ArrayList<>(); @@ -365,7 +365,7 @@ public class L2GatewayConnectionUtils implements AutoCloseable { return l2GwDevice != null && l2GwDevice.getHwvtepNodeId() != null; } - protected static boolean isLastL2GwConnBeingDeleted(@Nonnull L2GatewayDevice l2GwDevice) { + protected static boolean isLastL2GwConnBeingDeleted(@NonNull L2GatewayDevice l2GwDevice) { return l2GwDevice.getL2GatewayIds().size() == 1; } @@ -377,7 +377,7 @@ public class L2GatewayConnectionUtils implements AutoCloseable { Futures.addCallback(broker.newReadOnlyTransaction().read(LogicalDatastoreType.OPERATIONAL, nodeIid), new SettableFutureCallback>(settableFuture) { @Override - public void onSuccess(@Nonnull Optional resultNode) { + public void onSuccess(@NonNull Optional resultNode) { LocalUcastMacListener localUcastMacListener = new LocalUcastMacListener(broker, haOpClusteredListener, elanL2GatewayUtils, jobCoordinator, elanInstanceCache, hwvtepNodeHACache); diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/statisitcs/ElanStatisticsImpl.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/statisitcs/ElanStatisticsImpl.java index d23c7c8696..2a5c170377 100755 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/statisitcs/ElanStatisticsImpl.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/statisitcs/ElanStatisticsImpl.java @@ -10,9 +10,9 @@ package org.opendaylight.netvirt.elan.statisitcs; import com.google.common.base.Optional; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.interfacemanager.globals.InterfaceInfo; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; import org.opendaylight.netvirt.elan.cache.ElanInterfaceCache; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanDmacUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanDmacUtils.java index 60c264b477..cde7d86394 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanDmacUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanDmacUtils.java @@ -15,9 +15,9 @@ import java.math.BigInteger; import java.util.ArrayList; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.mdsalutil.MDSALUtil; import org.opendaylight.genius.mdsalutil.MatchInfo; import org.opendaylight.genius.mdsalutil.NwConstants; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanEtreeUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanEtreeUtils.java index 33c6da0256..46540b9237 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanEtreeUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanEtreeUtils.java @@ -8,9 +8,9 @@ package org.opendaylight.netvirt.elan.utils; import com.google.common.base.Optional; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.etree.rev160614.EtreeLeafTagName; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanItmUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanItmUtils.java index defc7821d1..bcca8a628b 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanItmUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanItmUtils.java @@ -12,9 +12,9 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; import org.opendaylight.netvirt.elan.l2gw.utils.ElanL2GatewayUtils; diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java index c3ca78d193..7b58c2cde7 100755 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/ElanUtils.java @@ -30,11 +30,11 @@ import java.util.Objects; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import javax.annotation.CheckReturnValue; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.StringUtils; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; @@ -285,7 +285,7 @@ public class ElanUtils { */ @Deprecated @SuppressWarnings("checkstyle:IllegalCatch") - public static Optional read(@Nonnull DataBroker broker, + public static Optional read(@NonNull DataBroker broker, LogicalDatastoreType datastoreType, InstanceIdentifier path) { try (ReadOnlyTransaction tx = broker.newReadOnlyTransaction()) { return tx.read(datastoreType, path).get(); @@ -488,7 +488,7 @@ public class ElanUtils { * the elan instance name * @return list of dpIds */ - @Nonnull + @NonNull public List getParticipatingDpnsInElanInstance(String elanInstanceName) { List dpIds = new ArrayList<>(); InstanceIdentifier elanDpnInterfaceId = getElanDpnOperationDataPath(elanInstanceName); @@ -730,7 +730,7 @@ public class ElanUtils { * @return the egress actions for interface */ @SuppressWarnings("checkstyle:IllegalCatch") - @Nonnull + @NonNull public List getEgressActionsForInterface(String ifName, @Nullable Long tunnelKey) { List listAction = new ArrayList<>(); try { @@ -798,12 +798,12 @@ public class ElanUtils { // TODO: Make sure that the same is performed against the ElanDevices. } - @Nonnull + @NonNull public List getInvolvedDpnsInElan(String elanName) { return getElanDPNByName(elanName); } - @Nonnull + @NonNull public List getElanDPNByName(String elanInstanceName) { InstanceIdentifier elanIdentifier = getElanDpnOperationDataPath(elanInstanceName); return MDSALUtil.read(broker, LogicalDatastoreType.OPERATIONAL, elanIdentifier).toJavaUtil().map( @@ -1302,14 +1302,10 @@ public class ElanUtils { * the data broker * @return the interface state from oper ds */ - @Nullable - public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang - .ietf.interfaces.rev140508.interfaces.state.Interface getInterfaceStateFromOperDS( - String interfaceName, DataBroker dataBroker) { - InstanceIdentifier ifStateId = createInterfaceStateInstanceIdentifier( - interfaceName); - return MDSALUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, ifStateId).orNull(); + public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state + .@Nullable Interface getInterfaceStateFromOperDS(String interfaceName, DataBroker dataBroker) { + return MDSALUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, + createInterfaceStateInstanceIdentifier(interfaceName)).orNull(); } /** diff --git a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/TransportZoneNotificationUtil.java b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/TransportZoneNotificationUtil.java index 5a1931e51d..651b04fbca 100644 --- a/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/TransportZoneNotificationUtil.java +++ b/elanmanager/impl/src/main/java/org/opendaylight/netvirt/elan/utils/TransportZoneNotificationUtil.java @@ -24,10 +24,10 @@ import java.util.Objects; import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -138,7 +138,7 @@ public class TransportZoneNotificationUtil { } private void updateTransportZone(TransportZone zone, BigInteger dpnId, - @Nonnull TypedWriteTransaction tx) { + @NonNull TypedWriteTransaction tx) { InstanceIdentifier path = InstanceIdentifier.builder(TransportZones.class) .child(TransportZone.class, new TransportZoneKey(zone.getZoneName())).build(); @@ -166,7 +166,7 @@ public class TransportZoneNotificationUtil { @SuppressWarnings("checkstyle:IllegalCatch") private void updateTransportZone(String zoneName, BigInteger dpnId, @Nullable String localIp, - @Nonnull TypedReadWriteTransaction tx) + @NonNull TypedReadWriteTransaction tx) throws ExecutionException, InterruptedException { InstanceIdentifier inst = InstanceIdentifier.create(TransportZones.class) .child(TransportZone.class, new TransportZoneKey(zoneName)); @@ -188,7 +188,7 @@ public class TransportZoneNotificationUtil { } private void deleteTransportZone(TransportZone zone, BigInteger dpnId, - @Nonnull TypedWriteTransaction tx) { + @NonNull TypedWriteTransaction tx) { InstanceIdentifier path = InstanceIdentifier.builder(TransportZones.class) .child(TransportZone.class, new TransportZoneKey(zone.getZoneName())).build(); tx.delete(path); @@ -213,7 +213,7 @@ public class TransportZoneNotificationUtil { @SuppressWarnings("checkstyle:IllegalCatch") private void deleteTransportZone(String zoneName, BigInteger dpnId, - @Nonnull TypedReadWriteTransaction tx) throws ExecutionException, InterruptedException { + @NonNull TypedReadWriteTransaction tx) throws ExecutionException, InterruptedException { InstanceIdentifier inst = InstanceIdentifier.create(TransportZones.class) .child(TransportZone.class, new TransportZoneKey(zoneName)); @@ -311,7 +311,7 @@ public class TransportZoneNotificationUtil { private void handleChangedLocalIps(Map> changedEntries, BigInteger dpId, Set zonePrefixes, Map> tepTzMap, - @Nonnull TypedReadWriteTransaction tx) throws ExecutionException, InterruptedException { + @NonNull TypedReadWriteTransaction tx) throws ExecutionException, InterruptedException { if (changedEntries == null || changedEntries.isEmpty()) { LOG.trace("No changed local_ips found for DPN {}", dpId); return; @@ -340,7 +340,7 @@ public class TransportZoneNotificationUtil { } private void handleRemovedLocalIps(Map removedEntries, BigInteger dpId, Set zonePrefixes, - Map> tepTzMap, @Nonnull TypedWriteTransaction tx) { + Map> tepTzMap, @NonNull TypedWriteTransaction tx) { if (removedEntries == null || removedEntries.isEmpty()) { LOG.trace("No removed local_ips found on DPN {}", dpId); return; @@ -412,7 +412,7 @@ public class TransportZoneNotificationUtil { return false; } - private void removeVtep(String zoneName, BigInteger dpId, @Nonnull TypedWriteTransaction tx) { + private void removeVtep(String zoneName, BigInteger dpId, @NonNull TypedWriteTransaction tx) { InstanceIdentifier path = InstanceIdentifier.builder(TransportZones.class) .child(TransportZone.class, new TransportZoneKey(zoneName)) .child(Subnets.class, new SubnetsKey(IpPrefixBuilder.getDefaultInstance(ALL_SUBNETS))) @@ -422,7 +422,7 @@ public class TransportZoneNotificationUtil { // search for relevant subnets for the given subnetIP, add one if it is // necessary - private Subnets getOrAddSubnet(@Nonnull List subnets, @Nonnull String subnetIp) { + private Subnets getOrAddSubnet(@NonNull List subnets, @NonNull String subnetIp) { IpPrefix subnetPrefix = IpPrefixBuilder.getDefaultInstance(subnetIp); for (Subnets subnet : subnets) { @@ -462,7 +462,7 @@ public class TransportZoneNotificationUtil { return null; } - @Nonnull + @NonNull private Map getDpnLocalIps(BigInteger dpId) throws ReadFailedException { // Example of local IPs from other_config: // local_ips="10.0.43.159:MPLS,11.11.11.11:DSL,ip:underlay-network" diff --git a/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/FibHelper.java b/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/FibHelper.java index 383c2e6798..7b85a6804d 100644 --- a/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/FibHelper.java +++ b/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/FibHelper.java @@ -19,7 +19,7 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/IFibManager.java b/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/IFibManager.java index de3e372481..d2f7200559 100644 --- a/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/IFibManager.java +++ b/fibmanager/api/src/main/java/org/opendaylight/netvirt/fibmanager/api/IFibManager.java @@ -13,7 +13,7 @@ import com.google.common.util.concurrent.FutureCallback; import java.math.BigInteger; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.TypedWriteTransaction; diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java index afe659fff5..af5beaf715 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BaseVrfEntryHandler.java @@ -20,10 +20,10 @@ import java.time.temporal.ChronoUnit; import java.util.ArrayList; import java.util.Collections; import java.util.List; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -155,7 +155,7 @@ public class BaseVrfEntryHandler implements AutoCloseable { } } - @Nonnull + @NonNull protected List resolveAdjacency(final BigInteger remoteDpnId, final long vpnId, final VrfEntry vrfEntry, String rd) { List routePaths = new ArrayList<>(vrfEntry.nonnullRoutePaths()); diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BgpRouteVrfEntryHandler.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BgpRouteVrfEntryHandler.java index f96e72803a..26301a66d3 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BgpRouteVrfEntryHandler.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/BgpRouteVrfEntryHandler.java @@ -17,10 +17,10 @@ import java.util.List; import java.util.concurrent.BlockingQueue; import java.util.concurrent.LinkedBlockingQueue; import java.util.function.Consumer; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibRpcServiceImpl.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibRpcServiceImpl.java index e3ad6413a1..35c1631727 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibRpcServiceImpl.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibRpcServiceImpl.java @@ -16,10 +16,10 @@ import java.net.InetAddress; import java.net.UnknownHostException; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.tuple.ImmutablePair; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibUtil.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibUtil.java index c870d7592a..04dde4558a 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibUtil.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/FibUtil.java @@ -24,9 +24,9 @@ import java.util.Objects; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.ReentrantLock; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -571,9 +571,8 @@ public class FibUtil { return id; } - @Nullable - public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces - .state.Interface getInterfaceStateFromOperDS(String interfaceName) { + public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state + .@Nullable Interface getInterfaceStateFromOperDS(String interfaceName) { InstanceIdentifier ifStateId = buildStateInterfaceId(interfaceName); Optional ifStateOptional = MDSALUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, ifStateId); diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/NexthopManager.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/NexthopManager.java index 25a1ee398b..e7da0697aa 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/NexthopManager.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/NexthopManager.java @@ -24,10 +24,10 @@ import java.util.Objects; import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/VrfEntryListener.java b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/VrfEntryListener.java index 540e06aaf5..2c25f72cf8 100644 --- a/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/VrfEntryListener.java +++ b/fibmanager/impl/src/main/java/org/opendaylight/netvirt/fibmanager/VrfEntryListener.java @@ -33,11 +33,11 @@ import java.util.concurrent.Callable; import java.util.concurrent.CopyOnWriteArrayList; import java.util.concurrent.ExecutionException; import java.util.concurrent.locks.ReentrantLock; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; diff --git a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ConfTransportL3VPNCommand.java b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ConfTransportL3VPNCommand.java index 17c993e642..21a2b7f1d6 100644 --- a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ConfTransportL3VPNCommand.java +++ b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ConfTransportL3VPNCommand.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.fibmanager.shell; import java.util.Locale; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.fibmanager.api.IFibManager; import org.opendaylight.netvirt.fibmanager.api.L3VPNTransportTypes; diff --git a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowFibCommand.java b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowFibCommand.java index 87b02946af..a8ed8d0159 100644 --- a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowFibCommand.java +++ b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowFibCommand.java @@ -15,11 +15,11 @@ import java.net.InetAddress; import java.net.UnknownHostException; import java.util.List; import java.util.Locale; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowTransportTypeCommand.java b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowTransportTypeCommand.java index 52d0b28ed4..8cbc1b072a 100644 --- a/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowTransportTypeCommand.java +++ b/fibmanager/shell/src/main/java/org/opendaylight/netvirt/fibmanager/shell/ShowTransportTypeCommand.java @@ -7,9 +7,9 @@ */ package org.opendaylight.netvirt.fibmanager.shell; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.fibmanager.api.IFibManager; @Command(scope = "vpnservice", name = "showTransportType", description = "Displays transport type in use for services") diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java index e8584cd78e..b4457aa8e2 100644 --- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java +++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java @@ -25,10 +25,10 @@ import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.ipv6util.api.Ipv6Constants.Ipv6RouterAdvertisementType; import org.opendaylight.genius.ipv6util.api.Ipv6Util; @@ -860,7 +860,6 @@ public class IfMgr implements ElementCache, AutoCloseable { return elanTag; } - @Nullable public void updateNetworkMtuInfo(Uuid networkId, int mtu) { VirtualNetwork net = getNetwork(networkId); if (null != net) { diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6RouterAdvt.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6RouterAdvt.java index 6518d3eca6..19cb514c29 100644 --- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6RouterAdvt.java +++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6RouterAdvt.java @@ -15,7 +15,7 @@ import java.nio.ByteBuffer; import java.util.ArrayList; import java.util.Arrays; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.ipv6util.api.Icmpv6Type; import org.opendaylight.genius.ipv6util.api.Ipv6Constants; import org.opendaylight.genius.ipv6util.api.Ipv6Constants.Ipv6RouterAdvertisementType; diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronPortChangeListener.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronPortChangeListener.java index 66a09afd1f..8f241eaae3 100644 --- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronPortChangeListener.java +++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronPortChangeListener.java @@ -12,10 +12,10 @@ import java.util.Collections; import java.util.HashSet; import java.util.List; import java.util.Set; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase; diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualNetwork.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualNetwork.java index b75d1416a4..cceff6b3bb 100644 --- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualNetwork.java +++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualNetwork.java @@ -15,7 +15,7 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; import java.util.stream.Collectors; import java.util.stream.Stream; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.ipv6util.api.Ipv6Util; import org.opendaylight.netvirt.ipv6service.api.IVirtualNetwork; import org.opendaylight.netvirt.ipv6service.utils.Ipv6ServiceConstants; diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/utils/Ipv6ServiceUtils.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/utils/Ipv6ServiceUtils.java index 504fb74d83..17049240d7 100644 --- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/utils/Ipv6ServiceUtils.java +++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/utils/Ipv6ServiceUtils.java @@ -16,10 +16,10 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.StringUtils; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -126,9 +126,8 @@ public class Ipv6ServiceUtils { * @param interfaceName the interface name * @return the interface. */ - @Nullable public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces - .Interface getInterface(String interfaceName) { + .@Nullable Interface getInterface(String interfaceName) { return read(LogicalDatastoreType.CONFIGURATION, getInterfaceIdentifier(interfaceName)).orNull(); } @@ -166,9 +165,8 @@ public class Ipv6ServiceUtils { * @param interfaceName the interface name. * @return the interface state. */ - @Nullable public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state - .Interface getInterfaceStateFromOperDS(String interfaceName) { + .@Nullable Interface getInterfaceStateFromOperDS(String interfaceName) { return MDSALUtil.read(LogicalDatastoreType.OPERATIONAL, buildStateInterfaceId(interfaceName), broker).orNull(); } diff --git a/ipv6service/shell/src/main/java/org/opendaylight/netvirt/ipv6service/shell/ShowIpv6Command.java b/ipv6service/shell/src/main/java/org/opendaylight/netvirt/ipv6service/shell/ShowIpv6Command.java index 27c5c6547d..7955fc4411 100644 --- a/ipv6service/shell/src/main/java/org/opendaylight/netvirt/ipv6service/shell/ShowIpv6Command.java +++ b/ipv6service/shell/src/main/java/org/opendaylight/netvirt/ipv6service/shell/ShowIpv6Command.java @@ -9,10 +9,10 @@ package org.opendaylight.netvirt.ipv6service.shell; import java.util.List; import java.util.stream.Collectors; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.infrautils.utils.TablePrinter; import org.opendaylight.netvirt.ipv6service.api.ElementCache; import org.opendaylight.netvirt.ipv6service.api.IVirtualNetwork; diff --git a/natservice/api/src/main/java/org/opendaylight/netvirt/natservice/api/SnatServiceManager.java b/natservice/api/src/main/java/org/opendaylight/netvirt/natservice/api/SnatServiceManager.java index e49b758b54..9e1a2d5c47 100644 --- a/natservice/api/src/main/java/org/opendaylight/netvirt/natservice/api/SnatServiceManager.java +++ b/natservice/api/src/main/java/org/opendaylight/netvirt/natservice/api/SnatServiceManager.java @@ -10,7 +10,7 @@ package org.opendaylight.netvirt.natservice.api; import java.math.BigInteger; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.TypedReadWriteTransaction; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ext.routers.Routers; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java index 53734cbef0..8f8fd389cd 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java @@ -11,10 +11,10 @@ package org.opendaylight.netvirt.natservice.cli; import com.google.common.base.Optional; import java.io.PrintStream; import java.math.BigInteger; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -101,7 +101,7 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { return null; } - @Nonnull + @NonNull private Optional readOvsdbNode(Node bridgeNode) { OvsdbBridgeAugmentation bridgeAugmentation = extractBridgeAugmentation(bridgeNode); if (bridgeAugmentation != null) { diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/ha/WeightedCentralizedSwitchScheduler.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/ha/WeightedCentralizedSwitchScheduler.java index d0db56e018..fdd3b15d90 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/ha/WeightedCentralizedSwitchScheduler.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/ha/WeightedCentralizedSwitchScheduler.java @@ -21,9 +21,9 @@ import java.util.Map; import java.util.Map.Entry; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnDnatFlowProgrammer.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnDnatFlowProgrammer.java index fff7562752..d20bb6c65f 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnDnatFlowProgrammer.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnDnatFlowProgrammer.java @@ -22,9 +22,9 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -176,13 +176,13 @@ public class EvpnDnatFlowProgrammer { Futures.addCallback(futureVxlan, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("onAddFloatingIp : Error {} in custom fib routes install process for Floating " + "IP Prefix {} on DPN {}", error, externalIp, dpnId); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { ListenableFutures.addErrorLogging( txRunner.callWithNewReadWriteTransactionAndSubmit(CONFIGURATION, innerConfTx -> { @@ -308,13 +308,13 @@ public class EvpnDnatFlowProgrammer { Futures.addCallback(futureVxlan, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("onRemoveFloatingIp : Error {} in custom fib routes remove process for Floating " + "IP Prefix {} on DPN {}", error, externalIp, dpnId); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { ListenableFutures.addErrorLogging(txRunner.callWithNewReadWriteTransactionAndSubmit(CONFIGURATION, innerConfTx -> { diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnSnatFlowProgrammer.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnSnatFlowProgrammer.java index 6947547994..946018f45e 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnSnatFlowProgrammer.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/EvpnSnatFlowProgrammer.java @@ -18,9 +18,9 @@ import java.math.BigInteger; import java.util.ArrayList; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.ManagedNewTransactionRunner; @@ -149,14 +149,14 @@ public class EvpnSnatFlowProgrammer { final long finalL3Vni = l3Vni; Futures.addCallback(futureVxlan, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("evpnAdvToBgpAndInstallFibAndTsFlows : Error in custom fib routes install process for " + "External Fixed IP {} on DPN {} with l3Vni {}, ExternalVpnName {} for RouterId {}", externalIp, dpnId, finalL3Vni, vpnName, routerId, error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("evpnAdvToBgpAndInstallFibAndTsFlows : Successfully installed custom FIB routes for " + "External Fixed IP {} on DPN {} with l3Vni {}, ExternalVpnName {} for RouterId {}", @@ -234,14 +234,14 @@ public class EvpnSnatFlowProgrammer { final long finalL3Vni = l3Vni; Futures.addCallback(futureVxlan, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("evpnDelFibTsAndReverseTraffic : Error in custom fib routes remove process for " + "External Fixed IP {} on DPN {} with l3Vni {}, ExternalVpnName {} for RouterId {}", externalIp, dpnId, finalL3Vni, vpnName, routerId, error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { ListenableFutures.addErrorLogging(txRunner.callWithNewReadWriteTransactionAndSubmit(CONFIGURATION, innerConfTx -> { diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java index f2f4521758..935dac9fb0 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalNetworkGroupInstaller.java @@ -9,16 +9,15 @@ package org.opendaylight.netvirt.natservice.internal; import com.google.common.base.Strings; - import java.math.BigInteger; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; import org.opendaylight.genius.mdsalutil.ActionInfo; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java index 09e5c4a685..8b5e1d5770 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java @@ -31,11 +31,11 @@ import java.util.Objects; import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -1164,12 +1164,12 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("advToBgpAndInstallFibAndTsFlows : Error in generate label or fib install process", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("advToBgpAndInstallFibAndTsFlows : Successfully installed custom FIB routes for prefix {}", externalIp); @@ -1777,7 +1777,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase externalIps, + public void handleDisableSnat(Routers router, Uuid networkUuid, @NonNull Collection externalIps, boolean routerFlag, @Nullable String vpnName, BigInteger naptSwitchDpnId, long routerId, TypedReadWriteTransaction removeFlowInvTx) { LOG.info("handleDisableSnat : Entry"); @@ -1836,7 +1836,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase externalIps, + @NonNull Collection externalIps, String vpnId, TypedReadWriteTransaction writeFlowInvTx) { LOG.debug("handleDisableSnatInternetVpn: Started to process handle disable snat for router {} " + "with internet vpn {}", routerName, vpnId); @@ -1913,7 +1913,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase externalIps, + @NonNull Collection externalIps, Collection externalSubnetList, TypedReadWriteTransaction confTx, ProviderTypes extNwProvType) @@ -2082,7 +2082,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase externalIps, + @NonNull Collection externalIps, TypedReadWriteTransaction writeFlowInvTx) throws ExecutionException, InterruptedException { long extVpnId = NatConstants.INVALID_ID; @@ -2245,7 +2245,7 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase externalIps, @Nullable String vpnName, + @NonNull Collection externalIps, @Nullable String vpnName, String extGwMacAddress, TypedReadWriteTransaction confTx) throws ExecutionException, InterruptedException { //Withdraw the corresponding routes from the BGP. @@ -2366,13 +2366,13 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("delFibTsAndReverseTraffic : Error in removing the label:{} or custom fib entries" + "got external ip {}", label, extIp, error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.debug("delFibTsAndReverseTraffic : Successfully removed the label for the prefix {} " + "from VPN {}", externalIp, externalVpn); @@ -2471,12 +2471,12 @@ public class ExternalRoutersListener extends AsyncDataTreeChangeListenerBase>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("delFibTsAndReverseTraffic : Error in removing the label or custom fib entries", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.debug("delFibTsAndReverseTraffic : Successfully removed the label for the prefix {} " + "from VPN {}", externalIp, vpnName); diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/FloatingIPListener.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/FloatingIPListener.java index a5b1313a74..c6582ea374 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/FloatingIPListener.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/FloatingIPListener.java @@ -17,10 +17,10 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTEntryEvent.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTEntryEvent.java index aec9236315..f7b6b16b93 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTEntryEvent.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTEntryEvent.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.natservice.internal; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.natservice.internal.NaptPacketInHandler.NatPacketProcessingState; import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceived; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTSwitchSelector.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTSwitchSelector.java index f703b8e467..13663d2839 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTSwitchSelector.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NAPTSwitchSelector.java @@ -14,9 +14,9 @@ import java.util.List; import java.util.Map; import java.util.Set; import java.util.TreeSet; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; @@ -113,7 +113,7 @@ public class NAPTSwitchSelector { .child(RouterToNaptSwitch.class, new RouterToNaptSwitchKey(routerName)).build(); } - @Nonnull + @NonNull public List getDpnsForVpn(String routerName) { LOG.debug("getDpnsForVpn: called for RouterName {}", routerName); long bgpVpnId = NatUtil.getBgpVpnId(dataBroker, routerName); @@ -176,7 +176,7 @@ public class NAPTSwitchSelector { } @Override - public int compareTo(@Nonnull SwitchWeight switchWeight) { + public int compareTo(@NonNull SwitchWeight switchWeight) { return weight - switchWeight.getWeight(); } } diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptEventHandler.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptEventHandler.java index df13e84e9d..4221530431 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptEventHandler.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptEventHandler.java @@ -22,10 +22,10 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.sal.common.util.Arguments; import org.opendaylight.genius.interfacemanager.globals.InterfaceInfo; @@ -292,7 +292,7 @@ public class NaptEventHandler { } @Override - public void onFailure(@Nonnull Throwable throwable) { + public void onFailure(@NonNull Throwable throwable) { LOG.error("handleEvent : Error configuring outbound " + "SNAT flows using RPC for SNAT connection from {} to {}", internalAddress, externalAddress); @@ -301,7 +301,7 @@ public class NaptEventHandler { } @Override - public void onFailure(@Nonnull Throwable throwable) { + public void onFailure(@NonNull Throwable throwable) { LOG.error("handleEvent : Error configuring inbound SNAT flows " + "using RPC for SNAT connection from {} to {}", internalAddress, externalAddress); @@ -576,7 +576,7 @@ public class NaptEventHandler { return matchInfo; } - @Nonnull + @NonNull private static List buildAndGetSetActionInstructionInfo(String ipAddress, int port, long segmentId, long vpnId, short tableId, diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptManager.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptManager.java index 95b6fa6580..4c18c9a6fd 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptManager.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptManager.java @@ -21,12 +21,12 @@ import java.util.Objects; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.ReentrantLock; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.net.util.SubnetUtils; import org.apache.commons.net.util.SubnetUtils.SubnetInfo; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -506,7 +506,7 @@ public class NaptManager { .child(ExternalIpCounter.class, new ExternalIpCounterKey(external)).build(); } - @Nonnull + @NonNull public static List getIpMapList(DataBroker broker, Long routerId) { InstanceIdentifier id = getIpMapList(routerId); return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(broker, diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptSwitchHA.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptSwitchHA.java index 862df7d867..4dce44ee4f 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptSwitchHA.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NaptSwitchHA.java @@ -18,10 +18,10 @@ import java.util.Map.Entry; import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -360,7 +360,7 @@ public class NaptSwitchHA { } } - @Nonnull + @NonNull private List getRouterIdsForExtNetwork(Uuid extNetworkId) { List routerUuidsAsString = new ArrayList<>(); InstanceIdentifier extNetwork = InstanceIdentifier.builder(ExternalNetworks.class) @@ -695,7 +695,7 @@ public class NaptSwitchHA { return listBucketInfo; } - @Nonnull + @NonNull public List handleGroupInNeighborSwitches(BigInteger dpnId, String routerName, long routerId, BigInteger naptSwitch) { List listBucketInfo = new ArrayList<>(); diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatEvpnUtil.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatEvpnUtil.java index 40ba8fdca5..c52aef63bb 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatEvpnUtil.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatEvpnUtil.java @@ -14,7 +14,7 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatSouthboundEventHandlers.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatSouthboundEventHandlers.java index 64cfe3f592..6bcc99185b 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatSouthboundEventHandlers.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatSouthboundEventHandlers.java @@ -24,10 +24,10 @@ import java.util.concurrent.Callable; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.ReentrantLock; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -310,7 +310,7 @@ public class NatSouthboundEventHandlers { }, MoreExecutors.directExecutor()); } - @Nonnull + @NonNull private List getIntExtPortMapListForPortName(String portName, String routerId) { InstanceIdentifier portToIpMapIdentifier = NatUtil.buildPortToIpMapIdentifier(routerId, portName); Optional port = diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatTunnelInterfaceStateListener.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatTunnelInterfaceStateListener.java index b01a0122b7..b16246c721 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatTunnelInterfaceStateListener.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatTunnelInterfaceStateListener.java @@ -22,10 +22,10 @@ import java.util.Collection; import java.util.List; import java.util.Map; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; @@ -787,13 +787,13 @@ public class NatTunnelInterfaceStateListener Futures.addCallback(listenableFuture, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("hndlTepAddOnNaptSwitch : SNAT->Error in generate label or fib install process", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("hndlTepAddOnNaptSwitch : SNAT -> Successfully installed custom FIB routes " + "for prefix {}", externalIp); @@ -919,13 +919,13 @@ public class NatTunnelInterfaceStateListener Futures.addCallback(listenableFuture, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("hndlTepAddForDnatInEachRtr : DNAT -> Error in generate label or fib install process", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("hndlTepAddForDnatInEachRtr : DNAT -> Successfully installed custom FIB routes " + "for prefix {}", externalIp); @@ -1127,13 +1127,13 @@ public class NatTunnelInterfaceStateListener Futures.addCallback(listenableFuture, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("hndlTepDelForDnatInEachRtr : DNAT -> Error in removing the table 21 entry pushing " + "the MPLS label to the tunnel since label is invalid ", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("hndlTepDelForDnatInEachRtr : DNAT -> Successfully removed the entry pushing the " + "MPLS label to the tunnel"); diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java index 6c81d01977..03394c9a4f 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/NatUtil.java @@ -33,9 +33,9 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.ReentrantLock; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import org.apache.commons.net.util.SubnetUtils; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -492,7 +492,7 @@ public final class NatUtil { } } - @Nonnull + @NonNull public static List getRouterIdsfromNetworkId(DataBroker broker, Uuid networkId) { InstanceIdentifier id = buildNetworkIdentifier(networkId); return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(broker, @@ -863,7 +863,7 @@ public final class NatUtil { return routerInstanceIndentifier; } - @Nonnull + @NonNull public static List getInternalIpPortListInfo(DataBroker dataBroker, Long routerId, String internalIpAddress, ProtocolTypes protocolType) { return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(dataBroker, @@ -970,7 +970,7 @@ public final class NatUtil { .build(); } - @Nonnull + @NonNull public static Collection getExternalIpsForRouter(DataBroker dataBroker, Long routerId) { Optional ipMappingOptional = @@ -986,7 +986,7 @@ public final class NatUtil { return externalIps; } - @Nonnull + @NonNull public static List getExternalIpsForRouter(DataBroker dataBroker, String routerName) { Routers routerData = NatUtil.getRoutersFromConfigDS(dataBroker, routerName); if (routerData != null) { @@ -996,7 +996,7 @@ public final class NatUtil { return emptyList(); } - @Nonnull + @NonNull public static Map getExternalIpsLabelForRouter(DataBroker dataBroker, Long routerId) { Optional ipMappingOptional = @@ -1045,7 +1045,7 @@ public final class NatUtil { return null; } - @Nonnull + @NonNull public static String[] getSubnetIpAndPrefix(String subnetString) { String[] subnetSplit = subnetString.split("/"); String subnetIp = subnetSplit[0]; @@ -1076,7 +1076,7 @@ public final class NatUtil { return new String[] {leastLoadedExtIp, leastLoadedExtIpPrefix}; } - @Nonnull + @NonNull public static List getDpnsForRouter(DataBroker dataBroker, String routerUuid) { InstanceIdentifier id = InstanceIdentifier.builder(NeutronRouterDpns.class) .child(RouterDpnList.class, new RouterDpnListKey(routerUuid)).build(); @@ -1101,9 +1101,8 @@ public final class NatUtil { return bgpVpnId; } - @Nullable static org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.router.interfaces - .RouterInterface getConfiguredRouterInterface(DataBroker broker, String interfaceName) { + .@Nullable RouterInterface getConfiguredRouterInterface(DataBroker broker, String interfaceName) { return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(broker, LogicalDatastoreType.CONFIGURATION, NatUtil.getRouterInterfaceId(interfaceName)).orNull(); } @@ -1217,7 +1216,7 @@ public final class NatUtil { } public static void removeFromNeutronRouterDpnsMap(String routerName, String vpnInterfaceName, - BigInteger dpId, @Nonnull TypedReadWriteTransaction operTx) { + BigInteger dpId, @NonNull TypedReadWriteTransaction operTx) { InstanceIdentifier routerDpnListIdentifier = getRouterDpnId(routerName, dpId); Optional optionalRouterDpnList; try { @@ -1370,7 +1369,7 @@ public final class NatUtil { return nodeId; } - @Nonnull + @NonNull public static List getEgressActionsForInterface(OdlInterfaceRpcService odlInterfaceRpcService, ItmRpcService itmRpcService, IInterfaceManager interfaceManager, String ifName, @@ -1379,7 +1378,7 @@ public final class NatUtil { ifName, tunnelKey, 0, internalTunnelInterface); } - @Nonnull + @NonNull public static List getEgressActionsForInterface(OdlInterfaceRpcService odlInterfaceRpcService, ItmRpcService itmRpcService, IInterfaceManager interfaceManager, @@ -1454,7 +1453,7 @@ public final class NatUtil { return getNeutronPortForIp(broker, targetIP, NeutronConstants.DEVICE_OWNER_GATEWAY_INF); } - @Nonnull + @NonNull public static List getNeutronPorts(DataBroker broker) { InstanceIdentifier portsIdentifier = InstanceIdentifier.create(Neutron.class) @@ -1513,7 +1512,7 @@ public final class NatUtil { LogicalDatastoreType.CONFIGURATION, subnetmapId).orNull(); } - @Nonnull + @NonNull public static List getSubnetIdsFromNetworkId(DataBroker broker, Uuid networkId) { InstanceIdentifier id = InstanceIdentifier.builder(NetworkMaps.class) .child(NetworkMap.class, new NetworkMapKey(networkId)).build(); @@ -1754,7 +1753,7 @@ public final class NatUtil { null); } - @Nonnull + @NonNull public static List getFloatingIpPortsForRouter(DataBroker broker, Uuid routerUuid) { InstanceIdentifier routerPortsIdentifier = getRouterPortsId(routerUuid.getValue()); return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(broker, @@ -1762,7 +1761,7 @@ public final class NatUtil { routerPortsIdentifier).toJavaUtil().map(RouterPorts::getPorts).orElse(emptyList()); } - @Nonnull + @NonNull public static List getRouterUuIdsForVpn(DataBroker broker, Uuid vpnUuid) { InstanceIdentifier externalNwIdentifier = InstanceIdentifier.create(ExternalNetworks.class); Optional externalNwData = @@ -1792,7 +1791,7 @@ public final class NatUtil { } } - @Nonnull + @NonNull public static Collection getExternalSubnetIdsFromExternalIps(@Nullable List externalIps) { if (externalIps == null) { return Collections.emptySet(); @@ -1801,7 +1800,7 @@ public final class NatUtil { return externalIps.stream().map(ExternalIps::getSubnetId).collect(Collectors.toSet()); } - @Nonnull + @NonNull public static Collection getExternalSubnetIdsForRouter(DataBroker dataBroker, @Nullable String routerName) { if (routerName == null) { LOG.error("getExternalSubnetIdsForRouter : empty routerName received"); @@ -1820,7 +1819,7 @@ public final class NatUtil { } } - @Nonnull + @NonNull protected static Optional getOptionalExternalSubnets(DataBroker dataBroker, Uuid subnetId) { if (subnetId == null) { @@ -1837,7 +1836,7 @@ public final class NatUtil { LogicalDatastoreType.CONFIGURATION, subnetsIdentifier); } - @Nonnull + @NonNull protected static Optional getOptionalExternalSubnets(TypedReadTransaction tx, Uuid subnetId) { if (subnetId == null) { @@ -1913,7 +1912,7 @@ public final class NatUtil { return result; } - @Nonnull + @NonNull static List getIpsListFromExternalIps(@Nullable List externalIps) { if (externalIps == null) { return emptyList(); @@ -2067,7 +2066,7 @@ public final class NatUtil { .child(VpnInstance.class, new VpnInstanceKey(vpnName)).build(); } - @Nonnull + @NonNull public static List getListOfRdsFromVpnInstance(VpnInstance vpnInstance) { VpnAfConfig vpnConfig = vpnInstance.getIpv4Family(); return vpnConfig.getRouteDistinguisher() != null ? new ArrayList<>( @@ -2547,7 +2546,7 @@ public final class NatUtil { return null; } - @Nonnull + @NonNull public static Optional readOvsdbNode(Node bridgeNode, DataBroker dataBroker) { OvsdbBridgeAugmentation bridgeAugmentation = extractBridgeAugmentation(bridgeNode); if (bridgeAugmentation != null) { diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SNATDefaultRouteProgrammer.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SNATDefaultRouteProgrammer.java index 7efb852268..df1d875d8a 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SNATDefaultRouteProgrammer.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SNATDefaultRouteProgrammer.java @@ -15,10 +15,9 @@ import java.util.Collections; import java.util.List; import java.util.Set; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; - +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.TypedReadWriteTransaction; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SnatServiceImplFactory.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SnatServiceImplFactory.java index 4c647c2f74..86659abc77 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SnatServiceImplFactory.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/SnatServiceImplFactory.java @@ -7,9 +7,9 @@ */ package org.opendaylight.netvirt.natservice.internal; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.datastoreutils.listeners.DataTreeEventCallbackRegistrar; import org.opendaylight.genius.interfacemanager.interfaces.IInterfaceManager; diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/UpgradeStateListener.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/UpgradeStateListener.java index 736316f83d..d32b435ac9 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/UpgradeStateListener.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/UpgradeStateListener.java @@ -15,9 +15,9 @@ import java.math.BigInteger; import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -84,11 +84,11 @@ public class UpgradeStateListener extends AbstractClusteredSyncDataTreeChangeLis } @Override - public void add(@Nonnull UpgradeConfig newDataObject) { + public void add(@NonNull UpgradeConfig newDataObject) { } @Override - public void remove(@Nonnull UpgradeConfig removedDataObject) { + public void remove(@NonNull UpgradeConfig removedDataObject) { if (natMode == NatserviceConfig.NatMode.Conntrack) { return; } @@ -96,7 +96,7 @@ public class UpgradeStateListener extends AbstractClusteredSyncDataTreeChangeLis } @Override - public void update(@Nonnull UpgradeConfig original, UpgradeConfig updated) { + public void update(@NonNull UpgradeConfig original, UpgradeConfig updated) { if (natMode == NatserviceConfig.NatMode.Controller) { if (original.isUpgradeInProgress() && !updated.isUpgradeInProgress()) { Optional npatSwitches = NatUtil.getAllPrimaryNaptSwitches(dataBroker); diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/VpnFloatingIpHandler.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/VpnFloatingIpHandler.java index 6867260811..9348678054 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/VpnFloatingIpHandler.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/internal/VpnFloatingIpHandler.java @@ -20,9 +20,9 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; @@ -269,12 +269,12 @@ public class VpnFloatingIpHandler implements FloatingIPHandler { Futures.addCallback(future, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("onAddFloatingIp : Error in generate label or fib install process", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.info("onAddFloatingIp : Successfully installed custom FIB routes for prefix {}", externalIp); } else { @@ -383,12 +383,12 @@ public class VpnFloatingIpHandler implements FloatingIPHandler { Futures.addCallback(labelFuture, new FutureCallback>() { @Override - public void onFailure(@Nonnull Throwable error) { + public void onFailure(@NonNull Throwable error) { LOG.error("onRemoveFloatingIp : Error in removing the label or custom fib entries", error); } @Override - public void onSuccess(@Nonnull RpcResult result) { + public void onSuccess(@NonNull RpcResult result) { if (result.isSuccessful()) { LOG.debug("onRemoveFloatingIp : Successfully removed the label for the prefix {} from VPN {}", externalIp, vpnName); diff --git a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayCache.java b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayCache.java index 71f35fc0fb..8f96fc7026 100644 --- a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayCache.java +++ b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayCache.java @@ -8,12 +8,12 @@ package org.opendaylight.netvirt.neutronvpn.api.l2gw; import java.util.Collection; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; public interface L2GatewayCache { - @Nonnull - L2GatewayDevice addOrGet(@Nonnull String deviceName); + @NonNull + L2GatewayDevice addOrGet(@NonNull String deviceName); @Nullable L2GatewayDevice remove(String deviceName); @@ -21,6 +21,6 @@ public interface L2GatewayCache { @Nullable L2GatewayDevice get(String deviceName); - @Nonnull + @NonNull Collection getAll(); } diff --git a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayDevice.java b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayDevice.java index 00c1f4115c..65a29b04cc 100644 --- a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayDevice.java +++ b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/l2gw/L2GatewayDevice.java @@ -18,8 +18,8 @@ import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.atomic.AtomicBoolean; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateway.attributes.Devices; @@ -75,7 +75,7 @@ public class L2GatewayDevice { * * @return the tunnel ips */ - @Nonnull + @NonNull public Set getTunnelIps() { return tunnelIps; } @@ -84,7 +84,7 @@ public class L2GatewayDevice { l2gwConnectionIdToDevices.computeIfAbsent(connectionId, key -> Sets.newConcurrentHashSet()).add(device); } - @Nonnull + @NonNull public Collection getDevicesForL2gwConnectionId(Uuid connectionId) { final Set devices = l2gwConnectionIdToDevices.get(connectionId); return devices != null ? devices : Collections.emptyList(); @@ -118,7 +118,7 @@ public class L2GatewayDevice { * * @return the l2 gateway ids */ - @Nonnull + @NonNull public Set getL2GatewayIds() { return l2GatewayIds; } @@ -167,7 +167,7 @@ public class L2GatewayDevice { * * @return the ucast local macs */ - @Nonnull + @NonNull public Collection getUcastLocalMacs() { return new ArrayList<>(ucastLocalMacs); } diff --git a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/utils/NeutronUtils.java b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/utils/NeutronUtils.java index 1f0b93b40f..82170e1763 100644 --- a/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/utils/NeutronUtils.java +++ b/neutronvpn/api/src/main/java/org/opendaylight/netvirt/neutronvpn/api/utils/NeutronUtils.java @@ -15,8 +15,8 @@ import java.util.Locale; import java.util.Objects; import java.util.regex.Pattern; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; @@ -221,7 +221,7 @@ public final class NeutronUtils { } } - @Nonnull + @NonNull public static List getVpnMapRouterIdsListUuid(@Nullable List routerIds) { if (routerIds == null) { return Collections.emptyList(); diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/HostConfigCache.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/HostConfigCache.java index 999f13ddc9..5e6e824aaf 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/HostConfigCache.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/HostConfigCache.java @@ -9,9 +9,9 @@ package org.opendaylight.netvirt.neutronvpn; import com.google.common.base.Optional; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -32,7 +32,7 @@ public class HostConfigCache extends InstanceIdDataObjectCache { cacheProvider); } - public Optional get(@Nonnull String hostId) throws ReadFailedException { + public Optional get(@NonNull String hostId) throws ReadFailedException { InstanceIdentifier hostConfigPath = InstanceIdentifier.builder(Neutron.class) .child(Hostconfigs.class) .child(Hostconfig.class, new HostconfigKey(hostId, "ODL L2")) diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronExternalSubnetHandler.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronExternalSubnetHandler.java index c3dc1dcfb5..00b241cd03 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronExternalSubnetHandler.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronExternalSubnetHandler.java @@ -8,12 +8,10 @@ package org.opendaylight.netvirt.neutronvpn; import java.util.List; - -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; - +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.networks.attributes.networks.Network; import org.slf4j.Logger; diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java index 84814ad0f8..77bc810854 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronHostConfigChangeListener.java @@ -10,10 +10,10 @@ package org.opendaylight.netvirt.neutronvpn; import java.util.HashMap; import java.util.Locale; import java.util.Map; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronNetworkChangeListener.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronNetworkChangeListener.java index 97af8e2861..033bc62739 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronNetworkChangeListener.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronNetworkChangeListener.java @@ -12,11 +12,11 @@ import java.util.Collections; import java.util.List; import java.util.Objects; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase; @@ -189,7 +189,7 @@ public class NeutronNetworkChangeListener } } - @Nonnull + @NonNull private List buildSegments(Network input) { NetworkProviderExtension providerExtension = input.augmentation(NetworkProviderExtension.class); if (providerExtension == null || providerExtension.getSegments() == null) { diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronPortChangeListener.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronPortChangeListener.java index 85564d2bf7..3291985948 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronPortChangeListener.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronPortChangeListener.java @@ -25,10 +25,10 @@ import java.util.Locale; import java.util.Map; import java.util.Set; import java.util.stream.Collectors; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Singleton; import org.apache.commons.lang3.ObjectUtils; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronSubnetGwMacResolver.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronSubnetGwMacResolver.java index dab32fe972..7d70bf78fa 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronSubnetGwMacResolver.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronSubnetGwMacResolver.java @@ -19,11 +19,11 @@ import java.util.concurrent.Executors; import java.util.concurrent.Future; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.arputil.api.ArpConstants; import org.opendaylight.genius.mdsalutil.NWUtil; diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java index 3b50c215ef..629ca008e9 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java @@ -37,11 +37,11 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import java.util.concurrent.locks.ReentrantLock; import java.util.function.Consumer; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.NotificationPublishService; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -268,7 +268,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even // TODO Clean up the exception handling @SuppressWarnings("checkstyle:IllegalCatch") protected void createSubnetmapNode(Uuid subnetId, String subnetIp, Uuid tenantId, Uuid networkId, - @Nullable NetworkAttributes.NetworkType networkType, long segmentationId) { + NetworkAttributes.@Nullable NetworkType networkType, long segmentationId) { try { InstanceIdentifier subnetMapIdentifier = NeutronvpnUtils.buildSubnetMapIdentifier(subnetId); final ReentrantLock lock = lockForUuid(subnetId); @@ -2024,7 +2024,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even && interVpnLink.getFirstEndpoint().getIpAddress().getValue().equals(nexthop)); } - @Nonnull + @NonNull protected List getAdjacencyforExtraRoute(List routeList, String fixedIp) { List adjList = new ArrayList<>(); Map> adjMap = new HashMap<>(); @@ -2384,8 +2384,8 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even * @param networkList List list of network Ids (Uuid), which will be associated. * @return list of formatted strings with detailed error messages. */ - @Nonnull - protected List associateNetworksToVpn(@Nonnull Uuid vpnId, @Nonnull List networkList) { + @NonNull + protected List associateNetworksToVpn(@NonNull Uuid vpnId, @NonNull List networkList) { List failedNwList = new ArrayList<>(); HashSet passedNwList = new HashSet<>(); boolean isExternalNetwork = false; @@ -2500,7 +2500,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even return failedNwList; } - private boolean associateExtNetworkToVpn(@Nonnull Uuid vpnId, @Nonnull Network extNet) { + private boolean associateExtNetworkToVpn(@NonNull Uuid vpnId, @NonNull Network extNet) { if (!addExternalNetworkToVpn(extNet, vpnId)) { return false; } @@ -2549,8 +2549,8 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even * @param networkList List list of network Ids (Uuid), which will be disassociated. * @return list of formatted strings with detailed error messages. */ - @Nonnull - protected List dissociateNetworksFromVpn(@Nonnull Uuid vpnId, @Nonnull List networkList) { + @NonNull + protected List dissociateNetworksFromVpn(@NonNull Uuid vpnId, @NonNull List networkList) { List failedNwList = new ArrayList<>(); HashSet passedNwList = new HashSet<>(); if (networkList.isEmpty()) { @@ -2627,7 +2627,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even return failedNwList; } - private boolean disassociateExtNetworkFromVpn(@Nonnull Uuid vpnId, @Nonnull Network extNet) { + private boolean disassociateExtNetworkFromVpn(@NonNull Uuid vpnId, @NonNull Network extNet) { if (!removeExternalNetworkFromVpn(extNet)) { return false; } @@ -3134,7 +3134,7 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even // TODO Clean up the exception handling @SuppressWarnings("checkstyle:IllegalCatch") - private void writeVpnInterfaceToDs(@Nonnull Collection vpnIdList, String infName, + private void writeVpnInterfaceToDs(@NonNull Collection vpnIdList, String infName, @Nullable Adjacencies adjacencies, Uuid networkUuid, Boolean isRouterInterface, TypedWriteTransaction wrtConfigTxn) { if (vpnIdList.isEmpty() || infName == null) { @@ -3367,8 +3367,8 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even return message; } - protected void addV6PrivateSubnetToExtNetwork(@Nonnull Uuid routerId, @Nonnull Uuid internetVpnId, - @Nonnull Subnetmap subnetMap) { + protected void addV6PrivateSubnetToExtNetwork(@NonNull Uuid routerId, @NonNull Uuid internetVpnId, + @NonNull Subnetmap subnetMap) { updateVpnInternetForSubnet(subnetMap, internetVpnId, true); neutronvpnUtils.updateVpnInstanceWithFallback(routerId, internetVpnId, true); if (neutronvpnUtils.shouldVpnHandleIpVersionChoiceChange(IpVersionChoice.IPV6, routerId, true)) { @@ -3378,8 +3378,8 @@ public class NeutronvpnManager implements NeutronvpnService, AutoCloseable, Even } } - protected void removeV6PrivateSubnetToExtNetwork(@Nonnull Uuid routerId, @Nonnull Uuid internetVpnId, - @Nonnull Subnetmap subnetMap) { + protected void removeV6PrivateSubnetToExtNetwork(@NonNull Uuid routerId, @NonNull Uuid internetVpnId, + @NonNull Subnetmap subnetMap) { updateVpnInternetForSubnet(subnetMap, internetVpnId, false); neutronvpnUtils.updateVpnInstanceWithFallback(routerId, internetVpnId, false); } diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java index 25128c536f..f87b98ac02 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnNatManager.java @@ -15,10 +15,10 @@ import java.util.Iterator; import java.util.List; import java.util.Objects; import java.util.Set; -import javax.annotation.Nullable; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java index 58f98a6aec..6d91d23174 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnUtils.java @@ -38,11 +38,11 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.locks.ReentrantLock; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.StringUtils; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -811,7 +811,7 @@ public class NeutronvpnUtils { return subnetMapList; } - @Nonnull + @NonNull protected List getNeutronRouterSubnetIds(Uuid routerId) { LOG.debug("getNeutronRouterSubnetIds for {}", routerId.getValue()); List subnetIdList = new ArrayList<>(); @@ -1596,7 +1596,7 @@ public class NeutronvpnUtils { * @param routerId the Uuid of the router which you try to reach the external network * @return Uuid of externalNetwork or null if is not exist */ - protected Uuid getExternalNetworkUuidAttachedFromRouterUuid(@Nonnull Uuid routerId) { + protected Uuid getExternalNetworkUuidAttachedFromRouterUuid(@NonNull Uuid routerId) { LOG.debug("getExternalNetworkUuidAttachedFromRouterUuid for {}", routerId.getValue()); Uuid externalNetworkUuid = null; Router router = getNeutronRouter(routerId); @@ -1606,7 +1606,7 @@ public class NeutronvpnUtils { return externalNetworkUuid; } - public Uuid getInternetvpnUuidBoundToRouterId(@Nonnull Uuid routerId) { + public Uuid getInternetvpnUuidBoundToRouterId(@NonNull Uuid routerId) { Uuid netId = getExternalNetworkUuidAttachedFromRouterUuid(routerId); if (netId == null) { return netId; @@ -1622,7 +1622,7 @@ public class NeutronvpnUtils { * @return Uuid of externalVpn or null if it is not found */ @Nullable - public Uuid getInternetvpnUuidBoundToSubnetRouter(@Nonnull Uuid subnetUuid) { + public Uuid getInternetvpnUuidBoundToSubnetRouter(@NonNull Uuid subnetUuid) { Subnetmap subnetmap = getSubnetmap(subnetUuid); Uuid routerUuid = subnetmap.getRouterId(); LOG.debug("getInternetvpnUuidBoundToSubnetRouter for subnetUuid {}", subnetUuid.getValue()); @@ -1638,7 +1638,7 @@ public class NeutronvpnUtils { * @param extNet Provider Network, which has a port attached as external network gateway to router * @return a list of Private Subnetmap Ids of the router with external network gateway */ - public @Nonnull List getPrivateSubnetsToExport(@Nonnull Network extNet, Uuid internetVpnId) { + public @NonNull List getPrivateSubnetsToExport(@NonNull Network extNet, Uuid internetVpnId) { List subList = new ArrayList<>(); List rtrList = new ArrayList<>(); if (internetVpnId != null) { @@ -1723,7 +1723,7 @@ public class NeutronvpnUtils { } } - public void updateVpnInstanceOpWithType(VpnInstanceOpDataEntry.BgpvpnType choice, @Nonnull Uuid vpn) { + public void updateVpnInstanceOpWithType(VpnInstanceOpDataEntry.BgpvpnType choice, @NonNull Uuid vpn) { String primaryRd = getVpnRd(vpn.getValue()); if (primaryRd == null) { LOG.debug("updateVpnInstanceOpWithType: Update BgpvpnType {} for {}." @@ -1815,7 +1815,7 @@ public class NeutronvpnUtils { return listRouterIds; } - @Nonnull + @NonNull public List getDpnsForRouter(String routerUuid) { InstanceIdentifier id = InstanceIdentifier.builder(NeutronRouterDpns.class) .child(RouterDpnList.class, new RouterDpnListKey(routerUuid)).build(); diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/UpgradeStateListener.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/UpgradeStateListener.java index d58930f92d..f0aef8d0f6 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/UpgradeStateListener.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/UpgradeStateListener.java @@ -7,10 +7,9 @@ */ package org.opendaylight.netvirt.neutronvpn; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; - +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -36,15 +35,15 @@ public class UpgradeStateListener extends AbstractClusteredSyncDataTreeChangeLis } @Override - public void add(@Nonnull UpgradeConfig newDataObject) { + public void add(@NonNull UpgradeConfig newDataObject) { } @Override - public void remove(@Nonnull UpgradeConfig removedDataObject) { + public void remove(@NonNull UpgradeConfig removedDataObject) { } @Override - public void update(@Nonnull UpgradeConfig original, UpgradeConfig updated) { + public void update(@NonNull UpgradeConfig original, UpgradeConfig updated) { LOG.info("UpgradeStateListener update from {} to {}", original, updated); neutronSubnetGwMacResolver.sendArpRequestsToExtGateways(); } diff --git a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/evpn/utils/NeutronEvpnUtils.java b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/evpn/utils/NeutronEvpnUtils.java index 2162185cc7..c933e071ea 100644 --- a/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/evpn/utils/NeutronEvpnUtils.java +++ b/neutronvpn/impl/src/main/java/org/opendaylight/netvirt/neutronvpn/evpn/utils/NeutronEvpnUtils.java @@ -11,7 +11,7 @@ import static org.opendaylight.genius.infra.Datastore.CONFIGURATION; import com.google.common.base.Optional; import java.util.Collections; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/policyservice/impl/src/main/java/org/opendaylight/netvirt/policyservice/util/PolicyServiceUtil.java b/policyservice/impl/src/main/java/org/opendaylight/netvirt/policyservice/util/PolicyServiceUtil.java index eb85fe3dcc..d4345af43d 100644 --- a/policyservice/impl/src/main/java/org/opendaylight/netvirt/policyservice/util/PolicyServiceUtil.java +++ b/policyservice/impl/src/main/java/org/opendaylight/netvirt/policyservice/util/PolicyServiceUtil.java @@ -18,9 +18,9 @@ import java.util.Objects; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.stream.Collectors; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -366,7 +366,7 @@ public class PolicyServiceUtil { return aclType != null && aclType.isAssignableFrom(PolicyAcl.class); } - @Nonnull + @NonNull public List getUnderlayNetworkDpnToInterfaces(String underlayNetwork) { InstanceIdentifier identifier = InstanceIdentifier.create(UnderlayNetworks.class) .child(UnderlayNetwork.class, new UnderlayNetworkKey(underlayNetwork)); diff --git a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertEnableCLI.java b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertEnableCLI.java index 5ccf355834..cdd8fb77d9 100644 --- a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertEnableCLI.java +++ b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertEnableCLI.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.qosservice; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertPollIntervalCLI.java b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertPollIntervalCLI.java index 0de3fa07c3..e8dea5ae47 100644 --- a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertPollIntervalCLI.java +++ b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertPollIntervalCLI.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.qosservice; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertThresholdCLI.java b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertThresholdCLI.java index dceed36b2d..31c3ba41c9 100644 --- a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertThresholdCLI.java +++ b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosAlertThresholdCLI.java @@ -8,10 +8,10 @@ package org.opendaylight.netvirt.qosservice; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Argument; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosNeutronUtils.java b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosNeutronUtils.java index 2ebf70f964..878b2c863d 100644 --- a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosNeutronUtils.java +++ b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosNeutronUtils.java @@ -22,10 +22,10 @@ import java.util.concurrent.ConcurrentMap; import java.util.concurrent.CopyOnWriteArraySet; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore; @@ -175,13 +175,13 @@ public class QosNeutronUtils { } } - @Nonnull + @NonNull public Collection getQosNetworks(Uuid qosUuid) { final ConcurrentMap networkMap = qosNetworksMap.get(qosUuid); return networkMap != null ? networkMap.values() : emptyList(); } - @Nonnull + @NonNull public List getSubnetIdsFromNetworkId(Uuid networkId) { InstanceIdentifier networkMapId = InstanceIdentifier.builder(NetworkMaps.class) .child(NetworkMap.class, new NetworkMapKey(networkId)).build(); @@ -191,7 +191,7 @@ public class QosNeutronUtils { ? optionalNetworkMap.get().getSubnetIdList() : emptyList(); } - @Nonnull + @NonNull protected List getPortIdsFromSubnetId(Uuid subnetId) { InstanceIdentifier subnetMapId = InstanceIdentifier .builder(Subnetmaps.class) @@ -656,12 +656,12 @@ public class QosNeutronUtils { return bridgeRefEntry.getBridgeReference(); } - @Nonnull + @NonNull private static InstanceIdentifier getBridgeRefEntryIdentifier(BridgeRefEntryKey bridgeRefEntryKey) { return InstanceIdentifier.builder(BridgeRefInfo.class).child(BridgeRefEntry.class, bridgeRefEntryKey).build(); } - @Nonnull + @NonNull private static InstanceIdentifier getBridgeEntryIdentifier(BridgeEntryKey bridgeEntryKey) { return InstanceIdentifier.builder(BridgeInterfaceInfo.class).child(BridgeEntry.class, bridgeEntryKey).build(); } @@ -714,15 +714,13 @@ public class QosNeutronUtils { new FlowId(getQosFlowId(NwConstants.QOS_DSCP_TABLE, dpnId, ifIndex, ethType))); } - @Nullable - public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang - .ietf.interfaces.rev140508.interfaces.state.Interface getInterfaceStateFromOperDS( - String interfaceName) { + public org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state + .@Nullable Interface getInterfaceStateFromOperDS(String interfaceName) { return MDSALUtil.read(dataBroker, LogicalDatastoreType.OPERATIONAL, createInterfaceStateInstanceIdentifier(interfaceName)).orNull(); } - @Nonnull + @NonNull public static InstanceIdentifier createInterfaceStateInstanceIdentifier( String interfaceName) { @@ -771,7 +769,7 @@ public class QosNeutronUtils { .addAugmentation(StypeOpenflow.class, augBuilder.build()).build(); } - @Nonnull + @NonNull public static String getQosFlowId(short tableId, BigInteger dpId, int lportTag, int ethType) { return new StringBuilder().append(tableId).append(NwConstants.FLOWID_SEPARATOR).append(dpId) .append(NwConstants.FLOWID_SEPARATOR).append(lportTag) diff --git a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosTerminationPointListener.java b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosTerminationPointListener.java index f6337bdf33..89618b2413 100644 --- a/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosTerminationPointListener.java +++ b/qosservice/impl/src/main/java/org/opendaylight/netvirt/qosservice/QosTerminationPointListener.java @@ -11,10 +11,10 @@ package org.opendaylight.netvirt.qosservice; import static org.opendaylight.genius.infra.Datastore.CONFIGURATION; import java.util.Collections; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.AsyncClusteredDataTreeChangeListenerBase; diff --git a/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/providers/OpenFlow13Provider.java b/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/providers/OpenFlow13Provider.java index 5ef5f2228a..088e4d40f9 100644 --- a/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/providers/OpenFlow13Provider.java +++ b/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/providers/OpenFlow13Provider.java @@ -12,8 +12,8 @@ import com.google.common.net.InetAddresses; import java.math.BigInteger; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.TypedWriteTransaction; diff --git a/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/service/domain/ClassifierEntry.java b/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/service/domain/ClassifierEntry.java index 0cc4294c5d..ef21749f19 100644 --- a/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/service/domain/ClassifierEntry.java +++ b/sfc/classifier/impl/src/main/java/org/opendaylight/netvirt/sfc/classifier/service/domain/ClassifierEntry.java @@ -10,7 +10,7 @@ package org.opendaylight.netvirt.sfc.classifier.service.domain; import com.google.common.base.MoreObjects; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.sfc.classifier.service.domain.api.ClassifierEntryRenderer; import org.opendaylight.netvirt.sfc.classifier.service.domain.api.ClassifierRenderableEntry; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.acl.access.list.entries.ace.Matches; diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/DelegatingDataTreeListener.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/DelegatingDataTreeListener.java index 003605e1d0..5d40e675b1 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/DelegatingDataTreeListener.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/DelegatingDataTreeListener.java @@ -14,8 +14,8 @@ import java.util.Collection; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; import java.util.concurrent.ThreadFactory; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; import org.opendaylight.controller.md.sal.binding.api.DataTreeChangeListener; @@ -87,7 +87,7 @@ public abstract class DelegatingDataTreeListener implement } @Override - public void onDataTreeChanged(@Nonnull final Collection> changes) { + public void onDataTreeChanged(@NonNull final Collection> changes) { Preconditions.checkNotNull(changes, "Changes may not be null!"); executorService.execute(() -> processChanges(changes)); } diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/NeutronMdsalHelper.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/NeutronMdsalHelper.java index f1c21cb5c0..870a7a2efc 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/NeutronMdsalHelper.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/NeutronMdsalHelper.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.sfc.translator; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/SfcMdsalHelper.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/SfcMdsalHelper.java index e68a2de06f..f3b1fd0c58 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/SfcMdsalHelper.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/SfcMdsalHelper.java @@ -8,7 +8,7 @@ package org.opendaylight.netvirt.sfc.translator; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/flowclassifier/FlowClassifierTranslator.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/flowclassifier/FlowClassifierTranslator.java index 4816304fd0..5e3de3c3b4 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/flowclassifier/FlowClassifierTranslator.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/flowclassifier/FlowClassifierTranslator.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.sfc.translator.flowclassifier; import java.util.ArrayList; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.Ipv4Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.Ipv6Acl; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev160218.access.lists.Acl; diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/NeutronPortChainListener.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/NeutronPortChainListener.java index ba5216765b..03f6648e9e 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/NeutronPortChainListener.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/NeutronPortChainListener.java @@ -13,8 +13,8 @@ import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -80,7 +80,7 @@ public class NeutronPortChainListener extends DelegatingDataTreeListener oldFcList = origPortChain.getFlowClassifiers(); oldFcList = oldFcList != null ? new ArrayList<>(oldFcList) : new ArrayList<>(); - @Nullable List newFcList = updatePortChain.getFlowClassifiers(); + List newFcList = updatePortChain.getFlowClassifiers(); if (oldFcList != null && newFcList != null) { oldFcList.removeAll(newFcList); if (!oldFcList.isEmpty()) { @@ -112,7 +112,7 @@ public class NeutronPortChainListener extends DelegatingDataTreeListener portChainServiceFunctionList = new ArrayList<>(); //Read chain related port pair group from neutron data store - @Nullable List newPortPairGroups = newPortChain.getPortPairGroups(); + List newPortPairGroups = newPortChain.getPortPairGroups(); if (newPortPairGroups != null) { for (Uuid ppgUuid : newPortPairGroups) { PortPairGroup ppg = neutronMdsalHelper.getNeutronPortPairGroup(ppgUuid); @@ -182,12 +182,12 @@ public class NeutronPortChainListener extends DelegatingDataTreeListener newFlowClassifiers = newPortChain.getFlowClassifiers(); + List newFlowClassifiers = newPortChain.getFlowClassifiers(); processFlowClassifiers(newPortChain, newFlowClassifiers != null ? newFlowClassifiers : Collections.emptyList(), sfp.getName().getValue(), true); } - private void processFlowClassifiers(PortChain pc, @Nonnull List flowClassifiers, @Nullable String sfpName, + private void processFlowClassifiers(PortChain pc, @NonNull List flowClassifiers, @Nullable String sfpName, boolean added) { for (Uuid uuid : flowClassifiers) { SfcFlowClassifier fc = neutronMdsalHelper.getNeutronFlowClassifier(uuid); diff --git a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/PortPairTranslator.java b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/PortPairTranslator.java index e45267ecbf..6fa9b10b9c 100644 --- a/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/PortPairTranslator.java +++ b/sfc/translator/src/main/java/org/opendaylight/netvirt/sfc/translator/portchain/PortPairTranslator.java @@ -12,7 +12,7 @@ import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableBiMap; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.netvirt.sfc.translator.SfcMdsalHelper; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.common.rev151017.SfDataPlaneLocatorName; import org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.common.rev151017.SfName; @@ -48,7 +48,7 @@ public final class PortPairTranslator { private PortPairTranslator() { } - @Nonnull + @NonNull public static ServiceFunction buildServiceFunction( PortPair portPair, PortPairGroup portPairGroup) { diff --git a/statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/StatisticsImpl.java b/statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/StatisticsImpl.java index bc31bb8497..ba84220976 100644 --- a/statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/StatisticsImpl.java +++ b/statistics/impl/src/main/java/org/opendaylight/netvirt/statistics/StatisticsImpl.java @@ -26,7 +26,7 @@ import java.util.Set; import java.util.UUID; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction; @@ -964,7 +964,7 @@ public class StatisticsImpl implements StatisticsService, ICountersInterfaceChan } @Override - public void onSuccess(@Nonnull RpcResult rpcResult) { + public void onSuccess(@NonNull RpcResult rpcResult) { if (rpcResult.isSuccessful()) { LOG.debug("Created IdPool for tap"); } else { diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/ICentralizedSwitchProvider.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/ICentralizedSwitchProvider.java index 5ab4cd1f0c..d791df6ef8 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/ICentralizedSwitchProvider.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/ICentralizedSwitchProvider.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.vpnmanager.api; import java.math.BigInteger; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; /** * ICentralizedSwitchProvider allows to create or interrogate centralized diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnFootprintService.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnFootprintService.java index d239bdf1d3..a1b1a43f22 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnFootprintService.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnFootprintService.java @@ -9,8 +9,8 @@ package org.opendaylight.netvirt.vpnmanager.api; import java.math.BigInteger; -import javax.annotation.Nullable; import org.apache.commons.lang3.tuple.ImmutablePair; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.vpn.to.dpn.list.IpAddresses; public interface IVpnFootprintService { diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnManager.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnManager.java index aea160974f..575686d728 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnManager.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/IVpnManager.java @@ -14,8 +14,8 @@ import java.util.List; import java.util.Set; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.infra.Datastore.Configuration; import org.opendaylight.genius.infra.Datastore.Operational; @@ -36,11 +36,11 @@ public interface IVpnManager { void addExtraRoute(String vpnName, String destination, String nextHop, String rd, @Nullable String routerID, Long l3vni, RouteOrigin origin, @Nullable String intfName, @Nullable Adjacency operationalAdj, VrfEntry.EncapType encapType, Set prefixListForRefreshFib, - @Nonnull TypedWriteTransaction confTx); + @NonNull TypedWriteTransaction confTx); void delExtraRoute(String vpnName, String destination, String nextHop, String rd, @Nullable String routerID, - @Nullable String intfName, @Nonnull TypedWriteTransaction confTx, - @Nonnull TypedWriteTransaction operTx); + @Nullable String intfName, @NonNull TypedWriteTransaction confTx, + @NonNull TypedWriteTransaction operTx); void removePrefixFromBGP(String vpnName, String primaryRd, String extraRouteRd, String vpnInterfaceName, String prefix, String nextHop, String nextHopTunnelIp, BigInteger dpnId, diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/InterfaceUtils.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/InterfaceUtils.java index ecdb4855c7..58cc4402a7 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/InterfaceUtils.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/InterfaceUtils.java @@ -12,7 +12,7 @@ import java.math.BigInteger; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -125,9 +125,8 @@ public final class InterfaceUtils { return id; } - @Nullable public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state - .Interface getInterfaceStateFromOperDS( + .@Nullable Interface getInterfaceStateFromOperDS( DataBroker dataBroker, String interfaceName) { InstanceIdentifier @@ -141,9 +140,8 @@ public final class InterfaceUtils { return null; } - @Nullable public static org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces - .Interface getInterface( + .@Nullable Interface getInterface( DataBroker broker, String interfaceName) { Optional diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnExtraRouteHelper.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnExtraRouteHelper.java index 4a22f35668..1eb9061122 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnExtraRouteHelper.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnExtraRouteHelper.java @@ -16,7 +16,7 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore.Configuration; diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnHelper.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnHelper.java index da6b030423..885da7553c 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnHelper.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/VpnHelper.java @@ -16,8 +16,8 @@ import java.util.Collections; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -129,7 +129,7 @@ public final class VpnHelper { } } - @Nonnull + @NonNull public static List getVpnInterfaceVpnInstanceNamesString(@Nullable List vpnInstanceList) { List listVpn = new ArrayList<>(); if (vpnInstanceList != null) { diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkCache.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkCache.java index 65af87179b..24adfd12e5 100644 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkCache.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkCache.java @@ -9,7 +9,7 @@ package org.opendaylight.netvirt.vpnmanager.api.intervpnlink; import com.google.common.base.Optional; import java.util.List; -import javax.annotation.Nonnull; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.link.states.InterVpnLinkState; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink; @@ -35,6 +35,6 @@ public interface InterVpnLinkCache { Optional getInterVpnLinkByVpnId(String vpnId); - @Nonnull + @NonNull List getAllInterVpnLinks(); } diff --git a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkDataComposite.java b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkDataComposite.java index 9c2972c219..0a1138f5f4 100755 --- a/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkDataComposite.java +++ b/vpnmanager/api/src/main/java/org/opendaylight/netvirt/vpnmanager/api/intervpnlink/InterVpnLinkDataComposite.java @@ -14,7 +14,7 @@ import com.google.common.base.Optional; import java.math.BigInteger; import java.util.List; import java.util.Objects; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.link.states.InterVpnLinkState; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink; import org.slf4j.Logger; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/CentralizedSwitchProvider.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/CentralizedSwitchProvider.java index eaa7f7a79a..b5f88b0917 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/CentralizedSwitchProvider.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/CentralizedSwitchProvider.java @@ -9,9 +9,9 @@ package org.opendaylight.netvirt.vpnmanager; import java.math.BigInteger; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.netvirt.vpnmanager.api.ICentralizedSwitchProvider; @Singleton diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java index 531a226dc4..313cc80729 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java @@ -11,9 +11,9 @@ import com.google.common.base.Optional; import java.math.BigInteger; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java index 1b87cf5669..8191fa26df 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java @@ -12,10 +12,10 @@ import com.google.common.util.concurrent.ListenableFuture; import java.math.BigInteger; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nonnull; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; @@ -274,7 +274,7 @@ public class SubnetRouteInterfaceStateChangeListener extends AsyncDataTreeChange LOG.info("{} update: Processed Interface {} update event", LOGGING_PREFIX, update.getName()); } - @Nonnull + @NonNull protected List getSubnetId(Interface intrf) { List listSubnetIds = new ArrayList<>(); if (!NeutronUtils.isUuid(intrf.getName())) { diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRoutePacketInHandler.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRoutePacketInHandler.java index d2999f300c..dd75b7e745 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRoutePacketInHandler.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/SubnetRoutePacketInHandler.java @@ -14,9 +14,9 @@ import java.net.InetAddress; import java.net.UnknownHostException; import java.util.List; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java index 166f81762e..94ead97782 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java @@ -13,16 +13,15 @@ import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.MoreExecutors; - import java.math.BigInteger; import java.util.ArrayList; import java.util.List; import java.util.concurrent.ExecutionException; import java.util.concurrent.atomic.AtomicBoolean; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; import org.apache.commons.lang3.tuple.ImmutablePair; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.NotificationPublishService; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInstanceListener.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInstanceListener.java index 1133f3ed1f..498ea32f3d 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInstanceListener.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInstanceListener.java @@ -22,10 +22,10 @@ import java.util.Arrays; import java.util.Collections; import java.util.List; import java.util.concurrent.Callable; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java index 4f3081358b..62e9f17ac3 100755 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java @@ -34,11 +34,11 @@ import java.util.concurrent.ExecutionException; import java.util.function.Consumer; import java.util.function.Predicate; import java.util.stream.Collectors; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnManagerImpl.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnManagerImpl.java index 9c319a139f..183ad000ba 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnManagerImpl.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnManagerImpl.java @@ -19,11 +19,11 @@ import java.util.Objects; import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -194,7 +194,7 @@ public class VpnManagerImpl implements IVpnManager { public void addExtraRoute(String vpnName, String destination, String nextHop, String rd, @Nullable String routerID, Long l3vni, RouteOrigin origin, @Nullable String intfName, @Nullable Adjacency operationalAdj, VrfEntry.EncapType encapType, Set prefixListForRefreshFib, - @Nonnull TypedWriteTransaction confTx) { + @NonNull TypedWriteTransaction confTx) { //add extra route to vpn mapping; advertise with nexthop as tunnel ip vpnUtil.syncUpdate(LogicalDatastoreType.OPERATIONAL, VpnExtraRouteHelper.getVpnToExtrarouteVrfIdIdentifier(vpnName, rd != null ? rd : routerID, @@ -257,8 +257,8 @@ public class VpnManagerImpl implements IVpnManager { @Override public void delExtraRoute(String vpnName, String destination, String nextHop, String rd, @Nullable String routerID, - @Nullable String intfName, @Nonnull TypedWriteTransaction confTx, - @Nonnull TypedWriteTransaction operTx) { + @Nullable String intfName, @NonNull TypedWriteTransaction confTx, + @NonNull TypedWriteTransaction operTx) { BigInteger dpnId = null; String tunnelIp = nextHop; if (intfName != null && !intfName.isEmpty()) { diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java index 5980651136..4fcfddd7e2 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java @@ -17,9 +17,9 @@ import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Objects; -import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnUtil.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnUtil.java index 925b14d7d1..7ca8c1e444 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnUtil.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/VpnUtil.java @@ -38,9 +38,9 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.function.Predicate; import java.util.stream.Collectors; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; @@ -432,7 +432,7 @@ public final class VpnUtil { return vpnInstance.isPresent() ? vpnInstance.get() : null; } - @Nonnull + @NonNull List getAllVpnInstanceOpData() { InstanceIdentifier id = InstanceIdentifier.builder(VpnInstanceOpData.class).build(); Optional vpnInstanceOpDataOptional = read(LogicalDatastoreType.OPERATIONAL, id); @@ -442,7 +442,7 @@ public final class VpnUtil { : emptyList(); } - @Nonnull + @NonNull List getDpnVpnInterfaces(VpnInstance vpnInstance, BigInteger dpnId) { @@ -453,7 +453,7 @@ public final class VpnUtil { : emptyList(); } - @Nonnull + @NonNull static List getListOfRdsFromVpnInstance(VpnInstance vpnInstance) { VpnAfConfig vpnConfig = vpnInstance.getIpv4Family(); LOG.trace("vpnConfig {}", vpnConfig); @@ -882,32 +882,32 @@ public final class VpnUtil { new ElanTagNameKey(elanTag)).build(); } - static void removePrefixToInterfaceForVpnId(long vpnId, @Nonnull TypedWriteTransaction operTx) { + static void removePrefixToInterfaceForVpnId(long vpnId, @NonNull TypedWriteTransaction operTx) { // Clean up PrefixToInterface Operational DS operTx.delete(InstanceIdentifier.builder( PrefixToInterface.class).child(VpnIds.class, new VpnIdsKey(vpnId)).build()); } - static void removeVpnExtraRouteForVpn(String vpnName, @Nonnull TypedWriteTransaction operTx) { + static void removeVpnExtraRouteForVpn(String vpnName, @NonNull TypedWriteTransaction operTx) { // Clean up VPNExtraRoutes Operational DS operTx.delete(InstanceIdentifier.builder(VpnToExtraroutes.class).child(Vpn.class, new VpnKey(vpnName)).build()); } @SuppressWarnings("checkstyle:IllegalCatch") - static void removeVpnOpInstance(String vpnName, @Nonnull TypedWriteTransaction operTx) { + static void removeVpnOpInstance(String vpnName, @NonNull TypedWriteTransaction operTx) { // Clean up VPNInstanceOpDataEntry operTx.delete(getVpnInstanceOpDataIdentifier(vpnName)); } - static void removeVpnInstanceToVpnId(String vpnName, @Nonnull TypedWriteTransaction confTx) { + static void removeVpnInstanceToVpnId(String vpnName, @NonNull TypedWriteTransaction confTx) { confTx.delete(VpnOperDsUtils.getVpnInstanceToVpnIdIdentifier(vpnName)); } - static void removeVpnIdToVpnInstance(long vpnId, @Nonnull TypedWriteTransaction confTx) { + static void removeVpnIdToVpnInstance(long vpnId, @NonNull TypedWriteTransaction confTx) { confTx.delete(getVpnIdToVpnInstanceIdentifier(vpnId)); } - static void removeL3nexthopForVpnId(long vpnId, @Nonnull TypedWriteTransaction operTx) { + static void removeL3nexthopForVpnId(long vpnId, @NonNull TypedWriteTransaction operTx) { // Clean up L3NextHop Operational DS operTx.delete(InstanceIdentifier.builder(L3nexthop.class).child( VpnNexthops.class, new VpnNexthopsKey(vpnId)).build()); @@ -1108,7 +1108,7 @@ public final class VpnUtil { return null; } - @Nonnull + @NonNull List getDpnsOnVpn(String vpnInstanceName) { List result = new ArrayList<>(); String rd = getVpnRd(vpnInstanceName); @@ -1229,7 +1229,7 @@ public final class VpnUtil { return extNetwork != null ? extNetwork.getVpnid() : null; } - @Nonnull + @NonNull public List getExternalNetworkRouterIds(Uuid networkId) { Networks extNetwork = getExternalNetwork(networkId); return extNetwork != null && extNetwork.getRouterIds() != null ? extNetwork.getRouterIds() : emptyList(); @@ -1639,8 +1639,7 @@ public final class VpnUtil { return isVxLan ? VrfEntryBase.EncapType.Vxlan : VrfEntryBase.EncapType.Mplsgre; } - @Nullable - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.subnets.Subnets + org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.subnets.@Nullable Subnets getExternalSubnet(Uuid subnetId) { InstanceIdentifier subnetsIdentifier = InstanceIdentifier.builder(ExternalSubnets.class) diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/IVpnLinkServiceImpl.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/IVpnLinkServiceImpl.java index ed744e551f..1bbcb0c6bf 100755 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/IVpnLinkServiceImpl.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/IVpnLinkServiceImpl.java @@ -19,11 +19,11 @@ import java.util.List; import java.util.Map; import java.util.Objects; import java.util.stream.Collectors; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.ManagedNewTransactionRunner; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkCacheImpl.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkCacheImpl.java index 2fbf2c1022..c0a14260b2 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkCacheImpl.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkCacheImpl.java @@ -13,10 +13,10 @@ import com.google.common.collect.ImmutableList; import java.util.List; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.mdsalutil.MDSALUtil; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkLocator.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkLocator.java index 1c2f059c60..3d452ff067 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkLocator.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkLocator.java @@ -16,9 +16,9 @@ import java.util.Objects; import java.util.Set; import java.util.function.Predicate; import java.util.stream.Collectors; -import javax.annotation.Nonnull; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.genius.mdsalutil.NWUtil; import org.opendaylight.netvirt.vpnmanager.VpnUtil; @@ -135,7 +135,7 @@ public class InterVpnLinkLocator { * @return the list of dpnIds where the specified InterVpnLink should not * be installed */ - @Nonnull + @NonNull private List findDpnsWithSimilarIVpnLinks(InterVpnLink interVpnLink, List allInterVpnLinks) { List sameGroupInterVpnLinks = findInterVpnLinksSameGroup(interVpnLink, diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/LearntVpnVipToPortEventProcessor.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/LearntVpnVipToPortEventProcessor.java index 1b9d080101..e30bfdd565 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/LearntVpnVipToPortEventProcessor.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/LearntVpnVipToPortEventProcessor.java @@ -14,11 +14,11 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.concurrent.Callable; -import javax.annotation.Nullable; import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/ipv4/ArpUtils.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/ipv4/ArpUtils.java index 1d876dde33..dd0cf296d0 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/ipv4/ArpUtils.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/iplearn/ipv4/ArpUtils.java @@ -10,7 +10,7 @@ package org.opendaylight.netvirt.vpnmanager.iplearn.ipv4; import java.math.BigInteger; import java.util.ArrayList; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.mdsalutil.ActionInfo; import org.opendaylight.genius.mdsalutil.MDSALUtil; import org.opendaylight.genius.mdsalutil.NWUtil; diff --git a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/populator/impl/L3vpnPopulator.java b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/populator/impl/L3vpnPopulator.java index b149fa6d8c..fd47198f18 100644 --- a/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/populator/impl/L3vpnPopulator.java +++ b/vpnmanager/impl/src/main/java/org/opendaylight/netvirt/vpnmanager/populator/impl/L3vpnPopulator.java @@ -16,7 +16,7 @@ import com.google.common.base.Preconditions; import java.math.BigInteger; import java.util.Collections; import java.util.List; -import javax.annotation.Nullable; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.genius.infra.Datastore.Configuration; diff --git a/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpn.java b/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpn.java index 9f99ca6034..994919ed2e 100644 --- a/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpn.java +++ b/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpn.java @@ -16,10 +16,10 @@ import java.util.Map; import java.util.Objects; import java.util.Set; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; diff --git a/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpnInstanceOpData.java b/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpnInstanceOpData.java index a075b2c764..3e1e4255ce 100644 --- a/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpnInstanceOpData.java +++ b/vpnmanager/shell/src/main/java/org/opendaylight/netvirt/vpnmanager/shell/ShowVpnInstanceOpData.java @@ -13,10 +13,10 @@ import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.concurrent.ExecutionException; -import javax.annotation.Nullable; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.commands.Option; import org.apache.karaf.shell.console.OsgiCommandSupport; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.controller.md.sal.binding.api.DataBroker; import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;