From: Robert Varga Date: Thu, 3 Nov 2022 13:12:34 +0000 (+0100) Subject: More cds-access-api cleanup X-Git-Tag: v6.0.3~6 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=17072677c1de88e6864ae8828efd7b2f9037ef21;p=controller.git More cds-access-api cleanup Fixup previous patch and sprinkle more @Serial annotations. Change-Id: I74414861197bb417dadc445ebc3fc2703a97ea4d Signed-off-by: Robert Varga --- diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java index f6ba2e7970..cd02a20099 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; @@ -21,6 +22,7 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie */ abstract class AbstractLocalHistoryRequestProxy> extends AbstractRequestProxy { + @Serial private static final long serialVersionUID = 1L; protected AbstractLocalHistoryRequestProxy() { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java index efc0e856b2..f31e408889 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.Request; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -22,6 +23,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ public abstract class AbstractLocalTransactionRequest> extends TransactionRequest { + @Serial private static final long serialVersionUID = 1L; AbstractLocalTransactionRequest(final TransactionIdentifier identifier, final long sequence, diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java index 2cd4ec9e73..e139920d6f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadPathTransactionRequestProxyV1.java @@ -11,6 +11,7 @@ import akka.actor.ActorRef; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput; @@ -27,6 +28,7 @@ import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeStreamVer */ abstract class AbstractReadPathTransactionRequestProxyV1> extends AbstractReadTransactionRequestProxyV1 { + @Serial private static final long serialVersionUID = 1L; private YangInstanceIdentifier path; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java index 88820bd1f5..66bca1d746 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequestProxyV1.java @@ -11,6 +11,7 @@ import akka.actor.ActorRef; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -23,7 +24,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ abstract class AbstractReadTransactionRequestProxyV1> extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; + private boolean snapshotOnly; protected AbstractReadTransactionRequestProxyV1() { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java index 437d281e18..b37227056a 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionRequestProxy.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -21,9 +22,10 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ abstract class AbstractTransactionRequestProxy> extends AbstractRequestProxy { + @Serial private static final long serialVersionUID = 1L; - protected AbstractTransactionRequestProxy() { + AbstractTransactionRequestProxy() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java index a1284b703f..187ad71c35 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -21,9 +22,10 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ abstract class AbstractTransactionSuccessProxy> extends AbstractSuccessProxy { + @Serial private static final long serialVersionUID = 1L; - protected AbstractTransactionSuccessProxy() { + AbstractTransactionSuccessProxy() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java index 1b937521ef..12534e037d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java @@ -11,6 +11,7 @@ import static java.util.Objects.requireNonNull; import akka.actor.ActorRef; import com.google.common.base.MoreObjects.ToStringHelper; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.AbstractRequestProxy; import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier; @@ -27,6 +28,7 @@ import org.opendaylight.controller.cluster.access.concepts.RequestException; * It also includes request stream sequencing information. */ public final class ConnectClientRequest extends Request { + @Serial private static final long serialVersionUID = 1L; private final ABIVersion minVersion; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccess.java index ae4426515d..d87a486f79 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccess.java @@ -15,6 +15,7 @@ import akka.actor.ActorSelection; import com.google.common.base.MoreObjects.ToStringHelper; import com.google.common.collect.ImmutableList; import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; +import java.io.Serial; import java.util.List; import java.util.Optional; import org.eclipse.jdt.annotation.NonNull; @@ -29,6 +30,7 @@ import org.opendaylight.yangtools.yang.data.tree.api.ReadOnlyDataTree; * fail, the client can try accessing the provided alternates. */ public final class ConnectClientSuccess extends RequestSuccess { + @Serial private static final long serialVersionUID = 1L; private final @NonNull ImmutableList alternates; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java index 8dd40ac2c4..ed04f03197 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java @@ -15,6 +15,7 @@ import java.io.DataInput; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import java.util.ArrayList; import java.util.List; import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy; @@ -27,6 +28,7 @@ import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier; * @author Robert Varga */ final class ConnectClientSuccessProxyV1 extends AbstractSuccessProxy { + @Serial private static final long serialVersionUID = 1L; private List alternates; @@ -42,9 +44,9 @@ final class ConnectClientSuccessProxyV1 extends AbstractSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java index 0ebd69054d..d5eb96e970 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie * @author Robert Varga */ final class DestroyLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java index 2429947155..a899da944c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; @@ -19,6 +20,7 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; */ final class ExistsTransactionRequestProxyV1 extends AbstractReadPathTransactionRequestProxyV1 { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java index 24de17656d..ed66fb2d3d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java @@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -19,7 +20,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class ExistsTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; + private boolean exists; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to @@ -31,7 +34,7 @@ final class ExistsTransactionSuccessProxyV1 extends AbstractTransactionSuccessPr ExistsTransactionSuccessProxyV1(final ExistsTransactionSuccess request) { super(request); - this.exists = request.getExists(); + exists = request.getExists(); } @Override diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequest.java index ffc0a68b89..5e85316c41 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceRequest.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; import com.google.common.base.Preconditions; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -21,6 +22,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ public final class IncrementTransactionSequenceRequest extends AbstractReadTransactionRequest { + @Serial private static final long serialVersionUID = 1L; private final long increment; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java index a99faabcff..58c017bb94 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/IncrementTransactionSequenceSuccessProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier */ final class IncrementTransactionSequenceSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java index 0d3a687a41..11ebfa55fb 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; import org.opendaylight.controller.cluster.access.concepts.RequestException; @@ -21,6 +22,7 @@ import org.opendaylight.controller.cluster.access.concepts.RequestException; */ final class LocalHistoryFailureProxyV1 extends AbstractRequestFailureProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccess.java index 7480305eb9..99c1de1d61 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccess.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.RequestSuccess; * Success class for {@link RequestSuccess}es involving a specific local history. */ public final class LocalHistorySuccess extends RequestSuccess { + @Serial private static final long serialVersionUID = 1L; public LocalHistorySuccess(final LocalHistoryIdentifier target, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java index 97a7a1c8d6..18ea0bd9de 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; @@ -18,6 +19,7 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie * @author Robert Varga */ final class LocalHistorySuccessProxyV1 extends AbstractSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java index 384c889af8..369aa1515b 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionRequestProxyV1.java @@ -14,6 +14,7 @@ import com.google.common.collect.ImmutableList; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import java.util.ArrayList; import java.util.List; import java.util.Optional; @@ -30,6 +31,7 @@ import org.opendaylight.yangtools.yang.data.impl.schema.ReusableImmutableNormali * @author Robert Varga */ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; private List modifications; @@ -45,9 +47,9 @@ final class ModifyTransactionRequestProxyV1 extends AbstractTransactionRequestPr ModifyTransactionRequestProxyV1(final ModifyTransactionRequest request) { super(request); - this.modifications = requireNonNull(request.getModifications()); - this.protocol = request.getPersistenceProtocol(); - this.streamVersion = request.getVersion().getStreamVersion(); + modifications = requireNonNull(request.getModifications()); + protocol = request.getPersistenceProtocol(); + streamVersion = request.getVersion().getStreamVersion(); } @Override diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java index 0efff09259..4ead55671c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ModifyTransactionSuccessProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class ModifyTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java index 11c344f539..ff7f4ee4e2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie * @author Robert Varga */ final class PurgeLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java index a83b6bcaac..20d1d308f4 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; @@ -18,6 +19,7 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; * @author Robert Varga */ final class ReadTransactionRequestProxyV1 extends AbstractReadPathTransactionRequestProxyV1 { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java index d442f36739..df462cf0c3 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java @@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import java.util.Optional; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @@ -24,6 +25,7 @@ import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeStreamVer * @author Robert Varga */ final class ReadTransactionSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; private Optional data; @@ -38,8 +40,8 @@ final class ReadTransactionSuccessProxyV1 extends AbstractTransactionSuccessProx ReadTransactionSuccessProxyV1(final ReadTransactionSuccess request) { super(request); - this.data = request.getData(); - this.streamVersion = request.getVersion().getStreamVersion(); + data = request.getData(); + streamVersion = request.getVersion().getStreamVersion(); } @Override diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java index 9bc93f9497..a1bf23de6d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/SkipTransactionsResponseProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -14,6 +15,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * serialization format. */ final class SkipTransactionsResponseProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java index 3e67dfe83b..b4f80f64e4 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionAbortRequestProxyV1 extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccess.java index 69c6dddd8f..44de3f69fe 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccess.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ public final class TransactionAbortSuccess extends TransactionSuccess { + @Serial private static final long serialVersionUID = 1L; public TransactionAbortSuccess(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java index c9de3b9703..c04cadc977 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionAbortSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java index e6149bd5da..720305dc42 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ public final class TransactionCanCommitSuccess extends TransactionSuccess { + @Serial private static final long serialVersionUID = 1L; public TransactionCanCommitSuccess(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java index b41ec2998f..b187ce5247 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java @@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -19,6 +20,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionCanCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccess.java index 6b28244484..8ba0b476ad 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccess.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ public final class TransactionCommitSuccess extends TransactionSuccess { + @Serial private static final long serialVersionUID = 1L; public TransactionCommitSuccess(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java index f23da7bac2..42a8151db9 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java index fcb63fd0f5..c510e3f071 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionDoCommitRequestProxyV1 extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java index d3b1dd7cf7..70d1e30e51 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.commands; import java.io.DataInput; import java.io.IOException; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.AbstractRequestFailureProxy; import org.opendaylight.controller.cluster.access.concepts.RequestException; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -20,6 +21,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionFailureProxyV1 extends AbstractRequestFailureProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java index bf044e1a15..2b56cc352b 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionPreCommitRequestProxyV1 extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java index 716f37804c..a349d72e8b 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ public final class TransactionPreCommitSuccess extends TransactionSuccess { + @Serial private static final long serialVersionUID = 1L; public TransactionPreCommitSuccess(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java index 17b1b8da0d..4e71077f83 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionPreCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java index ee56b4c81a..a6be95d9f9 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeRequestProxyV1.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.access.commands; import akka.actor.ActorRef; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -17,6 +18,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionPurgeRequestProxyV1 extends AbstractTransactionRequestProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponse.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponse.java index 54710143bc..1d3a74ab05 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponse.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponse.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.ABIVersion; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ public final class TransactionPurgeResponse extends TransactionSuccess { + @Serial private static final long serialVersionUID = 1L; public TransactionPurgeResponse(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java index d15d7292b5..f51dc606fa 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPurgeResponseProxyV1.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.commands; +import java.io.Serial; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** @@ -16,6 +17,7 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @author Robert Varga */ final class TransactionPurgeResponseProxyV1 extends AbstractTransactionSuccessProxy { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java index 71a731adde..c4d100a560 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java @@ -11,9 +11,11 @@ import java.io.Externalizable; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.opendaylight.yangtools.concepts.WritableObjects; abstract class AbstractEnvelopeProxy> implements Externalizable { + @Serial private static final long serialVersionUID = 1L; private T message; @@ -48,6 +50,7 @@ abstract class AbstractEnvelopeProxy> implements Externa @SuppressWarnings("checkstyle:hiddenField") abstract Envelope createEnvelope(T wrappedNessage, long sessionId, long txSequence); + @Serial final Object readResolve() { return createEnvelope(message, sessionId, txSequence); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java index 0367527a5e..1cc091bdb2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java @@ -14,6 +14,7 @@ import java.io.Externalizable; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.concepts.WritableIdentifier; import org.opendaylight.yangtools.concepts.WritableObjects; @@ -27,7 +28,9 @@ import org.opendaylight.yangtools.concepts.WritableObjects; * @param Message class */ abstract class AbstractMessageProxy> implements Externalizable { + @Serial private static final long serialVersionUID = 1L; + private T target; private long sequence; @@ -52,6 +55,7 @@ abstract class AbstractMessageProxy> extends AbstractEnvelopeProxy { + @Serial private static final long serialVersionUID = 1L; private long executionTimeNanos; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java index c9edfdb05f..818410dbb3 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java @@ -7,6 +7,7 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.concepts.WritableIdentifier; @@ -20,6 +21,7 @@ import org.opendaylight.yangtools.concepts.WritableIdentifier; */ abstract class AbstractResponseProxy> extends AbstractMessageProxy { + @Serial private static final long serialVersionUID = 1L; protected AbstractResponseProxy() { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java index 69e803ef42..d62b593845 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ClientIdentifier.java @@ -61,6 +61,7 @@ public final class ClientIdentifier implements WritableIdentifier { generation = WritableObjects.readLong(in); } + @Serial private Object readResolve() { return new ClientIdentifier(frontendId, generation); } @@ -124,6 +125,7 @@ public final class ClientIdentifier implements WritableIdentifier { .toString(); } + @Serial private Object writeReplace() { return new Proxy(frontendId, generation); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Envelope.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Envelope.java index c6123d6fc3..44cf7171c7 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Envelope.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Envelope.java @@ -10,11 +10,13 @@ package org.opendaylight.controller.cluster.access.concepts; import static java.util.Objects.requireNonNull; import com.google.common.base.MoreObjects; +import java.io.Serial; import java.io.Serializable; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.concepts.Immutable; public abstract class Envelope> implements Immutable, Serializable { + @Serial private static final long serialVersionUID = 1L; private final @NonNull T message; @@ -60,6 +62,7 @@ public abstract class Envelope> implements Immutable, Se .add("txSequence", Long.toHexString(txSequence)).add("message", message).toString(); } + @Serial final Object writeReplace() { return createProxy(); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelope.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelope.java index 1f641eb181..c2daa74203 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelope.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelope.java @@ -7,7 +7,10 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; + public final class FailureEnvelope extends ResponseEnvelope> { + @Serial private static final long serialVersionUID = 1L; public FailureEnvelope(final RequestFailure message, final long sessionId, final long txSequence, diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java index adc50e1eae..65c2f43b7e 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java @@ -7,7 +7,10 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; + final class FailureEnvelopeProxy extends AbstractResponseEnvelopeProxy> { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to be diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java index 00aa6cdd4b..5afaa115b0 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java @@ -55,6 +55,7 @@ public final class FrontendIdentifier implements WritableIdentifier { clientType = FrontendType.readFrom(in); } + @Serial private Object readResolve() { return new FrontendIdentifier(memberName, clientType); } @@ -102,14 +103,8 @@ public final class FrontendIdentifier implements WritableIdentifier { @Override public boolean equals(final Object obj) { - if (this == obj) { - return true; - } - if (!(obj instanceof FrontendIdentifier other)) { - return false; - } - - return memberName.equals(other.memberName) && clientType.equals(other.clientType); + return this == obj || obj instanceof FrontendIdentifier other && memberName.equals(other.memberName) + && clientType.equals(other.clientType); } public @NonNull String toPersistentId() { @@ -121,6 +116,7 @@ public final class FrontendIdentifier implements WritableIdentifier { return toPersistentId(); } + @Serial private Object writeReplace() { return new Proxy(memberName, clientType); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java index 755eda99bf..b36cbbe403 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java @@ -36,6 +36,7 @@ public final class FrontendType implements Comparable, WritableIde private static final class Proxy implements Externalizable { @Serial private static final long serialVersionUID = 1L; + private byte[] serialized; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to @@ -61,6 +62,7 @@ public final class FrontendType implements Comparable, WritableIde in.readFully(serialized); } + @Serial private Object readResolve() { // TODO: consider caching instances here return new FrontendType(new String(serialized, StandardCharsets.UTF_8), serialized); @@ -156,6 +158,7 @@ public final class FrontendType implements Comparable, WritableIde return local; } + @Serial Object writeReplace() { return new Proxy(getSerialized()); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java index 137bf5907f..e6050e76c5 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java @@ -16,6 +16,7 @@ import java.io.Externalizable; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; +import java.io.Serial; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.concepts.WritableIdentifier; import org.opendaylight.yangtools.concepts.WritableObjects; @@ -25,8 +26,6 @@ import org.opendaylight.yangtools.concepts.WritableObjects; * - a {@link ClientIdentifier}, which uniquely identifies a single instantiation of a particular frontend * - an unsigned long, which uniquely identifies the history on the backend * - an unsigned long cookie, assigned by the client and meaningless on the backend, which just reflects it back - * - * @author Robert Varga */ public final class LocalHistoryIdentifier implements WritableIdentifier { /* @@ -39,7 +38,9 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { * compatibility. */ private static final class Proxy implements Externalizable { + @Serial private static final long serialVersionUID = 1L; + private ClientIdentifier clientId; private long historyId; private long cookie; @@ -72,12 +73,15 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { cookie = WritableObjects.readSecondLong(in, header); } + @Serial private Object readResolve() { return new LocalHistoryIdentifier(clientId, historyId, cookie); } } + @Serial private static final long serialVersionUID = 1L; + private final @NonNull ClientIdentifier clientId; private final long historyId; private final long cookie; @@ -131,11 +135,10 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { if (this == obj) { return true; } - if (!(obj instanceof LocalHistoryIdentifier)) { + if (!(obj instanceof LocalHistoryIdentifier other)) { return false; } - final LocalHistoryIdentifier other = (LocalHistoryIdentifier) obj; return historyId == other.historyId && cookie == other.cookie && clientId.equals(other.clientId); } @@ -146,6 +149,7 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { .add("cookie", Long.toUnsignedString(cookie, 16)).toString(); } + @Serial private Object writeReplace() { return new Proxy(clientId, historyId, cookie); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java index 2404924c64..f26df83183 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java @@ -58,6 +58,7 @@ public final class MemberName implements Comparable, WritableIdentif in.readFully(serialized); } + @Serial private Object readResolve() { // TODO: consider caching instances here return new MemberName(new String(serialized, StandardCharsets.UTF_8), serialized); @@ -140,6 +141,7 @@ public final class MemberName implements Comparable, WritableIdentif return local; } + @Serial Object writeReplace() { return new Proxy(getSerialized()); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java index 9b1c4c25b3..6ee547fc93 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java @@ -110,8 +110,6 @@ public abstract class Message verifyNotNull(cloneAsVersion(toVersion)); - case TEST_PAST_VERSION, TEST_FUTURE_VERSION -> - throw new IllegalArgumentException("Unhandled ABI version " + toVersion); default -> throw new IllegalArgumentException("Unhandled ABI version " + toVersion); }; } @@ -154,6 +152,7 @@ public abstract class Message externalizableProxy(@NonNull ABIVersion reqVersion); + @Serial protected final Object writeReplace() { return externalizableProxy(version); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelope.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelope.java index 46d5d1f996..4dac0b0330 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelope.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelope.java @@ -8,8 +8,10 @@ package org.opendaylight.controller.cluster.access.concepts; import akka.actor.ActorRef; +import java.io.Serial; public final class RequestEnvelope extends Envelope> { + @Serial private static final long serialVersionUID = 1L; public RequestEnvelope(final Request message, final long sessionId, final long txSequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java index 66e7eaa0a2..21b99807af 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java @@ -7,7 +7,10 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; + final class RequestEnvelopeProxy extends AbstractEnvelopeProxy> { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ResponseEnvelope.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ResponseEnvelope.java index 7936baa169..90fe7beb11 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ResponseEnvelope.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/ResponseEnvelope.java @@ -8,8 +8,10 @@ package org.opendaylight.controller.cluster.access.concepts; import com.google.common.base.Preconditions; +import java.io.Serial; public abstract class ResponseEnvelope> extends Envelope { + @Serial private static final long serialVersionUID = 1L; private final long executionTimeNanos; diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelope.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelope.java index 3c23a23763..bf35c4931f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelope.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelope.java @@ -7,7 +7,10 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; + public final class SuccessEnvelope extends ResponseEnvelope> { + @Serial private static final long serialVersionUID = 1L; public SuccessEnvelope(final RequestSuccess message, final long sessionId, final long txSequence, diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java index 3ac388b9db..76adbb193f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java @@ -7,7 +7,10 @@ */ package org.opendaylight.controller.cluster.access.concepts; +import java.io.Serial; + final class SuccessEnvelopeProxy extends AbstractResponseEnvelopeProxy> { + @Serial private static final long serialVersionUID = 1L; // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java index 354cf8c9bf..29edfe8fda 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java @@ -55,6 +55,7 @@ public final class TransactionIdentifier implements WritableIdentifier { transactionId = WritableObjects.readLong(in); } + @Serial private Object readResolve() { return new TransactionIdentifier(historyId, transactionId); } @@ -119,6 +120,7 @@ public final class TransactionIdentifier implements WritableIdentifier { return toShortString(); } + @Serial private Object writeReplace() { return new Proxy(historyId, transactionId); }