From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 6 Oct 2021 11:33:14 +0000 (+0200)
Subject: Use simple concat in createParsingException()
X-Git-Tag: v2.0.6~47
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=237ed537b1c6605e6b211707a9120ff49db7b243;p=netconf.git

Use simple concat in createParsingException()

String.format() is wasteful as we can use JEP280 to make things
a lot more performant.

Change-Id: Iab3d462b7133e656d30e50c6a08f58e798fa4b9f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2923921d8979043ba44e89e2b7d596db3d07fe85)
---

diff --git a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/YangInstanceIdentifierDeserializer.java b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/YangInstanceIdentifierDeserializer.java
index 004a99d616..8b9ccb8eb1 100644
--- a/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/YangInstanceIdentifierDeserializer.java
+++ b/restconf/restconf-nb-rfc8040/src/main/java/org/opendaylight/restconf/nb/rfc8040/utils/parser/YangInstanceIdentifierDeserializer.java
@@ -297,9 +297,9 @@ public final class YangInstanceIdentifierDeserializer {
             "Bad char '" + currentChar() + "' on the current position.");
     }
 
-    private RestconfDocumentedException createParsingException(final ErrorTag errorTag, final String messagePart) {
-        return new RestconfDocumentedException(String.format(
-            "Could not parse Instance Identifier '%s'. Offset: '%d' : Reason: %s", data, offset, messagePart),
+    private RestconfDocumentedException createParsingException(final ErrorTag errorTag, final String reason) {
+        return new RestconfDocumentedException(
+            "Could not parse Instance Identifier '" + data + "'. Offset: '" + offset + "' : Reason: " + reason,
             ErrorType.PROTOCOL, errorTag);
     }