From: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Date: Thu, 7 Mar 2024 09:15:23 +0000 (+0100)
Subject: Improve NetconfNodeHandlerTest
X-Git-Tag: v7.0.2~7
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=25e61e60e503058e658e9e5409d8a94ff2b4c2da;p=netconf.git

Improve NetconfNodeHandlerTest

Improve code style and add more precise asserts.

JIRA: NETCONF-1250
Change-Id: I101e1147fbdd0f12c4645ecdf8c0197164c4cccc
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
---

diff --git a/apps/netconf-topology/src/test/java/org/opendaylight/netconf/topology/spi/NetconfNodeHandlerTest.java b/apps/netconf-topology/src/test/java/org/opendaylight/netconf/topology/spi/NetconfNodeHandlerTest.java
index 4441846c87..e43172857b 100644
--- a/apps/netconf-topology/src/test/java/org/opendaylight/netconf/topology/spi/NetconfNodeHandlerTest.java
+++ b/apps/netconf-topology/src/test/java/org/opendaylight/netconf/topology/spi/NetconfNodeHandlerTest.java
@@ -10,6 +10,7 @@ package org.opendaylight.netconf.topology.spi;
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.ArgumentMatchers.eq;
@@ -266,11 +267,12 @@ public class NetconfNodeHandlerTest {
     }
 
     @Test
-    public void failToConnectOnUnsupportedConfiguration() throws Exception {
-        var defaultTimer = new DefaultNetconfTimer();
-        var factory = new NetconfClientFactoryImpl(defaultTimer);
+    public void failToConnectOnUnsupportedConfiguration() {
+        final var defaultTimer = new DefaultNetconfTimer();
+        final var factory = new NetconfClientFactoryImpl(defaultTimer);
 
-        NetconfNodeHandler keyAuthHandler = new NetconfNodeHandler(factory, defaultTimer, BASE_SCHEMAS, schemaManager,
+        final var keyId = "keyId";
+        final var keyAuthHandler = new NetconfNodeHandler(factory, defaultTimer, BASE_SCHEMAS, schemaManager,
             schemaAssembler, new NetconfClientConfigurationBuilderFactoryImpl(encryptionService, credentialProvider,
                 sslContextFactoryProvider),
             deviceActionFactory, delegate, DEVICE_ID, NODE_ID, new NetconfNodeBuilder()
@@ -293,7 +295,7 @@ public class NetconfNodeHandlerTest {
                 .setCredentials(new KeyAuthBuilder()
                     .setKeyBased(new KeyBasedBuilder()
                         .setUsername("testuser")
-                        .setKeyId("keyId")
+                        .setKeyId(keyId)
                         .build())
                     .build())
                 .build(), null);
@@ -302,9 +304,11 @@ public class NetconfNodeHandlerTest {
         doReturn(null).when(credentialProvider).credentialForId(any());
         doNothing().when(delegate).onDeviceFailed(any());
         keyAuthHandler.connect();
-        verify(credentialProvider).credentialForId(any());
+        verify(credentialProvider).credentialForId(eq(keyId));
         // attempt to connect fails due to unsupported configuration, and there is attempt to reconnect
-        verify(delegate).onDeviceFailed(any());
+        final var captor = ArgumentCaptor.forClass(Throwable.class);
+        verify(delegate).onDeviceFailed(captor.capture());
+        assertTrue(captor.getValue() instanceof ConnectGivenUpException);
         assertEquals(1, keyAuthHandler.attempts());
     }
 }