From: Robert Varga <robert.varga@pantheon.tech>
Date: Mon, 26 Jun 2023 12:42:24 +0000 (+0200)
Subject: Improve binding-parent
X-Git-Tag: v12.0.0~24
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=367c3c0499e139ced990fd24a549f23c41a535bd;p=mdsal.git

Improve binding-parent

Require basic things for generated code and make sure
maven-dependency-plugin does not trip over optional parts.

Change-Id: I98d11bd165f5f85d324d27039e4c1b75974ee3ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/binding-parent/pom.xml b/binding/binding-parent/pom.xml
index 482b0b9ddc..7d415962c3 100644
--- a/binding/binding-parent/pom.xml
+++ b/binding/binding-parent/pom.xml
@@ -43,14 +43,26 @@
                 </file>
             </activation>
             <dependencies>
+                <dependency>
+                    <groupId>com.github.spotbugs</groupId>
+                    <artifactId>spotbugs-annotations</artifactId>
+                    <optional>true</optional>
+                </dependency>
+                <dependency>
+                    <groupId>com.google.guava</groupId>
+                    <artifactId>guava</artifactId>
+                </dependency>
+                <dependency>
+                    <groupId>org.eclipse.jdt</groupId>
+                    <artifactId>org.eclipse.jdt.annotation</artifactId>
+                </dependency>
                 <dependency>
                     <groupId>org.opendaylight.mdsal</groupId>
                     <artifactId>yang-binding</artifactId>
                 </dependency>
                 <dependency>
-                    <groupId>com.github.spotbugs</groupId>
-                    <artifactId>spotbugs-annotations</artifactId>
-                    <optional>true</optional>
+                    <groupId>org.opendaylight.yangtools</groupId>
+                    <artifactId>yang-common</artifactId>
                 </dependency>
             </dependencies>
             <build>
@@ -90,6 +102,15 @@
                         <groupId>org.codehaus.mojo</groupId>
                         <artifactId>build-helper-maven-plugin</artifactId>
                     </plugin>
+                    <plugin>
+                        <artifactId>maven-dependency-plugin</artifactId>
+                        <configuration>
+                            <ignoredUnusedDeclaredDependencies combine.children="append">
+                                <!-- Binding uses SpotBugs only for some constructs (RPCs) methods -->
+                                <ignoredUnusedDeclaredDependency>com.github.spotbugs:spotbugs-annotations</ignoredUnusedDeclaredDependency>
+                            </ignoredUnusedDeclaredDependencies>
+                        </configuration>
+                    </plugin>
                 </plugins>
             </build>
         </profile>