From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 7 Nov 2018 23:54:50 +0000 (+0100)
Subject: Cleanup ScanningSchemaContext
X-Git-Tag: v3.0.2~36
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=4dfdb8798f5eaa8033a5fa86a9053e2517c0f39c;p=mdsal.git

Cleanup ScanningSchemaContext

This adds a few aesthetic improvements, killing some superfluous
operations.

Change-Id: Ibd4c45c9e5df91852fc7aa392ba34d3fd0c3fb52
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/schema/ScanningSchemaServiceProvider.java b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/schema/ScanningSchemaServiceProvider.java
index 7ee3395421..f3a4f8733e 100644
--- a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/schema/ScanningSchemaServiceProvider.java
+++ b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/schema/ScanningSchemaServiceProvider.java
@@ -39,10 +39,10 @@ public class ScanningSchemaServiceProvider
         implements DOMSchemaService, SchemaContextProvider, DOMYangTextSourceProvider, AutoCloseable {
     private static final Logger LOG = LoggerFactory.getLogger(ScanningSchemaServiceProvider.class);
 
+    private final YangTextSchemaContextResolver contextResolver = YangTextSchemaContextResolver.create("global-bundle");
     @GuardedBy("lock")
-    private final ListenerRegistry<SchemaContextListener> listeners = new ListenerRegistry<>();
+    private final ListenerRegistry<SchemaContextListener> listeners = ListenerRegistry.create();
     private final Object lock = new Object();
-    private final YangTextSchemaContextResolver contextResolver = YangTextSchemaContextResolver.create("global-bundle");
 
     public void tryToUpdateSchemaContext() {
         synchronized (lock) {
@@ -94,15 +94,9 @@ public class ScanningSchemaServiceProvider
     }
 
     public boolean hasListeners() {
-        boolean hasListeners;
         synchronized (lock) {
-            if (Iterables.size(listeners.getListeners()) > 0) {
-                hasListeners = true;
-            } else {
-                hasListeners = false;
-            }
+            return !Iterables.isEmpty(listeners.getListeners());
         }
-        return hasListeners;
     }
 
     @Override
@@ -119,10 +113,7 @@ public class ScanningSchemaServiceProvider
     public ListenerRegistration<SchemaContextListener>
             registerSchemaContextListener(final SchemaContextListener listener) {
         synchronized (lock) {
-            final Optional<SchemaContext> potentialCtx = contextResolver.getSchemaContext();
-            if (potentialCtx.isPresent()) {
-                listener.onGlobalContextUpdated(potentialCtx.get());
-            }
+            contextResolver.getSchemaContext().ifPresent(listener::onGlobalContextUpdated);
             return listeners.register(listener);
         }
     }
@@ -145,9 +136,7 @@ public class ScanningSchemaServiceProvider
     @Override
     public void close() {
         synchronized (lock) {
-            for (final ListenerRegistration<SchemaContextListener> registration : listeners) {
-                registration.close();
-            }
+            listeners.forEach(ListenerRegistration::close);
         }
     }
 }