From: Steven Pisarski <s.pisarski@cablelabs.com>
Date: Fri, 1 May 2015 22:17:04 +0000 (-0600)
Subject: Added comment to the reasoning behind the hashCode() logic implemented in the COPSHan... 
X-Git-Tag: release/lithium~17^2~7
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=529274af8a0f6a49749f38c3390aa1a3647a6558;p=packetcable.git

Added comment to the reasoning behind the hashCode() logic implemented in the COPSHandle class per David M. Karr's review on change #19455.

Change-Id: Idab26a59bc344c93040bea988a98e033873193f4
Signed-off-by: Steven Pisarski <s.pisarski@cablelabs.com>
---

diff --git a/packetcable-driver/src/main/java/org/umu/cops/stack/COPSHandle.java b/packetcable-driver/src/main/java/org/umu/cops/stack/COPSHandle.java
index 9d91d76..06c0358 100644
--- a/packetcable-driver/src/main/java/org/umu/cops/stack/COPSHandle.java
+++ b/packetcable-driver/src/main/java/org/umu/cops/stack/COPSHandle.java
@@ -132,7 +132,15 @@ public class COPSHandle extends COPSObjBase {
     @Override
     public int hashCode() {
         int result = super.hashCode();
-        List<Byte> allBytes = new ArrayList<>();
+
+        /*
+         Retrieve hash for the bytes contained in both COPSData members as equivalent objects may contain 0 value bytes
+         either trailing in the _data member or contained in the _padding. This generally will occur between an object
+         constructed via a public constructor vs. parsed from a byte[].
+
+         This is important as this object is known to be used as a key to Maps.
+          */
+        final List<Byte> allBytes = new ArrayList<>();
         for (final byte val : _data.getData()) {
             allBytes.add(val);
         }