From: Robert Varga <robert.varga@pantheon.tech>
Date: Mon, 13 Jul 2020 11:12:34 +0000 (+0200)
Subject: Remove GeneratorUtil.getTopParentTransportObject()
X-Git-Tag: v6.0.3~9
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=5b89845ae431beca76bdd6ec8d05351fa78a90a5;p=mdsal.git

Remove GeneratorUtil.getTopParentTransportObject()

This method is not used anywhere and is quite inefficient, remove
it.

Change-Id: I3d381793c6c20fb056d03118b942a2257756a4bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtil.java b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtil.java
index 846af7306c..d8bc7ac5b5 100644
--- a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtil.java
+++ b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtil.java
@@ -285,26 +285,6 @@ public final class GeneratorUtil {
         return builder.toString();
     }
 
-    /**
-     * Returns the reference to highest (top parent) Generated Transfer Object.
-     *
-     * @param childTransportObject is generated transfer object which can be extended by other generated transfer object
-     * @return in first case that <code>childTransportObject</code> is not extended then
-     *         <code>childTransportObject</code> is returned. In second case the method is recursive called until first
-     *         case.
-     * @throws IllegalArgumentException if <code>childTransportObject</code> equals <code>null</code>
-     */
-    static GeneratedTransferObject getTopParentTransportObject(final GeneratedTransferObject childTransportObject) {
-        if (childTransportObject == null) {
-            throw new IllegalArgumentException("Parameter childTransportObject can't be null.");
-        }
-        if (childTransportObject.getSuperType() == null) {
-            return childTransportObject;
-        }
-
-        return getTopParentTransportObject(childTransportObject.getSuperType());
-    }
-
     /**
      * Selects from input list of properties only those which have read only attribute set to true.
      *
diff --git a/binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtilTest.java b/binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtilTest.java
index 14690b5220..0a0ee79ced 100644
--- a/binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtilTest.java
+++ b/binding/mdsal-binding-java-api-generator/src/test/java/org/opendaylight/mdsal/binding/java/api/generator/GeneratorUtilTest.java
@@ -148,18 +148,4 @@ public class GeneratorUtilTest {
                 createImports(generatedType)).contains(parameterizedType.getName()));
 
     }
-
-    @Test(expected = IllegalArgumentException.class)
-    public void getTopParentTransportObjectWithExceptionTest() throws Exception {
-        GeneratorUtil.getTopParentTransportObject(null);
-    }
-
-    @Test
-    public void getTopParentTransportObjectTest() throws Exception {
-        assertEquals(enclosedType, GeneratorUtil.getTopParentTransportObject(enclosedType));
-
-        final GeneratedTransferObject parent = mock(GeneratedTransferObject.class);
-        doReturn(parent).when(enclosedType).getSuperType();
-        assertEquals(parent, GeneratorUtil.getTopParentTransportObject(enclosedType));
-    }
 }
\ No newline at end of file