From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 27 Jun 2017 14:53:09 +0000 (+0200)
Subject: BUG-8494: fix failure path thinko
X-Git-Tag: release/carbon-sr1~6
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=5e986f5320c561953759a7beffb11db7e296817c;p=controller.git

BUG-8494: fix failure path thinko

The check should be to see if the failure has *not* been set,
hence invert the check.

Change-Id: I2c3893924f1c985687beedbfae0889388fad15c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/AbstractTransactionHandler.java b/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/AbstractTransactionHandler.java
index f23e7ec194..250b3b30e9 100644
--- a/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/AbstractTransactionHandler.java
+++ b/opendaylight/md-sal/samples/clustering-test-app/provider/src/main/java/org/opendaylight/controller/clustering/it/provider/impl/AbstractTransactionHandler.java
@@ -53,7 +53,7 @@ abstract class AbstractTransactionHandler {
         @Override
         void txFailure(final ListenableFuture<Void> execFuture, final long txId, final Throwable cause) {
             futures.remove(execFuture);
-            if (failure != null) {
+            if (failure == null) {
                 failure = cause;
             }
         }