From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 7 Dec 2023 05:19:36 +0000 (+0100)
Subject: Disable SE_PREVENT_EXT_OBJ_OVERWRITE
X-Git-Tag: v13.0.9~3
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=6cb6b86771b569bdc26b203e38444dc252f19e66;p=odlparent.git

Disable SE_PREVENT_EXT_OBJ_OVERWRITE

SE_PREVENT_EXT_OBJ_OVERWRITE reports a ton of warnings and its heuristic
is quite feeble, forcing a very particular code pattern.

Do not report this issue, as it cannot be fixed in a non-intrusive way.

Change-Id: I3aa71831c3e4eee8bf06bca2ca4eb1ad4a141af9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/spotbugs/src/main/resources/spotbugs-exclude.xml b/spotbugs/src/main/resources/spotbugs-exclude.xml
index 836893c1c..a55185c8a 100644
--- a/spotbugs/src/main/resources/spotbugs-exclude.xml
+++ b/spotbugs/src/main/resources/spotbugs-exclude.xml
@@ -44,6 +44,13 @@
       <Bug pattern="EI_EXPOSE_REP"/>
       <Bug pattern="EI_EXPOSE_REP2"/>
       <Bug pattern="MS_EXPOSE_REP"/>
+
+      <!--
+           https://github.com/spotbugs/spotbugs/issues/2750. The heuristic in this check does not work quite a few
+           cases, such as null guards (which we would use in serialization proxies) and plain if() without an else,
+           such as if(foo != null) { throw new ISE() }.
+      -->
+      <Bug pattern="SE_PREVENT_EXT_OBJ_OVERWRITE"/>
     </Or>
   </Match>
 </FindBugsFilter>