From: Robert Varga Date: Sun, 29 May 2022 21:22:52 +0000 (+0200) Subject: Use arrow cases in mdsal-replicate-netty X-Git-Tag: v10.0.0~45 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=6d4041087b2641b61023f9735d636631ee6432aa;p=mdsal.git Use arrow cases in mdsal-replicate-netty Ditch explicit breaks and use arrow cases instead. Change-Id: Id3a3c6deab7b6137f7c965e9bd0d08454a4970b1 Signed-off-by: Robert Varga --- diff --git a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkRequestHandler.java b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkRequestHandler.java index 6d0d13080d..759472cef3 100644 --- a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkRequestHandler.java +++ b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkRequestHandler.java @@ -61,21 +61,14 @@ final class SinkRequestHandler extends SimpleChannelInboundHandler { final Channel channel = ctx.channel(); LOG.trace("Channel {} received message type {}", channel, msgType); switch (msgType) { - case Constants.MSG_EMPTY_DATA: - handleEmptyData(); - break; - case Constants.MSG_DTC_CHUNK: - chunks.add(msg.retain()); - break; - case Constants.MSG_DTC_APPLY: - handleDtcApply(); - break; - case Constants.MSG_PING: + case Constants.MSG_EMPTY_DATA -> handleEmptyData(); + case Constants.MSG_DTC_CHUNK -> chunks.add(msg.retain()); + case Constants.MSG_DTC_APPLY -> handleDtcApply(); + case Constants.MSG_PING -> { LOG.trace("Received PING from Source, sending PONG"); ctx.channel().writeAndFlush(Constants.PONG); - break; - default: - throw new IllegalStateException("Unexpected message type " + msgType); + } + default -> throw new IllegalStateException("Unexpected message type " + msgType); } } diff --git a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SourceRequestHandler.java b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SourceRequestHandler.java index 8928dbadd3..d2f8fd503d 100644 --- a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SourceRequestHandler.java +++ b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SourceRequestHandler.java @@ -59,13 +59,11 @@ final class SourceRequestHandler extends SimpleChannelInboundHandler { final Channel channel = ctx.channel(); LOG.trace("Channel {} received message type {}", channel, msgType); switch (msgType) { - case Constants.MSG_SUBSCRIBE_REQ: - subscribe(channel, msg); - break; - case Constants.MSG_PONG: - break; - default: - throw new IllegalStateException("Unexpected message type " + msgType); + case Constants.MSG_SUBSCRIBE_REQ -> subscribe(channel, msg); + case Constants.MSG_PONG -> { + // No-op + } + default -> throw new IllegalStateException("Unexpected message type " + msgType); } }