From: michal.kovacik <mikovaci@cisco.com>
Date: Wed, 12 Oct 2016 11:09:52 +0000 (+0200)
Subject: Yangman - make elements accessible via ids - part2
X-Git-Tag: release/carbon~15^2~1
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=81b0fe477ff8004a46914e74dbea101a2e1f850f;p=dlux.git

Yangman - make elements accessible via ids - part2

- add id attributes to dom elements to be simply accessible for automatic
  testing
- part 2

Change-Id: I7b80fc1dd5561dc0400565bce566f44d56568cca
Signed-off-by: michal.kovacik <mikovaci@cisco.com>
---

diff --git a/modules/yangman-resources/src/main/resources/yangman/views/popup/parameters-admin.tpl.html b/modules/yangman-resources/src/main/resources/yangman/views/popup/parameters-admin.tpl.html
index 9a1d17d3..7220094c 100644
--- a/modules/yangman-resources/src/main/resources/yangman/views/popup/parameters-admin.tpl.html
+++ b/modules/yangman-resources/src/main/resources/yangman/views/popup/parameters-admin.tpl.html
@@ -5,6 +5,7 @@
                 <h2>{{'YANGMAN_PARAMETERS_ADMINISTRATION'| translate}}</h2>
                 <span flex></span>
                 <md-button aria-label="{{'YANGMAN_CLOSE'| translate}}"
+                           id="params-admin-close-cross"
                            ng-click="paramsAdmin.close()">
                     <md-icon class="material-icons clickable" >
                         close
@@ -21,6 +22,7 @@
                     <!-- search icon, form, clear button -->
                     <md-icon class="material-icons">search</md-icon>
                     <input class=""
+                           id="params-admin-search-field"
                            type="text"
                            flex
                            ng-change="paramsAdmin.filterChange()"
@@ -28,6 +30,7 @@
                            ng-model="paramsAdmin.search"
                            aria-invalid="false" />
                     <md-button aria-label="{{'YANGMAN_CLEAR_SEARCH'| translate}}"
+                               id="params-admin-search-clear"
                                ng-click="paramsAdmin.clearFilter()"
                                ng-if="paramsAdmin.search">
                         <md-icon class="material-icons clickable" >
@@ -39,7 +42,10 @@
 
                     <!-- sorting menu -->
                     <md-menu md-offset="35 15" layout-align="center start">
-                        <md-button aria-label="{{'YANGMAN_SORT'| translate}}" class="" ng-click="$mdOpenMenu()">
+                        <md-button aria-label="{{'YANGMAN_SORT'| translate}}"
+                                   class=""
+                                   id="params-admin-sort-menu"
+                                   ng-click="$mdOpenMenu()">
                             <i class="material-icons">sort</i>
                             <md-tooltip md-direction="bottom">
                                 {{'YANGMAN_SORTING' | translate}}
@@ -49,6 +55,7 @@
                             <!-- sort by name -->
                             <md-menu-item>
                                 <md-button aria-label="{{'YANGMAN_PARAMS_KEY'| translate}}"
+                                           id="params-admin-sort-name-{{paramsAdmin.sortAsc ? 'desc' : 'asc'}}"
                                            ng-click="paramsAdmin.sortBy('_name', '_value')">
                                     {{'YANGMAN_SORT_BY'| translate}}
                                     {{'YANGMAN_PARAMS_KEY'| translate}}
@@ -60,6 +67,7 @@
                             <!-- sort by value -->
                             <md-menu-item>
                                 <md-button aria-label="{{'YANGMAN_PARAMS_VALUE'| translate}}"
+                                           id="params-admin-sort-value-{{paramsAdmin.sortAsc ? 'desc' : 'asc'}}"
                                            ng-click="paramsAdmin.sortBy('_value', '_name')">
                                     {{'YANGMAN_SORT_BY'| translate}}
                                     {{'YANGMAN_PARAMS_VALUE'| translate}}
@@ -75,7 +83,9 @@
                     <!-- menu for import and export parameters -->
                     <input type="file" accept=".json" id="importParameters" on-read-file="paramsAdmin.importParameters($fileContent)">
                     <md-menu md-offset="35 15" layout-align="center start">
-                        <md-button aria-label="{{ 'YANGMAN_PARAMS_IMPORT_EXPORT' | translate }}" ng-click="$mdOpenMenu()">
+                        <md-button aria-label="{{ 'YANGMAN_PARAMS_IMPORT_EXPORT' | translate }}"
+                                   id="params-admin-import-export-menu"
+                                   ng-click="$mdOpenMenu()">
                             <i class="material-icons">import_export</i>
                             <md-tooltip md-direction="bottom">
                                 {{ 'YANGMAN_PARAMS_IMPORT_EXPORT' | translate }}
@@ -83,14 +93,16 @@
                         </md-button>
                         <md-menu-content>
                             <md-menu-item>
-                                <md-button>
+                                <md-button id="params-admin-import-parameters">
                                     <label for="importParameters">
                                         {{'YANGMAN_IMPORT_PARAMS'| translate}}
                                     </label>
                                 </md-button>
                             </md-menu-item>
                             <md-menu-item>
-                                <md-button aria-label="{{'YANGMAN_EXPORT_PARAMETERS' | translate}}" ng-click="paramsAdmin.exportParameters()">
+                                <md-button aria-label="{{'YANGMAN_EXPORT_PARAMETERS' | translate}}"
+                                           id="params-admin-export-parameters"
+                                           ng-click="paramsAdmin.exportParameters()">
                                     {{'YANGMAN_EXPORT_PARAMETERS' | translate}}
                                 </md-button>
                             </md-menu-item>
@@ -115,16 +127,19 @@
                         <md-input-container>
                             <label>{{'YANGMAN_PARAM_KEY' | translate}}</label>
                             <input name="name_{{$index}}"
+                                   id="params-admin-list-name-{{$index}}"
                                    ng-model="param.name"
                                    ng-required="param.value"
                                    ng-change="paramsAdmin.validateNamesUnique()"
                                    ng-focus="$last && paramsAdmin.createEmptyParam()"
                                    autocomplete="off">
                             <div ng-messages="paramsAdmin.paramsForm['name_'+$index].$error" multiple md-auto-hide="false">
-                                <div ng-message="required">
+                                <div ng-message="required"
+                                     id="params-admin-name-required">
                                     {{'YANGMAN_PARAM_KEY_REQUIRED'| translate}}
                                 </div>
-                                <div ng-message="unique">
+                                <div ng-message="unique"
+                                     id="params-admin-name-unique">
                                     {{'YANGMAN_PARAM_EXISTING_KEY'| translate}}
                                 </div>
                             </div>
@@ -134,12 +149,15 @@
                         <!-- value input -->
                         <md-input-container flex>
                             <label>{{'YANGMAN_PARAM_VALUE' | translate}}</label>
-                            <input ng-model="param.value" ng-focus="$last && paramsAdmin.createEmptyParam()">
+                            <input ng-model="param.value"
+                                   id="params-admin-value-list-{{$index}}"
+                                   ng-focus="$last && paramsAdmin.createEmptyParam()">
                         </md-input-container>
                         <!-- /value input -->
 
                         <!-- remove param button -->
                         <md-button aria-label="{{'YANGMAN_REMOVE_PARAM' | translate}}"
+                                   id="params-admin-list-remove-{{$index}}"
                                    class=""
                                    ng-if="!$last"
                                    ng-click="paramsAdmin.removeParam(param)">
@@ -159,10 +177,12 @@
         </md-dialog-content>
         <md-dialog-actions layout="row">
             <span flex></span>
-            <md-button ng-click="paramsAdmin.close()">
+            <md-button id="params-admin-close-button" ng-click="paramsAdmin.close()">
                 {{'YANGMAN_CLOSE'| translate}}
             </md-button>
-            <md-button ng-click="paramsAdmin.save()" ng-disabled="!paramsAdmin.paramsForm.$valid">
+            <md-button ng-click="paramsAdmin.save()"
+                       id="params-admin-save-button"
+                       ng-disabled="!paramsAdmin.paramsForm.$valid">
                 {{'YANGMAN_SAVE'| translate}}
             </md-button>
         </md-dialog-actions>
diff --git a/modules/yangman-resources/src/main/resources/yangman/views/rightpanel/request-data.tpl.html b/modules/yangman-resources/src/main/resources/yangman/views/rightpanel/request-data.tpl.html
index 7532780a..96571ddf 100644
--- a/modules/yangman-resources/src/main/resources/yangman/views/rightpanel/request-data.tpl.html
+++ b/modules/yangman-resources/src/main/resources/yangman/views/rightpanel/request-data.tpl.html
@@ -7,6 +7,7 @@
 
 <div class="paramsBox" ng-show="requestData.paramsArray.length">
     <div  ng-repeat="param in requestData.paramsArray" class="line">
-        <strong>&lt;&lt;{{param.name}}&gt;&gt;</strong> : <span>{{param.value !== undefined ? param.value : 'YANGMAN_PARAM_DONT_REPLACE' | translate}}</span>
+        <strong id= "code-mirror-param-name-{{param.name}}">&lt;&lt;{{param.name}}&gt;&gt;</strong> :
+        <span id="code-mirror-param-value-{{param.value}}">{{param.value !== undefined ? param.value : 'YANGMAN_PARAM_DONT_REPLACE' | translate}}</span>
     </div>
 </div>