From: Tom Pantelis <tompantelis@gmail.com>
Date: Wed, 20 Sep 2017 18:00:31 +0000 (-0400)
Subject: Fix sonar warnings in sal-distributed-datastore
X-Git-Tag: release/oxygen~70
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=8232a626b43fdd2f5799da0fbcfb0f02d3c8f4fb;hp=8232a626b43fdd2f5799da0fbcfb0f02d3c8f4fb;p=controller.git

Fix sonar warnings in sal-distributed-datastore

These come from squid:

- String literals should not be duplicated
- Modifiers should be declared in the correct order
- Lambdas and anonymous classes should not have too many lines
- Nested blocks of code should not be left empty
- Local variables should not shadow class fields
- Exception handlers should preserve the original exception
- Utility classes should not have public constructors
- Overriding methods should do more than simply call the same method in the super class
- Unused private fields should be removed

I fixed quite a few of them. Others we'd have to suppress or modify the sonar
config to be more lenient.

Change-Id: I7ce7b2a05feac9844fd9c37927de82b7b8b68ee5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
---