From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 14 Mar 2023 12:37:00 +0000 (+0100)
Subject: Improve XmlCodecFactory a bit
X-Git-Tag: v11.0.0~242
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=90a498521a7ec3fd62ed91c2c0016ab334a93da2;hp=131816618ba0dd44880b58092fc062375f8d7389;p=yangtools.git

Improve XmlCodecFactory a bit

Remove an unneeded cast in test code by exposing the fact that
instanceIdentifierCodec() operates on YangInstanceIdentifier.

JIRA: YANGTOOLS-1473
Change-Id: Ib915a0b4c93674e1e266359070bb6b06da20094c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/codec/yang-data-codec-xml/src/main/java/org/opendaylight/yangtools/yang/data/codec/xml/XmlCodecFactory.java b/codec/yang-data-codec-xml/src/main/java/org/opendaylight/yangtools/yang/data/codec/xml/XmlCodecFactory.java
index 3a9f81d415..95a9262623 100644
--- a/codec/yang-data-codec-xml/src/main/java/org/opendaylight/yangtools/yang/data/codec/xml/XmlCodecFactory.java
+++ b/codec/yang-data-codec-xml/src/main/java/org/opendaylight/yangtools/yang/data/codec/xml/XmlCodecFactory.java
@@ -15,6 +15,7 @@ import java.util.List;
 import org.opendaylight.yangtools.rfc8528.data.api.MountPointContext;
 import org.opendaylight.yangtools.rfc8528.data.util.EmptyMountPointContext;
 import org.opendaylight.yangtools.yang.common.QNameModule;
+import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.impl.codec.AbstractIntegerStringCodec;
 import org.opendaylight.yangtools.yang.data.impl.codec.BinaryStringCodec;
 import org.opendaylight.yangtools.yang.data.impl.codec.BitsStringCodec;
@@ -112,7 +113,7 @@ public final class XmlCodecFactory extends AbstractCodecFactory<XmlCodec<?>> {
     }
 
     @Override
-    protected XmlCodec<?> instanceIdentifierCodec(final InstanceIdentifierTypeDefinition type) {
+    protected XmlCodec<YangInstanceIdentifier> instanceIdentifierCodec(final InstanceIdentifierTypeDefinition type) {
         return new XmlStringInstanceIdentifierCodec(getEffectiveModelContext(), this);
     }
 
diff --git a/codec/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YT1473Test.java b/codec/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YT1473Test.java
index 163f9c0324..639fbcc9a6 100644
--- a/codec/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YT1473Test.java
+++ b/codec/yang-data-codec-xml/src/test/java/org/opendaylight/yangtools/yang/data/codec/xml/YT1473Test.java
@@ -64,8 +64,7 @@ public class YT1473Test {
         assertTrue(id instanceof LeafSchemaNode);
         final var type = ((LeafSchemaNode) id).getType();
         assertTrue(type instanceof InstanceIdentifierTypeDefinition);
-        CODEC = (XmlStringInstanceIdentifierCodec) XmlCodecFactory.create(modelContext)
-                .instanceIdentifierCodec((InstanceIdentifierTypeDefinition) type);
+        CODEC = XmlCodecFactory.create(modelContext).instanceIdentifierCodec((InstanceIdentifierTypeDefinition) type);
     }
 
     @AfterAll