From: Milos Fabian <milfabia@cisco.com>
Date: Tue, 19 Apr 2016 11:46:21 +0000 (+0200)
Subject: Bug 5689: Unhandled message is causing failure
X-Git-Tag: release/boron~172
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=9b6b0df9ccad25843a4b9e970fcf134028fb426e;p=bgpcep.git

Bug 5689: Unhandled message is causing failure

A write transaction is created when message is recieved,
however in case the message is not handled
(i.e. PcError Message without SRP), the transaction
is not sumbitted, which casuse a race with the next transaction.

Submitting the empty transaction of the unhandled message is
a safe way to avoid the problem.

Change-Id: Ie191eec2b9517078f39c5f065243c87b04ddc189
Signed-off-by: Milos Fabian <milfabia@cisco.com>
---

diff --git a/pcep/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java b/pcep/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
index 3d50fd03a0..ab89ddcdbc 100755
--- a/pcep/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
+++ b/pcep/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
@@ -274,6 +274,8 @@ public abstract class AbstractTopologySessionListener<S, L> implements PCEPSessi
 
         if (onMessage(ctx, message)) {
             LOG.info("Unhandled message {} on session {}", message, session);
+            //cancel not supported, submit empty transaction
+            ctx.trans.submit();
             return;
         }