From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 15 Oct 2019 17:31:19 +0000 (+0200)
Subject: Migrate LspDbVersion parsing to ByteBufUtils
X-Git-Tag: release/magnesium~71
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=9b8d7f08b7c9abefea45d7554e2db012d2e4ba77;p=bgpcep.git

Migrate LspDbVersion parsing to ByteBufUtils

This is a simple fixed-length field, there is no point in going
through byte arrays.

Change-Id: Iff5ed97f5539f24f3016612fe1befa25bd26a02c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/pcep/ietf-stateful07/src/main/java/org/opendaylight/protocol/pcep/sync/optimizations/LspDbVersionTlvParser.java b/pcep/ietf-stateful07/src/main/java/org/opendaylight/protocol/pcep/sync/optimizations/LspDbVersionTlvParser.java
index d92f3ab4f4..310106622e 100644
--- a/pcep/ietf-stateful07/src/main/java/org/opendaylight/protocol/pcep/sync/optimizations/LspDbVersionTlvParser.java
+++ b/pcep/ietf-stateful07/src/main/java/org/opendaylight/protocol/pcep/sync/optimizations/LspDbVersionTlvParser.java
@@ -8,29 +8,27 @@
 package org.opendaylight.protocol.pcep.sync.optimizations;
 
 import static com.google.common.base.Preconditions.checkArgument;
-import static org.opendaylight.protocol.util.ByteBufWriteUtil.writeUnsignedLong;
+import static org.opendaylight.protocol.util.ByteBufUtils.readUint64;
+import static org.opendaylight.protocol.util.ByteBufUtils.writeOrZero;
 
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
-import java.math.BigInteger;
 import org.opendaylight.protocol.pcep.spi.PCEPDeserializerException;
 import org.opendaylight.protocol.pcep.spi.TlvParser;
 import org.opendaylight.protocol.pcep.spi.TlvSerializer;
 import org.opendaylight.protocol.pcep.spi.TlvUtil;
-import org.opendaylight.protocol.util.ByteArray;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.pcep.sync.optimizations.rev181109.lsp.db.version.tlv.LspDbVersion;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.pcep.sync.optimizations.rev181109.lsp.db.version.tlv.LspDbVersionBuilder;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.pcep.types.rev181109.Tlv;
 
 public class LspDbVersionTlvParser implements TlvParser, TlvSerializer {
-
     public static final int TYPE = 23;
 
     @Override
     public void serializeTlv(final Tlv tlv, final ByteBuf buffer) {
         checkArgument(tlv instanceof LspDbVersion, "Tlv object is not instance of LspDbVersion.");
         final ByteBuf body = Unpooled.buffer();
-        writeUnsignedLong(((LspDbVersion) tlv).getLspDbVersionValue(), body);
+        writeOrZero(body, ((LspDbVersion) tlv).getLspDbVersionValue());
         TlvUtil.formatTlv(TYPE, body, buffer);
     }
 
@@ -39,7 +37,6 @@ public class LspDbVersionTlvParser implements TlvParser, TlvSerializer {
         if (buffer == null) {
             return null;
         }
-        return new LspDbVersionBuilder().setLspDbVersionValue(new BigInteger(ByteArray.readAllBytes(buffer))).build();
+        return new LspDbVersionBuilder().setLspDbVersionValue(readUint64(buffer)).build();
     }
-
 }