From: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
Date: Tue, 6 Feb 2024 12:05:25 +0000 (+0200)
Subject: OpenAPI: Remove not needed TODOs
X-Git-Tag: v7.0.0~47
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=a4ae8fc808390dd916efbd435492bc6a1cbe4c94;p=netconf.git

OpenAPI: Remove not needed TODOs

Remove TODOs which were left from OpenAPI rewrite and which
we know they are already addressed, we cannot reproduce any issue
or were just no more valid comments.

JIRA: NETCONF-938
Change-Id: Id77f825d2eefe2ea6277bddeeccc6f2d8cb8909c
Signed-off-by: Yaroslav Lastivka <yaroslav.lastivka@pantheon.tech>
---

diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/jaxrs/OpenApiBodyWriter.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/jaxrs/OpenApiBodyWriter.java
index f8e6657568..d73956c203 100644
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/jaxrs/OpenApiBodyWriter.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/jaxrs/OpenApiBodyWriter.java
@@ -40,7 +40,6 @@ public final class OpenApiBodyWriter implements MessageBodyWriter<OpenApiEntity>
         return OpenApiEntity.class.isAssignableFrom(type);
     }
 
-    // TODO IMO we can get rid of implementing MessageBodyWriter
     @Override
     public void writeTo(final OpenApiEntity entity, final Class<?> type, final Type genericType,
             final Annotation[] annotations, final MediaType mediaType, final MultivaluedMap<String, Object> httpHeaders,
diff --git a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/PostEntity.java b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/PostEntity.java
index 54afe2325c..ac22978c6b 100644
--- a/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/PostEntity.java
+++ b/restconf/restconf-openapi/src/main/java/org/opendaylight/restconf/openapi/model/PostEntity.java
@@ -70,7 +70,6 @@ public final class PostEntity extends OperationEntity {
             final var output = rpc.getOutput();
             final var operationName = rpc.getQName().getLocalName();
             if (!output.getChildNodes().isEmpty()) {
-                // TODO: add proper discriminator from DefinitionNames when schemas re-implementation is done
                 final var ref = processOperationsRef(rpc, operationName, "_output");
                 generator.writeObjectFieldStart(String.valueOf(OK.getStatusCode()));
                 generator.writeStringField(DESCRIPTION, String.format("RPC %s success", operationName));
@@ -105,7 +104,6 @@ public final class PostEntity extends OperationEntity {
             generator.writeStringField(DESCRIPTION, operationName + INPUT_SUFFIX);
             generator.writeObjectFieldStart(CONTENT);
             if (!input.getChildNodes().isEmpty()) {
-                // TODO: add proper discriminator from DefinitionNames when schemas re-implementation is done
                 final var ref = processOperationsRef(rpc, operationName, INPUT_SUFFIX);
                 generator.writeObjectFieldStart(MediaType.APPLICATION_JSON);
                 generator.writeObjectFieldStart(SCHEMA);
@@ -149,7 +147,6 @@ public final class PostEntity extends OperationEntity {
             generator.writeStringField(DESCRIPTION, nodeName());
             generator.writeObjectFieldStart(CONTENT);
             final var ref = COMPONENTS_PREFIX + moduleName() + "_" + refPath();
-            //TODO: Remove if and fix this weird logic of top level nodes
             var childConfig = true;
             if (schema() instanceof DataNodeContainer dataSchema) {
                 final var child = dataSchema.getChildNodes().stream()