From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 6 Jul 2022 16:30:01 +0000 (+0200)
Subject: Clarify WebContext.contextParams()
X-Git-Tag: v0.16.0~2
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=a5723d7c1d01af762804f2a2bb7102f7b65e18de;p=aaa.git

Clarify WebContext.contextParams()

ServletContext's initial parameters can include any Object, but there
are implementation indirections, which limit these to Strings. Document
this fact.

Change-Id: Ie402ea1340584d1c0a008122d67fbeccb081b790
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/web/api/src/main/java/org/opendaylight/aaa/web/WebContext.java b/web/api/src/main/java/org/opendaylight/aaa/web/WebContext.java
index a6022aec5..a8ca1a096 100644
--- a/web/api/src/main/java/org/opendaylight/aaa/web/WebContext.java
+++ b/web/api/src/main/java/org/opendaylight/aaa/web/WebContext.java
@@ -120,9 +120,10 @@ public abstract class WebContext {
     public abstract List<ResourceDetails> resources();
 
     /**
-     * Context params. NB: These are the web context's wide parameters; contrary to
-     * individual {@link ServletDetails#initParams()} and
-     * {@link FilterDetails#initParams()}.
+     * Context params. These are the {@link ServletContext}s initial parameters; contrary to individual
+     * {@link ServletDetails#initParams()} and {@link FilterDetails#initParams()}. While a ServletContext accepts
+     * any Object as a parameter, that is not accepted in all implementations. Most notably OSGi HTTP Whiteboard
+     * specification allows only String values, hence we are enforcing that.
      */
     public abstract Map<String, String> contextParams();