From: Robert Varga <robert.varga@pantheon.tech>
Date: Fri, 15 Mar 2019 18:34:00 +0000 (+0100)
Subject: Fix logging placeholders
X-Git-Tag: v3.0.7~29
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=a7f30fae7e99e5abe028ae3eea7647cfd75cc72b;p=mdsal.git

Fix logging placeholders

Upgraded SpotBugs is finding these, fix them up.

Change-Id: I6209c661ccdf17d886d8c776d96fe6b6a32abc1b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMWriteTransactionAdapter.java b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMWriteTransactionAdapter.java
index b3222e0c91..073529bf15 100644
--- a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMWriteTransactionAdapter.java
+++ b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMWriteTransactionAdapter.java
@@ -55,7 +55,7 @@ public class ShardedDOMWriteTransactionAdapter implements DOMDataTreeWriteTransa
 
     @Override
     public boolean cancel() {
-        LOG.debug("{}: Cancelling transaction");
+        LOG.debug("{}: Cancelling transaction", txIdentifier);
         if (finished) {
             return false;
         }
@@ -160,7 +160,7 @@ public class ShardedDOMWriteTransactionAdapter implements DOMDataTreeWriteTransa
         transactionMap.put(LogicalDatastoreType.OPERATIONAL,
                 producerMap.get(LogicalDatastoreType.OPERATIONAL).createTransaction(true));
 
-        LOG.debug("{}: Creating DOMDataTreeWriteCursors delegates");
+        LOG.debug("{}: Creating DOMDataTreeWriteCursors delegates", txIdentifier);
         cursorMap.put(LogicalDatastoreType.CONFIGURATION,
                 transactionMap.get(LogicalDatastoreType.CONFIGURATION)
                         .createCursor(new DOMDataTreeIdentifier(LogicalDatastoreType.CONFIGURATION, path)));
diff --git a/dom/mdsal-dom-schema-service-osgi/src/main/java/org/opendaylight/mdsal/dom/schema/service/osgi/OsgiBundleScanningSchemaService.java b/dom/mdsal-dom-schema-service-osgi/src/main/java/org/opendaylight/mdsal/dom/schema/service/osgi/OsgiBundleScanningSchemaService.java
index 7a9f2f9196..88fe6c4a9b 100644
--- a/dom/mdsal-dom-schema-service-osgi/src/main/java/org/opendaylight/mdsal/dom/schema/service/osgi/OsgiBundleScanningSchemaService.java
+++ b/dom/mdsal-dom-schema-service-osgi/src/main/java/org/opendaylight/mdsal/dom/schema/service/osgi/OsgiBundleScanningSchemaService.java
@@ -141,7 +141,7 @@ public final class OsgiBundleScanningSchemaService extends ScanningSchemaService
                     urls.add(u);
                     LOG.debug("Registered {}", u);
                 } catch (final Exception e) {
-                    LOG.warn("Failed to register {}, ignoring it", e);
+                    LOG.warn("Failed to register {}, ignoring it", u, e);
                 }
             }