From: Robert Varga <robert.varga@pantheon.tech>
Date: Sun, 5 Jan 2020 11:02:37 +0000 (+0100)
Subject: Eliminate use of ByteBufWriteUtil from route-target
X-Git-Tag: release/magnesium~36
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=a9478e82f64e895369e29e5651003bb1da4735df;p=bgpcep.git

Eliminate use of ByteBufWriteUtil from route-target

There is a single caller, which can trivially be updated to use
ByteBufUtils with improved efficiency.

Change-Id: I7f636cfc1d7ecb6922bd5e29026d4137783baeba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---

diff --git a/bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/nlri/RouteTargetConstrainNlriHandler.java b/bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/nlri/RouteTargetConstrainNlriHandler.java
index f6e38e64c7..b89e8df3df 100644
--- a/bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/nlri/RouteTargetConstrainNlriHandler.java
+++ b/bgp/extensions/route-target/src/main/java/org/opendaylight/protocol/bgp/route/targetcontrain/impl/nlri/RouteTargetConstrainNlriHandler.java
@@ -5,11 +5,8 @@
  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
  * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
-
 package org.opendaylight.protocol.bgp.route.targetcontrain.impl.nlri;
 
-import static org.opendaylight.protocol.util.ByteBufWriteUtil.writeUnsignedInt;
-
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import java.util.ArrayList;
@@ -85,7 +82,7 @@ public final class RouteTargetConstrainNlriHandler implements NlriParser, NlriSe
                 nlri.writeByte(RT_BITS_LENGTH);
                 final AsNumber originAs = dest.getOriginAs();
                 if (originAs != null) {
-                    writeUnsignedInt(originAs.getValue(), nlri);
+                    ByteBufUtils.write(nlri, originAs.getValue());
                 }
                 nlri.writeBytes(SimpleRouteTargetConstrainNlriRegistry.getInstance()
                         .serializeRouteTargetConstrain(rtcChoice));