From: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Date: Mon, 3 Feb 2020 11:32:32 +0000 (+0530)
Subject: Missed Table 246 flow
X-Git-Tag: release/magnesium~18
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=commitdiff_plain;h=ac6c7ea166223e35fa5a654f0f39dc609daa0708;p=netvirt.git

Missed Table 246 flow

Table 246 flow was getting programmed from different thread than the other
flows. This was resulting in different remote group id cache sometimes.
Different cache details was the reason for not programming table 246 flows
all the time.

Table 246 flow programming is done alone with other flows in same thread
now to resolve this issue.

Change-Id: I93bacc68a63c924036c7649f3f5a0e09a872b298
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
---

diff --git a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
index b579086e2e..8650bcc9c8 100644
--- a/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
+++ b/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/AbstractAclServiceImpl.java
@@ -844,12 +844,9 @@ public abstract class AbstractAclServiceImpl implements AclServiceListener {
                         remoteAclId, portId);
                 return;
             }
-            jobCoordinator.enqueueJob(remoteAclId.getValue().intern(), () -> {
-                List<FlowEntity> flowEntries = new ArrayList<>();
-                syncRemoteAclTableFromOtherDpns(flowEntries, port, remoteAclId, addOrRemove);
-                programFlows(AclConstants.ACL_JOB_KEY_PREFIX + remoteAclId.getValue(), flowEntries, addOrRemove);
-                return Collections.emptyList();
-            });
+            List<FlowEntity> flowEntries = new ArrayList<>();
+            syncRemoteAclTableFromOtherDpns(flowEntries, port, remoteAclId, addOrRemove);
+            programFlows(AclConstants.ACL_JOB_KEY_PREFIX + remoteAclId.getValue(), flowEntries, addOrRemove);
         }
     }